[Hawkular-commits] [hawkular/hawkular-alerts] 55c877: HWKALERTS-234 MissingCondition issues

[Lucas Ponce]

  Branch: refs/heads/master
  Home:   https://github.com/hawkular/hawkular-alerts
  Commit: 55c877befec37c00a72050dc97d8eb14d1908cd8
      https://github.com/hawkular/hawkular-alerts/commit/55c877befec37c00a72050dc97d8eb14d1908cd8
  Author: Jay Shaughnessy <jshaughn at redhat.com>
  Date:   2017-03-08 (Wed, 08 Mar 2017)

  Changed paths:
    M hawkular-alerts-engine/src/main/java/org/hawkular/alerts/engine/impl/AlertsEngineImpl.java
    M hawkular-alerts-engine/src/main/java/org/hawkular/alerts/engine/util/MissingState.java
    M hawkular-alerts-engine/src/main/resources/org/hawkular/alerts/engine/rules/ConditionMatch.drl
    M hawkular-alerts-rest-tests/src/test/groovy/org/hawkular/alerts/rest/LifecycleITest.groovy

  Log Message:
  -----------
  HWKALERTS-234 MissingCondition issues
- Ensure MissingState evaluations are performed only when the
  condition trigger mode matches the trigger's current mode.
- Fix issue removing entries from missingStates Set
  - update MissingState to have an immutable hashcode.  Hashes
    can not change after being put into a HashSet, otherwise it
    gets lost.
- Fix issue removing facts from rulebase after Trigger retraction
  - let rulebase clean itself up after trigger retraction
  - let code clean up after manual trigger fact removal
  - perform alertsEngineCache removal missingStates removals outside
    of rulebase fact cleanup.


  Commit: 4443d5ccd3984d1b08a87126edcec8d7124ea613
      https://github.com/hawkular/hawkular-alerts/commit/4443d5ccd3984d1b08a87126edcec8d7124ea613
  Author: Lucas Ponce <ponce.ballesteros at gmail.com>
  Date:   2017-03-08 (Wed, 08 Mar 2017)

  Changed paths:
    M hawkular-alerts-engine/src/main/java/org/hawkular/alerts/engine/impl/AlertsEngineImpl.java
    M hawkular-alerts-engine/src/main/java/org/hawkular/alerts/engine/util/MissingState.java
    M hawkular-alerts-engine/src/main/resources/org/hawkular/alerts/engine/rules/ConditionMatch.drl
    M hawkular-alerts-rest-tests/src/test/groovy/org/hawkular/alerts/rest/LifecycleITest.groovy

  Log Message:
  -----------
  Merge pull request #302 from jshaughn/hwkalerts-234

HWKALERTS-234 Apply current trigger mode to MissingState eval


Compare: https://github.com/hawkular/hawkular-alerts/compare/5583dd9ce827...4443d5ccd398