[Hawkular-dev] how long to give for peer-review

Juraci Paixão Kröhling jpkroehling at redhat.com
Wed Feb 10 12:21:43 EST 2016


On 10.02.2016 18:14, John Mazzitelli wrote:
> Once a PR is created and we ask for peer-review and merge, how long should be given to that process before we go ahead and merge the PR?

In theory, one should never merge its own PRs, and PRs should be merged 
only after a "looks good to me" :) In some cases, you do have to chase 
people, though. And in some cases, you do have to merge your own PRs.

- Juca.


More information about the hawkular-dev mailing list