[Hawkular-dev] agent using custom metric IDs

[John Mazzitelli]

> I haven't reviewed your proposal yet but you can take an idea about how MiQ
> links Hawkular metrics inside something that can be managed internally of
> MiQ.
> 
> https://github.com/ManageIQ/manageiq/blob/master/product/live_metrics/middleware_server.yaml
> https://github.com/ManageIQ/manageiq/blob/master/product/live_metrics/middleware_datasource.yaml
> 
> I guess that if the id of the type is still valid, then perhaps nothing
> affects but just to be sure I chime in here just to validate it.

Right. This is OK. The comments in that MiQ code says "It maps the native id used in the provider" - so this is OK because the native IDs (the metric type IDs) remain the same as they are today, nothing changes (what you have there in the miq code - "setName~typeName" is what the IDs will still be.)

The only thing changing is the type NAME (which will no longer be the same as the ID - I strip the "setName~" from it). The reason for this change is because if a person wants to define their own custom metric ID, I needed a way to give them the ability to inject the metric name in their custom metric ID. They will most likely want to use the metric name as part of the metric ID template - so I now support a token of "%MetricTypeName" which users can use - it will be replaced with the name of the metric type (not to include the "setName~" string).