[Hawkular-dev] Line length rule to be removed from Checkstyle

[Stefan Negrea]

Hello Everybody,

Just had a brief chat with Peter. The main problem with that rule is not its application for actual code lines, I think almost everybody liked that. 99% of the frustration came from commented code not formatted to length by the IDEs. The classic example is having a line with 120 characters of Java code, the developer decides to test something by commenting out this line; the commenting takes 3 extra characters for a total of 123 characters. The IDE does not re-format to length and now there is a build error.

>From my discussions with Peter there is no way to apply this rule selectively (eg. do not enforce line length for Java comments). So making the rule optional until that option is available (if it will ever be available) is the only way to remove the source collective of frustration.


Peter, I second your proposal. Thank you!


Stefan 

----- Original Message -----
> From: "Peter Palaga" <ppalaga at redhat.com>
> To: "Discussions around Hawkular development" <hawkular-dev at lists.jboss.org>
> Sent: Friday, March 18, 2016 6:41:52 AM
> Subject: [Hawkular-dev] Line length rule to be removed from Checkstyle
> 
> Hi *,
> 
> I have sent the PR [1] to remove the Line length rule from checkstyle
> altogether. Based on the feedback collected through the dev survey, this
> seems to be the most annoying rule.
> 
> I propose to keep the max line line length of 120 chars as an informal
> recommendation, that would also stay present in the IDE settings as we
> have them now.
> 
> Does anybody want to veto?
> 
> Thanks,
> 
> Peter
> 
> [1] https://github.com/hawkular/hawkular-build-tools/pull/24
> _______________________________________________
> hawkular-dev mailing list
> hawkular-dev at lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/hawkular-dev
>