<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<br>
<font face="Calibri">Hi Jiri,<br>
<br>
I was unaware of that PR, sorry. I see now there has been
previous debate on this topic. My config changes also dealt with
block comments and trailing spaces. I suppose I should commit to
the existing PR </font>branch. The -Dcheckstyle.skip is fine, I
use that along with license.skip, just to speed things up while
developing. But it's not the same as changing the policy we have in
place. I'd argue that comments should not be subject to line length
or trailing whitespace constraints, and that is why I made the
change. We can keep things as is, but if no one really cares I'd
rather the change go in.<br>
<br>
<div class="moz-cite-prefix">On 5/19/2015 3:28 AM, Jiri Kremser
wrote:<br>
</div>
<blockquote
cite="mid:1354505015.999721.1432020512359.JavaMail.zimbra@redhat.com"
type="cite">
<pre wrap="">Hi,
the change is basically the same as this PR <a class="moz-txt-link-freetext" href="https://github.com/hawkular/hawkular-build-tools/pull/10">https://github.com/hawkular/hawkular-build-tools/pull/10</a>
I can re-open it, however, I am pretty fine with using -Dcheckstyle.skip all the time and do the dirty work only once before the commit.
jk
----- Original Message -----
| From: "Jay Shaughnessy" <a class="moz-txt-link-rfc2396E" href="mailto:jshaughn@redhat.com"><jshaughn@redhat.com></a>
| To: <a class="moz-txt-link-abbreviated" href="mailto:hawkular-dev@lists.jboss.org">hawkular-dev@lists.jboss.org</a>
| Sent: Monday, 18 May, 2015 11:20:24 PM
| Subject: [Hawkular-dev] relaxing checkstyle on java comment lines
|
|
| I was getting really tired of checkstyle complaining about line-too-long and
| trailing spaces for Java comment lines. I altered the config file (attached)
| to be more flexible. But I don't have perms to create a PR against
| hawkular-build-tools.
|
| If you'd like to see this changed maybe chime in and the powers that be will
| apply the change.
|
| _______________________________________________
| hawkular-dev mailing list
| <a class="moz-txt-link-abbreviated" href="mailto:hawkular-dev@lists.jboss.org">hawkular-dev@lists.jboss.org</a>
| <a class="moz-txt-link-freetext" href="https://lists.jboss.org/mailman/listinfo/hawkular-dev">https://lists.jboss.org/mailman/listinfo/hawkular-dev</a>
|
_______________________________________________
hawkular-dev mailing list
<a class="moz-txt-link-abbreviated" href="mailto:hawkular-dev@lists.jboss.org">hawkular-dev@lists.jboss.org</a>
<a class="moz-txt-link-freetext" href="https://lists.jboss.org/mailman/listinfo/hawkular-dev">https://lists.jboss.org/mailman/listinfo/hawkular-dev</a>
</pre>
</blockquote>
<br>
</body>
</html>