<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><div class="">Please disregard if you don’t care about typescript linting or formatting.</div><div class=""><br class=""></div><div class="">I have a proposal for some changes to the tslint settings(hawkular/console/src/main/scripts/tslint.json). There are lots of little changes that need to be done to the code because of this tslint policy change. However, these changes produce more consistent, readable code that is better for long term maintenance. </div><div class=""><br class=""></div><div class="">For further reference on tslint rules see:</div><div class=""><a href="http://palantir.github.io/tslint/rules/" class="">http://palantir.github.io/tslint/rules/</a></div><div class=""><br class=""></div><div class="">The second question I have is if this changes are agreed upon. When should it get put in? I’m of the mindset that it should be put in now, but happy to hear any other arguments against it.</div><div class=""><br class=""></div><div class="">HINT: With Webstorm 11, it can read in the tslint file and interactively show all the tslint hints in the code. </div><div class=""><br class=""></div><div class="">Sorry, I didn’t include the diff file.</div><div class=""><br class=""></div><div class="">hawkular/console/src/main/scripts/tslint.json:</div><div class=""><pre style="background-color:#2b2b2b;color:#a9b7c6;font-family:'Menlo';font-size:9.0pt;" class="">{<br class=""> <span style="color:#9876aa;" class="">"rules"</span><span style="color:#cc7832;" class="">: </span>{<br class=""> <span style="color:#9876aa;" class="">"class-name"</span><span style="color:#cc7832;" class="">: </span><span style="color:#cc7832;font-weight:bold;" class="">true</span><span style="color:#cc7832;" class="">,<br class=""></span><span style="color:#cc7832;" class=""> </span><span style="color:#9876aa;" class="">"curly"</span><span style="color:#cc7832;" class="">: </span><span style="color:#cc7832;font-weight:bold;" class="">true</span><span style="color:#cc7832;" class="">,<br class=""></span><span style="color:#cc7832;" class=""> </span><span style="color:#9876aa;" class="">"eofline"</span><span style="color:#cc7832;" class="">: </span><span style="color:#cc7832;font-weight:bold;" class="">true</span><span style="color:#cc7832;" class="">,<br class=""></span><span style="color:#cc7832;" class=""> </span><span style="color:#9876aa;" class="">"forin"</span><span style="color:#cc7832;" class="">: </span><span style="color:#cc7832;font-weight:bold;" class="">true</span><span style="color:#cc7832;" class="">,<br class=""></span><span style="color:#cc7832;" class=""> </span><span style="color:#9876aa;" class="">"indent"</span><span style="color:#cc7832;" class="">: </span>[<span style="color:#cc7832;font-weight:bold;" class="">true</span><span style="color:#cc7832;" class="">, </span><span style="color:#6a8759;" class="">"spaces"</span>]<span style="color:#cc7832;" class="">,<br class=""></span><span style="color:#cc7832;" class=""> </span><span style="color:#9876aa;" class="">"label-position"</span><span style="color:#cc7832;" class="">: </span><span style="color:#cc7832;font-weight:bold;" class="">true</span><span style="color:#cc7832;" class="">,<br class=""></span><span style="color:#cc7832;" class=""> </span><span style="color:#9876aa;" class="">"label-undefined"</span><span style="color:#cc7832;" class="">: </span><span style="color:#cc7832;font-weight:bold;" class="">true</span><span style="color:#cc7832;" class="">,<br class=""></span><span style="color:#cc7832;" class=""> </span><span style="color:#9876aa;" class="">"max-line-length"</span><span style="color:#cc7832;" class="">: </span>[<span style="color:#cc7832;font-weight:bold;" class="">true</span><span style="color:#cc7832;" class="">, </span><span style="color:#6897bb;" class="">120</span>]<span style="color:#cc7832;" class="">,<br class=""></span><span style="color:#cc7832;" class=""> </span><span style="color:#9876aa;" class="">"member-access"</span><span style="color:#cc7832;" class="">: </span><span style="color:#cc7832;font-weight:bold;" class="">true</span><span style="color:#cc7832;" class="">,<br class=""></span><span style="color:#cc7832;" class=""> </span><span style="color:#9876aa;" class="">"no-arg"</span><span style="color:#cc7832;" class="">: </span><span style="color:#cc7832;font-weight:bold;" class="">true</span><span style="color:#cc7832;" class="">,<br class=""></span><span style="color:#cc7832;" class=""> </span><span style="color:#9876aa;" class="">"no-bitwise"</span><span style="color:#cc7832;" class="">: </span><span style="color:#cc7832;font-weight:bold;" class="">true</span><span style="color:#cc7832;" class="">,<br class=""></span><span style="color:#cc7832;" class=""> </span><span style="color:#9876aa;" class="">"no-console"</span><span style="color:#cc7832;" class="">: </span>[<span style="color:#cc7832;font-weight:bold;" class="">true</span><span style="color:#cc7832;" class="">,<br class=""></span><span style="color:#cc7832;" class=""> </span><span style="color:#6a8759;" class="">"trace"<br class=""></span><span style="color:#6a8759;" class=""> </span>]<span style="color:#cc7832;" class="">,<br class=""></span><span style="color:#cc7832;" class=""> </span><span style="color:#9876aa;" class="">"no-construct"</span><span style="color:#cc7832;" class="">: </span><span style="color:#cc7832;font-weight:bold;" class="">true</span><span style="color:#cc7832;" class="">,<br class=""></span><span style="color:#cc7832;" class=""> </span><span style="color:#9876aa;" class="">"no-debugger"</span><span style="color:#cc7832;" class="">: </span><span style="color:#cc7832;font-weight:bold;" class="">false</span><span style="color:#cc7832;" class="">,<br class=""></span><span style="color:#cc7832;" class=""> </span><span style="color:#9876aa;" class="">"no-duplicate-key"</span><span style="color:#cc7832;" class="">: </span><span style="color:#cc7832;font-weight:bold;" class="">true</span><span style="color:#cc7832;" class="">,<br class=""></span><span style="color:#cc7832;" class=""> </span><span style="color:#9876aa;" class="">"no-duplicate-variable"</span><span style="color:#cc7832;" class="">: </span><span style="color:#cc7832;font-weight:bold;" class="">true</span><span style="color:#cc7832;" class="">,<br class=""></span><span style="color:#cc7832;" class=""> </span><span style="color:#9876aa;" class="">"no-empty"</span><span style="color:#cc7832;" class="">: </span><span style="color:#cc7832;font-weight:bold;" class="">true</span><span style="color:#cc7832;" class="">,<br class=""></span><span style="color:#cc7832;" class=""> </span><span style="color:#9876aa;" class="">"no-eval"</span><span style="color:#cc7832;" class="">: </span><span style="color:#cc7832;font-weight:bold;" class="">true</span><span style="color:#cc7832;" class="">,<br class=""></span><span style="color:#cc7832;" class=""> </span><span style="color:#9876aa;" class="">"no-require-imports"</span><span style="color:#cc7832;" class="">: </span><span style="color:#cc7832;font-weight:bold;" class="">true</span><span style="color:#cc7832;" class="">,<br class=""></span><span style="color:#cc7832;" class=""> </span><span style="color:#9876aa;" class="">"no-string-literal"</span><span style="color:#cc7832;" class="">: </span><span style="color:#cc7832;font-weight:bold;" class="">false</span><span style="color:#cc7832;" class="">,<br class=""></span><span style="color:#cc7832;" class=""> </span><span style="color:#9876aa;" class="">"no-switch-case-fall-through"</span><span style="color:#cc7832;" class="">: </span><span style="color:#cc7832;font-weight:bold;" class="">true</span><span style="color:#cc7832;" class="">,<br class=""></span><span style="color:#cc7832;" class=""> </span><span style="color:#9876aa;" class="">"no-shadowed-variable"</span><span style="color:#cc7832;" class="">: </span><span style="color:#cc7832;font-weight:bold;" class="">true</span><span style="color:#cc7832;" class="">,<br class=""></span><span style="color:#cc7832;" class=""> </span><span style="color:#9876aa;" class="">"no-trailing-comma"</span><span style="color:#cc7832;" class="">: </span><span style="color:#cc7832;font-weight:bold;" class="">true</span><span style="color:#cc7832;" class="">,<br class=""></span><span style="color:#cc7832;" class=""> </span><span style="color:#9876aa;" class="">"no-trailing-whitespace"</span><span style="color:#cc7832;" class="">: </span><span style="color:#cc7832;font-weight:bold;" class="">false</span><span style="color:#cc7832;" class="">,<br class=""></span><span style="color:#cc7832;" class=""> </span><span style="color:#9876aa;" class="">"no-unused-expression"</span><span style="color:#cc7832;" class="">: </span><span style="color:#cc7832;font-weight:bold;" class="">true</span><span style="color:#cc7832;" class="">,<br class=""></span><span style="color:#cc7832;" class=""> </span><span style="color:#9876aa;" class="">"no-unused-variable"</span><span style="color:#cc7832;" class="">: </span><span style="color:#cc7832;font-weight:bold;" class="">true</span><span style="color:#cc7832;" class="">,<br class=""></span><span style="color:#cc7832;" class=""> </span><span style="color:#9876aa;" class="">"no-unreachable"</span><span style="color:#cc7832;" class="">: </span><span style="color:#cc7832;font-weight:bold;" class="">true</span><span style="color:#cc7832;" class="">,<br class=""></span><span style="color:#cc7832;" class=""> </span><span style="color:#9876aa;" class="">"no-use-before-declare"</span><span style="color:#cc7832;" class="">: </span><span style="color:#cc7832;font-weight:bold;" class="">true</span><span style="color:#cc7832;" class="">,<br class=""></span><span style="color:#cc7832;" class=""> </span><span style="color:#9876aa;" class="">"no-var-keyword"</span><span style="color:#cc7832;" class="">: </span><span style="color:#cc7832;font-weight:bold;" class="">true</span><span style="color:#cc7832;" class="">,<br class=""></span><span style="color:#cc7832;" class=""> </span><span style="color:#9876aa;" class="">"one-line"</span><span style="color:#cc7832;" class="">: </span>[<span style="color:#cc7832;font-weight:bold;" class="">true</span><span style="color:#cc7832;" class="">,<br class=""></span><span style="color:#cc7832;" class=""> </span><span style="color:#6a8759;" class="">"check-open-brace"</span><span style="color:#cc7832;" class="">,<br class=""></span><span style="color:#cc7832;" class=""> </span><span style="color:#6a8759;" class="">"check-whitespace"</span><span style="color:#cc7832;" class="">,<br class=""></span><span style="color:#cc7832;" class=""> </span><span style="color:#6a8759;" class="">"check-catch"</span><span style="color:#cc7832;" class="">,<br class=""></span><span style="color:#cc7832;" class=""> </span><span style="color:#6a8759;" class="">"check-else"<br class=""></span><span style="color:#6a8759;" class=""> </span>]<span style="color:#cc7832;" class="">,<br class=""></span><span style="color:#cc7832;" class=""> </span><span style="color:#9876aa;" class="">"quotemark"</span><span style="color:#cc7832;" class="">: </span>[<span style="color:#cc7832;font-weight:bold;" class="">true</span><span style="color:#cc7832;" class="">, </span><span style="color:#6a8759;" class="">"single"</span>]<span style="color:#cc7832;" class="">,<br class=""></span><span style="color:#cc7832;" class=""> </span><span style="color:#9876aa;" class="">"radix"</span><span style="color:#cc7832;" class="">: </span><span style="color:#cc7832;font-weight:bold;" class="">false</span><span style="color:#cc7832;" class="">,<br class=""></span><span style="color:#cc7832;" class=""> </span><span style="color:#9876aa;" class="">"semicolon"</span><span style="color:#cc7832;" class="">: </span><span style="color:#cc7832;font-weight:bold;" class="">true</span><span style="color:#cc7832;" class="">,<br class=""></span><span style="color:#cc7832;" class=""> </span><span style="color:#9876aa;" class="">"triple-equals"</span><span style="color:#cc7832;" class="">: </span>[<span style="color:#cc7832;font-weight:bold;" class="">true</span><span style="color:#cc7832;" class="">, </span><span style="color:#6a8759;" class="">"allow-null-check"</span>]<span style="color:#cc7832;" class="">,<br class=""></span><span style="color:#cc7832;" class=""> </span><span style="color:#9876aa;" class="">"typedef-whitespace"</span><span style="color:#cc7832;" class="">: </span>[<span style="color:#cc7832;font-weight:bold;" class="">true</span>]<span style="color:#cc7832;" class="">,<br class=""></span><span style="color:#cc7832;" class=""> </span><span style="color:#9876aa;" class="">"variable-name"</span><span style="color:#cc7832;" class="">: </span>[<span style="color:#cc7832;font-weight:bold;" class="">true</span><span style="color:#cc7832;" class="">, </span><span style="color:#6a8759;" class="">"ban-keywords"</span><span style="color:#cc7832;" class="">, </span><span style="color:#6a8759;" class="">"check-format"</span><span style="color:#cc7832;" class="">, </span><span style="color:#6a8759;" class="">"allow-leading-underscore"</span>]<span style="color:#cc7832;" class="">,<br class=""></span><span style="color:#cc7832;" class=""> </span><span style="color:#9876aa;" class="">"whitespace"</span><span style="color:#cc7832;" class="">: </span>[<span style="color:#cc7832;font-weight:bold;" class="">true</span><span style="color:#cc7832;" class="">,<br class=""></span><span style="color:#cc7832;" class=""> </span><span style="color:#6a8759;" class="">"check-decl"</span><span style="color:#cc7832;" class="">,<br class=""></span><span style="color:#cc7832;" class=""> </span><span style="color:#6a8759;" class="">"check-operator"</span><span style="color:#cc7832;" class="">,<br class=""></span><span style="color:#cc7832;" class=""> </span><span style="color:#6a8759;" class="">"check-type"<br class=""></span><span style="color:#6a8759;" class=""> </span>]<span style="color:#cc7832;" class="">,<br class=""></span><span style="color:#cc7832;" class=""> </span><span style="color:#9876aa;" class="">"license-header"</span><span style="color:#cc7832;" class="">: </span>[ <span style="color:#cc7832;font-weight:bold;" class="">true</span><span style="color:#cc7832;" class="">,<br class=""></span><span style="color:#cc7832;" class=""> </span><span style="color:#6a8759;" class="">"/// Copyright 2014-2016 Red Hat, Inc. and/or its affiliates</span><span style="color:#cc7832;" class="">\n</span><span style="color:#6a8759;" class="">/// and other contributors as indicated by the @author tags.</span><span style="color:#cc7832;" class="">\n</span><span style="color:#6a8759;" class="">///</span><span style="color:#cc7832;" class="">\n</span><span style="color:#6a8759;" class="">/// Licensed under the Apache License, Version 2.0 (the </span><span style="color:#cc7832;" class="">\"</span><span style="color:#6a8759;" class="">License</span><span style="color:#cc7832;" class="">\"</span><span style="color:#6a8759;" class="">);</span><span style="color:#cc7832;" class="">\n</span><span style="color:#6a8759;" class="">/// you may not use this file except in compliance with the License.</span><span style="color:#cc7832;" class="">\n</span><span style="color:#6a8759;" class="">/// You may obtain a copy of the License at</span><span style="color:#cc7832;" class="">\n</span><span style="color:#6a8759;" class="">///</span><span style="color:#cc7832;" class="">\n</span><span style="color:#6a8759;" class="">/// <a href="http://www.apache.org/licenses/LICENSE-2.0" class="">http://www.apache.org/licenses/LICENSE-2.0</a></span><span style="color:#cc7832;" class="">\n</span><span style="color:#6a8759;" class="">///</span><span style="color:#cc7832;" class="">\n</span><span style="color:#6a8759;" class="">/// Unless required by applicable law or agreed to in writing, software</span><span style="color:#cc7832;" class="">\n</span><span style="color:#6a8759;" class="">/// distributed under the License is distributed on an </span><span style="color:#cc7832;" class="">\"</span><span style="color:#6a8759;" class="">AS IS</span><span style="color:#cc7832;" class="">\"</span><span style="color:#6a8759;" class=""> BASIS,</span><span style="color:#cc7832;" class="">\n</span><span style="color:#6a8759;" class="">/// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.</span><span style="color:#cc7832;" class="">\n</span><span style="color:#6a8759;" class="">/// See the License for the specific language governing permissions and</span><span style="color:#cc7832;" class="">\n</span><span style="color:#6a8759;" class="">/// limitations under the License."<br class=""></span><span style="color:#6a8759;" class=""> </span>]<br class=""> }<br class="">}<br class=""></pre><div class=""><br class=""></div></div></body></html>