<div dir="ltr"><div class="gmail_default" style="font-family:monospace,monospace">Hey,<br><br></div><div class="gmail_default" style="font-family:monospace,monospace">We've briefly discussed this but here's the summary of my preferences/modifications:<br><br>"no-trailing-comma": true, => rule name is incorrect, should be
"trailing-comma": [true, {"multiline": "never", "singleline": "never"}]<br><br>"no-trailing-whitespace": false, => should be set to true, line end whitespace is bad for diffs among other things<br><br>"one-line": [true, ... "check-catch", "check-else"], => I'm not much of a one liner person, so if possible not to have else and catch enforced to one line, I'd appreciate. If not, I hope my brain gets used to it :)<br><br>"radix": false, => should be set to true, parseInt without radix might produce unexpected value<br><br></div><div class="gmail_default" style="font-family:monospace,monospace">Also, would add<br><br>"no-consecutive-blank-lines": true => I don't see the need for more than a single blank like, if we want to separate something, we should use a comment stating what comes below, eg: [blank line] /* From here, only magic! */ [blank line]. But this is just personal taste :)<br><br></div><div class="gmail_default" style="font-family:monospace,monospace">Regards,<br></div><div class="gmail_default" style="font-family:monospace,monospace">Alexandre<br></div><div class="gmail_default" style="font-family:monospace,monospace"><br><br></div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Jan 7, 2016 at 5:26 AM, mike thompson <span dir="ltr"><<a href="mailto:mithomps@redhat.com" target="_blank">mithomps@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div style="word-wrap:break-word"><div>Please disregard if you don’t care about typescript linting or formatting.</div><div><br></div><div>I have a proposal for some changes to the tslint settings(hawkular/console/src/main/scripts/tslint.json). There are lots of little changes that need to be done to the code because of this tslint policy change. However, these changes produce more consistent, readable code that is better for long term maintenance. </div><div><br></div><div>For further reference on tslint rules see:</div><div><a href="http://palantir.github.io/tslint/rules/" target="_blank">http://palantir.github.io/tslint/rules/</a></div><div><br></div><div>The second question I have is if this changes are agreed upon. When should it get put in? I’m of the mindset that it should be put in now, but happy to hear any other arguments against it.</div><div><br></div><div>HINT: With Webstorm 11, it can read in the tslint file and interactively show all the tslint hints in the code. </div><div><br></div><div>Sorry, I didn’t include the diff file.</div><div><br></div><div>hawkular/console/src/main/scripts/tslint.json:</div><div><pre style="background-color:rgb(43,43,43);color:rgb(169,183,198);font-family:"Menlo";font-size:9pt">{<br> <span style="color:rgb(152,118,170)">"rules"</span><span style="color:rgb(204,120,50)">: </span>{<br> <span style="color:rgb(152,118,170)">"class-name"</span><span style="color:rgb(204,120,50)">: </span><span style="color:rgb(204,120,50);font-weight:bold">true</span><span style="color:rgb(204,120,50)">,<br></span><span style="color:rgb(204,120,50)"> </span><span style="color:rgb(152,118,170)">"curly"</span><span style="color:rgb(204,120,50)">: </span><span style="color:rgb(204,120,50);font-weight:bold">true</span><span style="color:rgb(204,120,50)">,<br></span><span style="color:rgb(204,120,50)"> </span><span style="color:rgb(152,118,170)">"eofline"</span><span style="color:rgb(204,120,50)">: </span><span style="color:rgb(204,120,50);font-weight:bold">true</span><span style="color:rgb(204,120,50)">,<br></span><span style="color:rgb(204,120,50)"> </span><span style="color:rgb(152,118,170)">"forin"</span><span style="color:rgb(204,120,50)">: </span><span style="color:rgb(204,120,50);font-weight:bold">true</span><span style="color:rgb(204,120,50)">,<br></span><span style="color:rgb(204,120,50)"> </span><span style="color:rgb(152,118,170)">"indent"</span><span style="color:rgb(204,120,50)">: </span>[<span style="color:rgb(204,120,50);font-weight:bold">true</span><span style="color:rgb(204,120,50)">, </span><span style="color:rgb(106,135,89)">"spaces"</span>]<span style="color:rgb(204,120,50)">,<br></span><span style="color:rgb(204,120,50)"> </span><span style="color:rgb(152,118,170)">"label-position"</span><span style="color:rgb(204,120,50)">: </span><span style="color:rgb(204,120,50);font-weight:bold">true</span><span style="color:rgb(204,120,50)">,<br></span><span style="color:rgb(204,120,50)"> </span><span style="color:rgb(152,118,170)">"label-undefined"</span><span style="color:rgb(204,120,50)">: </span><span style="color:rgb(204,120,50);font-weight:bold">true</span><span style="color:rgb(204,120,50)">,<br></span><span style="color:rgb(204,120,50)"> </span><span style="color:rgb(152,118,170)">"max-line-length"</span><span style="color:rgb(204,120,50)">: </span>[<span style="color:rgb(204,120,50);font-weight:bold">true</span><span style="color:rgb(204,120,50)">, </span><span style="color:rgb(104,151,187)">120</span>]<span style="color:rgb(204,120,50)">,<br></span><span style="color:rgb(204,120,50)"> </span><span style="color:rgb(152,118,170)">"member-access"</span><span style="color:rgb(204,120,50)">: </span><span style="color:rgb(204,120,50);font-weight:bold">true</span><span style="color:rgb(204,120,50)">,<br></span><span style="color:rgb(204,120,50)"> </span><span style="color:rgb(152,118,170)">"no-arg"</span><span style="color:rgb(204,120,50)">: </span><span style="color:rgb(204,120,50);font-weight:bold">true</span><span style="color:rgb(204,120,50)">,<br></span><span style="color:rgb(204,120,50)"> </span><span style="color:rgb(152,118,170)">"no-bitwise"</span><span style="color:rgb(204,120,50)">: </span><span style="color:rgb(204,120,50);font-weight:bold">true</span><span style="color:rgb(204,120,50)">,<br></span><span style="color:rgb(204,120,50)"> </span><span style="color:rgb(152,118,170)">"no-console"</span><span style="color:rgb(204,120,50)">: </span>[<span style="color:rgb(204,120,50);font-weight:bold">true</span><span style="color:rgb(204,120,50)">,<br></span><span style="color:rgb(204,120,50)"> </span><span style="color:rgb(106,135,89)">"trace"<br></span><span style="color:rgb(106,135,89)"> </span>]<span style="color:rgb(204,120,50)">,<br></span><span style="color:rgb(204,120,50)"> </span><span style="color:rgb(152,118,170)">"no-construct"</span><span style="color:rgb(204,120,50)">: </span><span style="color:rgb(204,120,50);font-weight:bold">true</span><span style="color:rgb(204,120,50)">,<br></span><span style="color:rgb(204,120,50)"> </span><span style="color:rgb(152,118,170)">"no-debugger"</span><span style="color:rgb(204,120,50)">: </span><span style="color:rgb(204,120,50);font-weight:bold">false</span><span style="color:rgb(204,120,50)">,<br></span><span style="color:rgb(204,120,50)"> </span><span style="color:rgb(152,118,170)">"no-duplicate-key"</span><span style="color:rgb(204,120,50)">: </span><span style="color:rgb(204,120,50);font-weight:bold">true</span><span style="color:rgb(204,120,50)">,<br></span><span style="color:rgb(204,120,50)"> </span><span style="color:rgb(152,118,170)">"no-duplicate-variable"</span><span style="color:rgb(204,120,50)">: </span><span style="color:rgb(204,120,50);font-weight:bold">true</span><span style="color:rgb(204,120,50)">,<br></span><span style="color:rgb(204,120,50)"> </span><span style="color:rgb(152,118,170)">"no-empty"</span><span style="color:rgb(204,120,50)">: </span><span style="color:rgb(204,120,50);font-weight:bold">true</span><span style="color:rgb(204,120,50)">,<br></span><span style="color:rgb(204,120,50)"> </span><span style="color:rgb(152,118,170)">"no-eval"</span><span style="color:rgb(204,120,50)">: </span><span style="color:rgb(204,120,50);font-weight:bold">true</span><span style="color:rgb(204,120,50)">,<br></span><span style="color:rgb(204,120,50)"> </span><span style="color:rgb(152,118,170)">"no-require-imports"</span><span style="color:rgb(204,120,50)">: </span><span style="color:rgb(204,120,50);font-weight:bold">true</span><span style="color:rgb(204,120,50)">,<br></span><span style="color:rgb(204,120,50)"> </span><span style="color:rgb(152,118,170)">"no-string-literal"</span><span style="color:rgb(204,120,50)">: </span><span style="color:rgb(204,120,50);font-weight:bold">false</span><span style="color:rgb(204,120,50)">,<br></span><span style="color:rgb(204,120,50)"> </span><span style="color:rgb(152,118,170)">"no-switch-case-fall-through"</span><span style="color:rgb(204,120,50)">: </span><span style="color:rgb(204,120,50);font-weight:bold">true</span><span style="color:rgb(204,120,50)">,<br></span><span style="color:rgb(204,120,50)"> </span><span style="color:rgb(152,118,170)">"no-shadowed-variable"</span><span style="color:rgb(204,120,50)">: </span><span style="color:rgb(204,120,50);font-weight:bold">true</span><span style="color:rgb(204,120,50)">,<br></span><span style="color:rgb(204,120,50)"> </span><span style="color:rgb(152,118,170)">"no-trailing-comma"</span><span style="color:rgb(204,120,50)">: </span><span style="color:rgb(204,120,50);font-weight:bold">true</span><span style="color:rgb(204,120,50)">,<br></span><span style="color:rgb(204,120,50)"> </span><span style="color:rgb(152,118,170)">"no-trailing-whitespace"</span><span style="color:rgb(204,120,50)">: </span><span style="color:rgb(204,120,50);font-weight:bold">false</span><span style="color:rgb(204,120,50)">,<br></span><span style="color:rgb(204,120,50)"> </span><span style="color:rgb(152,118,170)">"no-unused-expression"</span><span style="color:rgb(204,120,50)">: </span><span style="color:rgb(204,120,50);font-weight:bold">true</span><span style="color:rgb(204,120,50)">,<br></span><span style="color:rgb(204,120,50)"> </span><span style="color:rgb(152,118,170)">"no-unused-variable"</span><span style="color:rgb(204,120,50)">: </span><span style="color:rgb(204,120,50);font-weight:bold">true</span><span style="color:rgb(204,120,50)">,<br></span><span style="color:rgb(204,120,50)"> </span><span style="color:rgb(152,118,170)">"no-unreachable"</span><span style="color:rgb(204,120,50)">: </span><span style="color:rgb(204,120,50);font-weight:bold">true</span><span style="color:rgb(204,120,50)">,<br></span><span style="color:rgb(204,120,50)"> </span><span style="color:rgb(152,118,170)">"no-use-before-declare"</span><span style="color:rgb(204,120,50)">: </span><span style="color:rgb(204,120,50);font-weight:bold">true</span><span style="color:rgb(204,120,50)">,<br></span><span style="color:rgb(204,120,50)"> </span><span style="color:rgb(152,118,170)">"no-var-keyword"</span><span style="color:rgb(204,120,50)">: </span><span style="color:rgb(204,120,50);font-weight:bold">true</span><span style="color:rgb(204,120,50)">,<br></span><span style="color:rgb(204,120,50)"> </span><span style="color:rgb(152,118,170)">"one-line"</span><span style="color:rgb(204,120,50)">: </span>[<span style="color:rgb(204,120,50);font-weight:bold">true</span><span style="color:rgb(204,120,50)">,<br></span><span style="color:rgb(204,120,50)"> </span><span style="color:rgb(106,135,89)">"check-open-brace"</span><span style="color:rgb(204,120,50)">,<br></span><span style="color:rgb(204,120,50)"> </span><span style="color:rgb(106,135,89)">"check-whitespace"</span><span style="color:rgb(204,120,50)">,<br></span><span style="color:rgb(204,120,50)"> </span><span style="color:rgb(106,135,89)">"check-catch"</span><span style="color:rgb(204,120,50)">,<br></span><span style="color:rgb(204,120,50)"> </span><span style="color:rgb(106,135,89)">"check-else"<br></span><span style="color:rgb(106,135,89)"> </span>]<span style="color:rgb(204,120,50)">,<br></span><span style="color:rgb(204,120,50)"> </span><span style="color:rgb(152,118,170)">"quotemark"</span><span style="color:rgb(204,120,50)">: </span>[<span style="color:rgb(204,120,50);font-weight:bold">true</span><span style="color:rgb(204,120,50)">, </span><span style="color:rgb(106,135,89)">"single"</span>]<span style="color:rgb(204,120,50)">,<br></span><span style="color:rgb(204,120,50)"> </span><span style="color:rgb(152,118,170)">"radix"</span><span style="color:rgb(204,120,50)">: </span><span style="color:rgb(204,120,50);font-weight:bold">false</span><span style="color:rgb(204,120,50)">,<br></span><span style="color:rgb(204,120,50)"> </span><span style="color:rgb(152,118,170)">"semicolon"</span><span style="color:rgb(204,120,50)">: </span><span style="color:rgb(204,120,50);font-weight:bold">true</span><span style="color:rgb(204,120,50)">,<br></span><span style="color:rgb(204,120,50)"> </span><span style="color:rgb(152,118,170)">"triple-equals"</span><span style="color:rgb(204,120,50)">: </span>[<span style="color:rgb(204,120,50);font-weight:bold">true</span><span style="color:rgb(204,120,50)">, </span><span style="color:rgb(106,135,89)">"allow-null-check"</span>]<span style="color:rgb(204,120,50)">,<br></span><span style="color:rgb(204,120,50)"> </span><span style="color:rgb(152,118,170)">"typedef-whitespace"</span><span style="color:rgb(204,120,50)">: </span>[<span style="color:rgb(204,120,50);font-weight:bold">true</span>]<span style="color:rgb(204,120,50)">,<br></span><span style="color:rgb(204,120,50)"> </span><span style="color:rgb(152,118,170)">"variable-name"</span><span style="color:rgb(204,120,50)">: </span>[<span style="color:rgb(204,120,50);font-weight:bold">true</span><span style="color:rgb(204,120,50)">, </span><span style="color:rgb(106,135,89)">"ban-keywords"</span><span style="color:rgb(204,120,50)">, </span><span style="color:rgb(106,135,89)">"check-format"</span><span style="color:rgb(204,120,50)">, </span><span style="color:rgb(106,135,89)">"allow-leading-underscore"</span>]<span style="color:rgb(204,120,50)">,<br></span><span style="color:rgb(204,120,50)"> </span><span style="color:rgb(152,118,170)">"whitespace"</span><span style="color:rgb(204,120,50)">: </span>[<span style="color:rgb(204,120,50);font-weight:bold">true</span><span style="color:rgb(204,120,50)">,<br></span><span style="color:rgb(204,120,50)"> </span><span style="color:rgb(106,135,89)">"check-decl"</span><span style="color:rgb(204,120,50)">,<br></span><span style="color:rgb(204,120,50)"> </span><span style="color:rgb(106,135,89)">"check-operator"</span><span style="color:rgb(204,120,50)">,<br></span><span style="color:rgb(204,120,50)"> </span><span style="color:rgb(106,135,89)">"check-type"<br></span><span style="color:rgb(106,135,89)"> </span>]<span style="color:rgb(204,120,50)">,<br></span><span style="color:rgb(204,120,50)"> </span><span style="color:rgb(152,118,170)">"license-header"</span><span style="color:rgb(204,120,50)">: </span>[ <span style="color:rgb(204,120,50);font-weight:bold">true</span><span style="color:rgb(204,120,50)">,<br></span><span style="color:rgb(204,120,50)"> </span><span style="color:rgb(106,135,89)">"/// Copyright 2014-2016 Red Hat, Inc. and/or its affiliates</span><span style="color:rgb(204,120,50)">\n</span><span style="color:rgb(106,135,89)">/// and other contributors as indicated by the @author tags.</span><span style="color:rgb(204,120,50)">\n</span><span style="color:rgb(106,135,89)">///</span><span style="color:rgb(204,120,50)">\n</span><span style="color:rgb(106,135,89)">/// Licensed under the Apache License, Version 2.0 (the </span><span style="color:rgb(204,120,50)">\"</span><span style="color:rgb(106,135,89)">License</span><span style="color:rgb(204,120,50)">\"</span><span style="color:rgb(106,135,89)">);</span><span style="color:rgb(204,120,50)">\n</span><span style="color:rgb(106,135,89)">/// you may not use this file except in compliance with the License.</span><span style="color:rgb(204,120,50)">\n</span><span style="color:rgb(106,135,89)">/// You may obtain a copy of the License at</span><span style="color:rgb(204,120,50)">\n</span><span style="color:rgb(106,135,89)">///</span><span style="color:rgb(204,120,50)">\n</span><span style="color:rgb(106,135,89)">/// <a href="http://www.apache.org/licenses/LICENSE-2.0" target="_blank">http://www.apache.org/licenses/LICENSE-2.0</a></span><span style="color:rgb(204,120,50)">\n</span><span style="color:rgb(106,135,89)">///</span><span style="color:rgb(204,120,50)">\n</span><span style="color:rgb(106,135,89)">/// Unless required by applicable law or agreed to in writing, software</span><span style="color:rgb(204,120,50)">\n</span><span style="color:rgb(106,135,89)">/// distributed under the License is distributed on an </span><span style="color:rgb(204,120,50)">\"</span><span style="color:rgb(106,135,89)">AS IS</span><span style="color:rgb(204,120,50)">\"</span><span style="color:rgb(106,135,89)"> BASIS,</span><span style="color:rgb(204,120,50)">\n</span><span style="color:rgb(106,135,89)">/// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.</span><span style="color:rgb(204,120,50)">\n</span><span style="color:rgb(106,135,89)">/// See the License for the specific language governing permissions and</span><span style="color:rgb(204,120,50)">\n</span><span style="color:rgb(106,135,89)">/// limitations under the License."<br></span><span style="color:rgb(106,135,89)"> </span>]<br> }<br>}<br></pre><div><br></div></div></div><br>_______________________________________________<br>
hawkular-dev mailing list<br>
<a href="mailto:hawkular-dev@lists.jboss.org">hawkular-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/hawkular-dev" rel="noreferrer" target="_blank">https://lists.jboss.org/mailman/listinfo/hawkular-dev</a><br>
<br></blockquote></div><br></div></div>