<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<font face="Calibri">Hawkular-922</font><br>
<br>
<div class="moz-cite-prefix">On 1/27/2016 4:31 AM, Peter Palaga
wrote:<br>
</div>
<blockquote cite="mid:56A88E59.50305@redhat.com" type="cite">Hi Jay,
nice to see that the task is being worked on, does it have a Jira
that I could watch to get notified about the progress? Thanks, --
P
<br>
<br>
On 2016-01-26 20:06, Jay Shaughnessy wrote:
<br>
<blockquote type="cite">
<br>
+1, I'd prefer a war and it can have rest endpoints and other
ejbs.
<br>
<br>
As for hawkular-glue, I don't know, i used that name because
that is
<br>
what we've been calling it but I'm fine changing it to something
like
<br>
hawkular-listeners or hawkular-bus-listeners or whatever. Need
one more
<br>
opinion to make a decision.
<br>
<br>
As it stands right now I'm not using the rest api but rather
just using
<br>
jndi to get the alerts service, taking advantage of co-located
deploy.
<br>
Is there a reason to not do it that way?
<br>
<br>
<br>
On 1/26/2016 11:32 AM, Thomas Segismont wrote:
<br>
<blockquote type="cite">How about a single WAR named
hawkular.war?
<br>
<br>
Le 26/01/2016 16:26, Jiri Kremser a écrit :
<br>
<blockquote type="cite">Hi,
<br>
<br>
wrt:
<br>
| I could also move
<br>
| CommandEventListener into this jar. At the moment,
locally, I have this
<br>
| living in
hawkular/modules/hawkular-api-parent/hawkular-glue and being
<br>
| bundled in the hawkular-rest.war.
<br>
<br>
Although, it's not a rest-api, I am ok with that. So I guess
the hawkular-rest-api module will depend on hawkular-glue.
<br>
Or we can create an uber (ear like) thing that will deploy
the hawkular-rest.war + hawkular-glue.war.. uber-glue? :)
<br>
<br>
btw. Do we want to use the term "hawkular-glue"? What about
something more official like
hawkular-{mdbs|bus-listeners|msg-something}
<br>
<br>
Jay, I assume the module will be listening on certain events
and call the rest api of particular components (or the
aggregated one in the module itself), right? We may also
need some kind of registry particular endpoints. Currently
it's done quite naively, it assumes everything to be running
on the same host:<a class="moz-txt-link-freetext" href="https://git.io/vzMLR">https://git.io/vzMLR</a>
<br>
<br>
jk
<br>
<br>
----- Original Message -----
<br>
| From: "Jay Shaughnessy"<a class="moz-txt-link-rfc2396E" href="mailto:jshaughn@redhat.com"><jshaughn@redhat.com></a>
<br>
| To: "Peter Palaga"<a class="moz-txt-link-rfc2396E" href="mailto:ppalaga@redhat.com"><ppalaga@redhat.com></a>, "Lucas
Ponce"<a class="moz-txt-link-rfc2396E" href="mailto:lponce@redhat.com"><lponce@redhat.com></a>, "Discussions around
Hawkular development"
<br>
|<a class="moz-txt-link-rfc2396E" href="mailto:hawkular-dev@lists.jboss.org"><hawkular-dev@lists.jboss.org></a>
<br>
| Sent: Tuesday, 26 January, 2016 3:02:11 PM
<br>
| Subject: Re: [Hawkular-dev] Eliminating Alerts ->
Command Gateway dependency
<br>
|
<br>
|
<br>
| Hi Peter,
<br>
|
<br>
| Right, the issue here is that CommandEventListener was
jammed into alerts as
<br>
| a convenience but really should not live there. The
command gw and inventory
<br>
| dependencies are both due to that listener and will go
away when it moves to
<br>
| Hawkular proper.
<br>
|
<br>
| As it turns out, at the moment I have just started
development on
<br>
| hawkular-glue-<version>.jar. I needed a place to
deploy yet another bus
<br>
| listener, which I am working on now. This new listener
will listen for
<br>
| inventory events and interact with alerting to add/remove
trigger
<br>
| definitions (moving trigger definition out of the UI
code). This JAR is
<br>
| purposed for any sort of hawkular "glue" code. I could
also move
<br>
| CommandEventListener into this jar. At the moment,
locally, I have this
<br>
| living in
hawkular/modules/hawkular-api-parent/hawkular-glue and being
<br>
| bundled in the hawkular-rest.war.
<br>
|
<br>
| I have just started and have not even tried to deploy it
yet, so it's up for
<br>
| discussion if that is the right place. If you guys have an
opinion let me
<br>
| know. But basically, I can move the listener out from
alerts once this is in
<br>
| place.
<br>
|
<br>
| Jay
<br>
|
<br>
|
<br>
| On 1/26/2016 8:12 AM, Peter Palaga wrote:
<br>
|
<br>
|
<br>
| Hi Jay, Lucas and *,
<br>
|
<br>
| I was looking into the possibility to move all message
classes [1] from
<br>
| Command Gateway to Commons. My primary motivation was to
eliminate the
<br>
| dependency of Alerts on Command Gateway. After thinking
about the impact I
<br>
| basically abandoned that idea.
<br>
|
<br>
| Initially, I thought, the move can be justified by the
fact that those
<br>
| classes define a public API that can be hosted separately
from the
<br>
| implementation. However, we have not done anything like
that for any other
<br>
| component. I think that such a split would make the
development of the
<br>
| command gateway (or any other component) unnecessarily
complicated.
<br>
|
<br>
| Moreover, there is another option [2] you (Alerts guys)
seem to foresee
<br>
| already:
<br>
|
<br>
| CommandEventListener can be moved to a new deployment in
Hawkular. Hawkular
<br>
| Alerts should not really have knowledge about
Hawkular-level decisions, like
<br>
| which possible Events to filter out or various special
handling that needs
<br>
| to be performed.
<br>
|
<br>
| Hence I vote for moving CommandEventListener to Hawkular.
Do you (Alerts
<br>
| guys) already have a Jira for that?
<br>
|
<br>
| Thanks,
<br>
|
<br>
| Peter
<br>
|
<br>
| [1] The message classes are generated from these schemas:
<br>
|<a class="moz-txt-link-freetext" href="https://github.com/hawkular/hawkular-command-gateway/tree/master/hawkular-command-gateway-api/src/main/resources/schema">https://github.com/hawkular/hawkular-command-gateway/tree/master/hawkular-command-gateway-api/src/main/resources/schema</a>
<br>
| plus some interfaces etc. in
<br>
|<a class="moz-txt-link-freetext" href="https://github.com/hawkular/hawkular-command-gateway/tree/master/hawkular-command-gateway-api/src/main/java/org/hawkular/cmdgw/api">https://github.com/hawkular/hawkular-command-gateway/tree/master/hawkular-command-gateway-api/src/main/java/org/hawkular/cmdgw/api</a>
<br>
|
<br>
| [2]
<br>
|<a class="moz-txt-link-freetext" href="https://github.com/hawkular/hawkular-alerts/blob/master/hawkular-alerts-bus/src/main/java/org/hawkular/alerts/bus/listener/CommandEventListener.java#L39-L41">https://github.com/hawkular/hawkular-alerts/blob/master/hawkular-alerts-bus/src/main/java/org/hawkular/alerts/bus/listener/CommandEventListener.java#L39-L41</a>
<br>
|
<br>
|
<br>
|
<br>
| _______________________________________________
<br>
| hawkular-dev mailing list
<br>
|<a class="moz-txt-link-abbreviated" href="mailto:hawkular-dev@lists.jboss.org">hawkular-dev@lists.jboss.org</a>
<br>
|<a class="moz-txt-link-freetext" href="https://lists.jboss.org/mailman/listinfo/hawkular-dev">https://lists.jboss.org/mailman/listinfo/hawkular-dev</a>
<br>
|
<br>
_______________________________________________
<br>
hawkular-dev mailing list
<br>
<a class="moz-txt-link-abbreviated" href="mailto:hawkular-dev@lists.jboss.org">hawkular-dev@lists.jboss.org</a>
<br>
<a class="moz-txt-link-freetext" href="https://lists.jboss.org/mailman/listinfo/hawkular-dev">https://lists.jboss.org/mailman/listinfo/hawkular-dev</a>
<br>
<br>
</blockquote>
_______________________________________________
<br>
hawkular-dev mailing list
<br>
<a class="moz-txt-link-abbreviated" href="mailto:hawkular-dev@lists.jboss.org">hawkular-dev@lists.jboss.org</a>
<br>
<a class="moz-txt-link-freetext" href="https://lists.jboss.org/mailman/listinfo/hawkular-dev">https://lists.jboss.org/mailman/listinfo/hawkular-dev</a>
<br>
<br>
</blockquote>
<br>
<br>
<br>
_______________________________________________
<br>
hawkular-dev mailing list
<br>
<a class="moz-txt-link-abbreviated" href="mailto:hawkular-dev@lists.jboss.org">hawkular-dev@lists.jboss.org</a>
<br>
<a class="moz-txt-link-freetext" href="https://lists.jboss.org/mailman/listinfo/hawkular-dev">https://lists.jboss.org/mailman/listinfo/hawkular-dev</a>
<br>
<br>
</blockquote>
<br>
<br>
</blockquote>
<br>
</body>
</html>