<div dir="ltr"><div>Hello,<br><br></div>Thanks for the clarifications and the PR for Metrics. I looked at the code and module they are really minimal, nice work! <br><br>In the long run Metrics would benefit from adopting it however at this time the project is not ready to get additional external dependencies. I closed the PR for now, we will reopen the PR once we are ready to adopt the filter.<br><div class="gmail_extra"><br><br clear="all"><div><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr">Thank you,<br>Stefan Negrea<br><br>Software Engineer<br></div></div></div>
<br><br><div class="gmail_quote">On Fri, Jun 10, 2016 at 1:36 AM, Juraci Paixão Kröhling <span dir="ltr"><<a href="mailto:jpkroehling@redhat.com" target="_blank">jpkroehling@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On 10.06.2016 05:07, Stefan Negrea wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Can you please give more details about the proposed changes to use the<br>
Commons filter in other projects? What dependencies need to be<br>
introduced? Where is the filter located (module, code)?<br>
</blockquote>
<br></span>
The tenant filter is a JAX-RS filter and the dependency is defined as org.hawkular.commons:hawkular-tenant-jaxrs-filter [1]. It's a "pure" Java EE module, depending on nothing else.<br>
<br>
All you need to do is to have your WAR module depending on this filter module and the filter will be applied automatically to all JAX-RS endpoints in your application. If you have an endpoint or method that you don't want to protect, use the `@TenantRequired(false)` annotation.<br>
<br>
1 - <a href="https://git.io/vosci" rel="noreferrer" target="_blank">https://git.io/vosci</a><span class=""><br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Also, what are the implications of not using the filter from Commons?<br>
</blockquote>
<br></span>
If you don't use the filter, you risk having a different behavior when comparing to other modules. For instance, you might return JSON when no JSON is expected (or vice-versa), or you might have a slightly different semantic than the current agreement, ...<br>
<br>
- Juca.<br>
</blockquote></div><br></div></div>