<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Jun 15, 2016 at 6:28 PM, Heiko W.Rupp <span dir="ltr"><<a href="mailto:hrupp@redhat.com" target="_blank">hrupp@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hey,<br>
<br>
I want to remind everyone (including myself :-) that one should not merge<br>
ones own pull-requests (and also abstain from directly committing to master).<br>
<br>
There are many reasons why this is good practice<br>
<br>
- peer review finds issues<br>
- peer review allows discussions on the concrete implementation of<br>
a bugfix/feature request<br></blockquote><div><br></div><div>If you are the one who open a PR, please be reactive on the comments/questions that may be asked so that you don't become the bottleneck yourself. (and if you are busy, please send a quick note on when one can expect an answer, that's less stressful than no answer)</div><div><br></div><div>If there is no reviewer please chase one, raise to #hawkular/hawkular-dev/Heiko/Alissa if you found noone.</div><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
- other findings can be addressed in the same pull-request and do<br>
not need a subsequent one.<br>
- It gives oneself some time to reflect what was done.<br>
- It gives time to also add this one little file that was not git-add'ed<br>
<br>
I totally understand that we are in some areas rather thin on developers<br>
(Juca's work on hawkular-services and accounts come to mind) and that<br>
there are always situations where a direct commit or self-merged PR is<br>
needed. But it should not be the default.<br>
<br>
I do not want us to get to a structure where only a handful of managers<br>
have push rights to force this above mentioned peer review.<br></blockquote><div><br></div><div>Managers with push rights !??! that would be horrible !</div><div><br></div><div>THomas</div><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Thanks<br>
Heiko<br>
_______________________________________________<br>
hawkular-dev mailing list<br>
<a href="mailto:hawkular-dev@lists.jboss.org">hawkular-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/hawkular-dev" rel="noreferrer" target="_blank">https://lists.jboss.org/mailman/listinfo/hawkular-dev</a><br>
<br>
<br>
</blockquote></div><br></div></div>