<div dir="ltr">Ok, I will create these JIRA tickets. Thank you all.<div><br></div><div>Just one thing about the versioning question raised by Lucas: if we go for the first option (and it seems that's where we're going), there will be no breaking change. Of course that doesn't mean the subject shouldn't be discussed :)</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Sep 14, 2016 at 5:42 PM, Stefan Negrea <span dir="ltr"><<a href="mailto:snegrea@redhat.com" target="_blank">snegrea@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr"></div></div></div></div>
<br><div class="gmail_quote"><span class="">On Wed, Sep 14, 2016 at 3:42 AM, Joel Takvorian <span dir="ltr"><<a href="mailto:jtakvori@redhat.com" target="_blank">jtakvori@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div>1st Option: keep the API in the current form and bring all endpoints up to the same level of functionality, that is:</div><div> * Create "@get */raw" that can take ids or tags</div><div> * Make "@post */raw/query" understand tags</div><div> * Create "@post */stats/query" that can take ids or tags</div></div></blockquote><div><br></div></span><div>Thanks for the detailed explanation.<br><br>Option 1 might be the only way to go. Adding end-points for tags would just increase the API without any benefits. Since the output is identical, tags or ids is just a query parameter. Also, we need to think about backwards compatibility and expectations that we already set. We already have APIs that support both, so we need to continue that path. <br><br></div><div>For making these changes, I would break your proposal into several PRs and Jira tickets. A single massive PR will make the review process more difficult.<br><br></div><div>Thank you,<br></div><div>Stefan <br></div></div><br></div></div>
<br>______________________________<wbr>_________________<br>
hawkular-dev mailing list<br>
<a href="mailto:hawkular-dev@lists.jboss.org">hawkular-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/hawkular-dev" rel="noreferrer" target="_blank">https://lists.jboss.org/<wbr>mailman/listinfo/hawkular-dev</a><br>
<br></blockquote></div><br></div>