<div dir="ltr">Thanks for the update.<div><br></div><div>Cheers.</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Sep 23, 2016 at 11:07 AM, Michael Burman <span dir="ltr"><<a href="mailto:miburman@redhat.com" target="_blank">miburman@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi,<br>
<br>
I don't think the model should convert, but the MetricsServiceImpl getTTL is not doing to conversion which it probably should (best place to add it). And while we have stuff that tests this, it's not actually testing they end up correctly for single datapoint in the Cassandra, only the DEFAULT_TTL is tested for that..<br>
<br>
<a href="https://github.com/hawkular/hawkular-metrics/pull/609" rel="noreferrer" target="_blank">https://github.com/hawkular/<wbr>hawkular-metrics/pull/609</a><br>
<br>
- Micke<br>
<span class=""><br>
----- Original Message -----<br>
From: "Gareth Healy" <<a href="mailto:garethahealy@gmail.com">garethahealy@gmail.com</a>><br>
To: "Discussions around Hawkular development" <<a href="mailto:hawkular-dev@lists.jboss.org">hawkular-dev@lists.jboss.org</a>><br>
Sent: Thursday, September 22, 2016 7:54:56 PM<br>
Subject: [Hawkular-dev] Understanding data retention<br>
<br>
A metric supports data retention (TTL); the swagger docs say this is number of days.<br>
<br>
<br>
</span> * <a href="https://github.com/hawkular/hawkular-metrics/blob/5eb13c6dbddafdcc0fcd5eb7fc3dacd9858e18c8/core/metrics-model/src/main/java/org/hawkular/metrics/model/Metric.java#L167" rel="noreferrer" target="_blank">https://github.com/hawkular/<wbr>hawkular-metrics/blob/<wbr>5eb13c6dbddafdcc0fcd5eb7fc3dac<wbr>d9858e18c8/core/metrics-model/<wbr>src/main/java/org/hawkular/<wbr>metrics/model/Metric.java#L167</a><br>
<br>
<br>
*<br>
<span class=""><a href="http://www.hawkular.org/docs/rest/rest-metrics.html#Metric" rel="noreferrer" target="_blank">http://www.hawkular.org/docs/<wbr>rest/rest-metrics.html#Metric</a><br>
There is also a default TTL which is in days but converted internally into seconds:<br>
<br>
<br>
</span> * <a href="https://github.com/hawkular/hawkular-metrics/blob/39389e4bf5a988ef01cbad83b488cadd47c93066/core/metrics-core-service/src/main/java/org/hawkular/metrics/core/service/MetricsServiceImpl.java#L180" rel="noreferrer" target="_blank">https://github.com/hawkular/<wbr>hawkular-metrics/blob/<wbr>39389e4bf5a988ef01cbad83b488ca<wbr>dd47c93066/core/metrics-core-<wbr>service/src/main/java/org/<wbr>hawkular/metrics/core/service/<wbr>MetricsServiceImpl.java#L180</a><br>
<span class="">Looking at when metrics are created, i can't see any conversion from days to seconds for metrics; so any data i create with a Metric DataRetention of 30 "days" gets removed straight away.<br>
<br>
So my question is:<br>
<br>
<br>
</span> * Are the swagger docs wrong?<br>
<br>
or<br>
<br>
<br>
* Should the model convert to seconds?<br>
<span class=""><br>
Or...have i missed something... ?<br>
<br>
Cheers.<br>
<br>
<br>
<br>
</span>______________________________<wbr>_________________<br>
hawkular-dev mailing list<br>
<a href="mailto:hawkular-dev@lists.jboss.org">hawkular-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/hawkular-dev" rel="noreferrer" target="_blank">https://lists.jboss.org/<wbr>mailman/listinfo/hawkular-dev</a><br>
______________________________<wbr>_________________<br>
hawkular-dev mailing list<br>
<a href="mailto:hawkular-dev@lists.jboss.org">hawkular-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/hawkular-dev" rel="noreferrer" target="_blank">https://lists.jboss.org/<wbr>mailman/listinfo/hawkular-dev</a><br>
</blockquote></div><br></div>