<div dir="ltr">It looks good, too. As long as it's using the java api, it should be fine.</div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Nov 22, 2016 at 2:15 PM, Jay Shaughnessy <span dir="ltr"><<a href="mailto:jshaughn@redhat.com" target="_blank">jshaughn@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div bgcolor="#FFFFFF" text="#000000">
Hi Joel,<br>
<br>
<font face="Calibri">There are a couple of listeners in the services
code that use inventory. I took a look and I think they are OK
but you may want to make sure this like is OK:</font><br>
<br>
<a class="m_2573036863967730944moz-txt-link-freetext" href="https://github.com/hawkular/hawkular-services/blob/master/hawkular-rest/hawkular-listener/src/main/java/org/hawkular/listener/cache/BackfillCacheManager.java#L397" target="_blank">https://github.com/hawkular/<wbr>hawkular-services/blob/master/<wbr>hawkular-rest/hawkular-<wbr>listener/src/main/java/org/<wbr>hawkular/listener/cache/<wbr>BackfillCacheManager.java#L397</a><div><div class="h5"><br>
<br>
<div class="m_2573036863967730944moz-cite-prefix">On 11/22/2016 4:26 AM, Joel Takvorian
wrote:<br>
</div>
<blockquote type="cite">
<div dir="ltr">Gracias Lucas
<div><br>
</div>
<div>I'm going to try testing manageiq's middleware spec... will
probably ask for some help :)</div>
</div>
<div class="gmail_extra"><br>
<div class="gmail_quote">On Tue, Nov 22, 2016 at 9:50 AM, Lucas
Ponce <span dir="ltr"><<a href="mailto:lponce@redhat.com" target="_blank">lponce@redhat.com</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Also, I
mean a *live* test from middleware_*.spec to the new
changes.<br>
<br>
ManageIQ uses recorded cassettes with old versions of
Hawkular Services.<br>
<span><br>
Lucas<br>
<br>
----- Mensaje original -----<br>
</span>> De: "Lucas Ponce" <<a href="mailto:lponce@redhat.com" target="_blank">lponce@redhat.com</a>><br>
<span>> Para: "Discussions around Hawkular
development" <<a href="mailto:hawkular-dev@lists.jboss.org" target="_blank">hawkular-dev@lists.jboss.org</a>><br>
</span>> Enviados: Martes, 22 de Noviembre 2016 9:49:21<br>
> Asunto: Re: [Hawkular-dev] Future change in Inventory
REST API - impacted clients?<br>
<div class="m_2573036863967730944HOEnZb">
<div class="m_2573036863967730944h5">><br>
> I think that ruby test suite should be enough.<br>
><br>
> But just in case, before to submit the change it
could be good if ManageIQ<br>
> tests are passing.<br>
><br>
> Some ManageIQ code use the wrapped json code
brought by the ruby client.<br>
><br>
> I guess that if the middleware_*.spec are passing
we are fine.<br>
><br>
> Lucas<br>
><br>
> ----- Mensaje original -----<br>
> > De: "Joel Takvorian" <<a href="mailto:jtakvori@redhat.com" target="_blank">jtakvori@redhat.com</a>><br>
> > Para: "Discussions around Hawkular
development"<br>
> > <<a href="mailto:hawkular-dev@lists.jboss.org" target="_blank">hawkular-dev@lists.jboss.org</a>><br>
> > Enviados: Martes, 22 de Noviembre 2016 9:47:22<br>
> > Asunto: [Hawkular-dev] Future change in
Inventory REST API - impacted<br>
> > clients?<br>
> ><br>
> > Hi,<br>
> ><br>
> > There is a small upcoming change in the
Inventory REST API which consists<br>
> > in<br>
> > removing a deprecated field, as explained in
this JIRA:<br>
> > <a href="https://issues.jboss.org/browse/HWKINVENT-200" rel="noreferrer" target="_blank">https://issues.jboss.org/brows<wbr>e/HWKINVENT-200</a><br>
> ><br>
> > Basically, "type" has been replaced with
"metricDataType" a while ago and<br>
> > made deprecated, now it's going to be removed.
Probably not for the next<br>
> > release, but for the one after. Meanwhile I'd
like to check any existing<br>
> > usage. What are the potential usages?<br>
> ><br>
> > - Ruby client: I've already made changes to it<br>
> > - Java client: it uses the inventory API code,
so it should not require any<br>
> > change<br>
> > - Go client: does not use inventory (?)<br>
> > - Python client: does not use inventory (?)<br>
> > - I'm now having a look at WF & openshift
agents<br>
> ><br>
> > Do you see anything else?<br>
> ><br>
> > Joel<br>
> ><br>
> > ______________________________<wbr>_________________<br>
> > hawkular-dev mailing list<br>
> > <a href="mailto:hawkular-dev@lists.jboss.org" target="_blank">hawkular-dev@lists.jboss.org</a><br>
> > <a href="https://lists.jboss.org/mailman/listinfo/hawkular-dev" rel="noreferrer" target="_blank">https://lists.jboss.org/mailma<wbr>n/listinfo/hawkular-dev</a><br>
> ><br>
> ______________________________<wbr>_________________<br>
> hawkular-dev mailing list<br>
> <a href="mailto:hawkular-dev@lists.jboss.org" target="_blank">hawkular-dev@lists.jboss.org</a><br>
> <a href="https://lists.jboss.org/mailman/listinfo/hawkular-dev" rel="noreferrer" target="_blank">https://lists.jboss.org/mailma<wbr>n/listinfo/hawkular-dev</a><br>
><br>
______________________________<wbr>_________________<br>
hawkular-dev mailing list<br>
<a href="mailto:hawkular-dev@lists.jboss.org" target="_blank">hawkular-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/hawkular-dev" rel="noreferrer" target="_blank">https://lists.jboss.org/mailma<wbr>n/listinfo/hawkular-dev</a><br>
</div>
</div>
</blockquote>
</div>
<br>
</div>
<br>
<fieldset class="m_2573036863967730944mimeAttachmentHeader"></fieldset>
<br>
<pre>______________________________<wbr>_________________
hawkular-dev mailing list
<a class="m_2573036863967730944moz-txt-link-abbreviated" href="mailto:hawkular-dev@lists.jboss.org" target="_blank">hawkular-dev@lists.jboss.org</a>
<a class="m_2573036863967730944moz-txt-link-freetext" href="https://lists.jboss.org/mailman/listinfo/hawkular-dev" target="_blank">https://lists.jboss.org/<wbr>mailman/listinfo/hawkular-dev</a>
</pre>
</blockquote>
<br>
</div></div></div>
<br>______________________________<wbr>_________________<br>
hawkular-dev mailing list<br>
<a href="mailto:hawkular-dev@lists.jboss.org">hawkular-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/hawkular-dev" rel="noreferrer" target="_blank">https://lists.jboss.org/<wbr>mailman/listinfo/hawkular-dev</a><br>
<br></blockquote></div><br></div>