<div dir="ltr">Hi,<div><br></div><div>Gareth, I see your PR is currently only for counters only, for the feature to be complete it should also be implemented on gauges, availability and strings.</div><div>And also, you will have the same issue if you try to use the "stats" endpoints (in Grafana it is used for single stats panels), so here also it should be implemented...</div><div><br></div><div>Which leads me to questioning: basically this feature is to "split" a time series based on data points tags. Is it really something we want to implement on the server side? </div><div>Maybe the problem is that this series is built as an aggregation of several different "things", and should be split into several series at insertion?</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Jan 2, 2017 at 12:15 AM, Gareth Healy <span dir="ltr"><<a href="mailto:garethahealy@gmail.com" target="_blank">garethahealy@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Have raised:<div><ul><li><a href="https://issues.jboss.org/browse/HWKMETRICS-563" target="_blank">https://issues.jboss.org/<wbr>browse/HWKMETRICS-563</a><br></li></ul><div>Will work on the grafana datasource support in next few days.</div></div><div><br></div><div>Cheers.</div></div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Dec 30, 2016 at 6:29 PM, John Mazzitelli <span dir="ltr"><<a href="mailto:mazz@redhat.com" target="_blank">mazz@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Thanks.<br>
<br>
You should submit a feature request in the H-Metrics JIRA and link that JIRA to a PR for the H-Metrics team to peer review:<br>
<br>
<a href="https://issues.jboss.org/projects/HWKMETRICS" rel="noreferrer" target="_blank">https://issues.jboss.org/proje<wbr>cts/HWKMETRICS</a><br>
<span><br>
<br>
----- Original Message -----<br>
> I did some hacking (day 1 of Rx, so probably not the best "solution"). But<br>
> works...<br>
><br>
</span>> -<br>
> <a href="https://github.com/garethahealy/hawkular-metrics/commit/75c616f9be71a0b85ce5dee310c4dff828bb8f38" rel="noreferrer" target="_blank">https://github.com/garethaheal<wbr>y/hawkular-metrics/commit/75c6<wbr>16f9be71a0b85ce5dee310c4dff828<wbr>bb8f38</a><br>
><br>
><br>
> Sample output:<br>
><br>
> - <a href="https://gist.github.com/garethahealy/00a90bbee2556b6f0a338ece87096c89" rel="noreferrer" target="_blank">https://gist.github.com/gareth<wbr>ahealy/00a90bbee2556b6f0a338ec<wbr>e87096c89</a><br>
<span>><br>
><br>
> And some test cURL commands:<br>
><br>
</span>> - <a href="https://gist.github.com/garethahealy/0f46aad5d2da41b82aad5af317fad788" rel="noreferrer" target="_blank">https://gist.github.com/gareth<wbr>ahealy/0f46aad5d2da41b82aad5af<wbr>317fad788</a><br>
<div class="m_-3853831257060878535HOEnZb"><div class="m_-3853831257060878535h5">><br>
><br>
> Cheers.<br>
><br>
> On Thu, Dec 29, 2016 at 4:33 PM, John Mazzitelli <<a href="mailto:mazz@redhat.com" target="_blank">mazz@redhat.com</a>> wrote:<br>
><br>
> > This would be a feature request on Hawkular-Metrics (if they don't do<br>
> > something like this already - I do not know. I will defer to the H-Metrics<br>
> > folks to talk about how they do querying off of tags).<br>
> ><br>
> > ----- Original Message -----<br>
> > > The OpenShift Agent when monitoring a prometheus endpoint creates a<br>
> > single<br>
> > > metric with tagged datapoints, i.e.:<br>
> > ><br>
> > ><br>
> > ><br>
> > ><br>
> > > <a href="https://github.com/coreos/etcd/blob/master/Documentation/v2/metrics.md#" rel="noreferrer" target="_blank">https://github.com/coreos/etcd<wbr>/blob/master/Documentation/v2/<wbr>metrics.md#</a><br>
> > http-requests<br>
> > ><br>
> > ><br>
> > ><br>
> > ><br>
> > > I1228 21:02:01.820530 1 metrics_storage.go:155] TRACE: Stored [3]<br>
> > [counter]<br>
> > > datapoints for metric named<br>
> > > [pod/fa32a887-cd08-11e6-ab2e-5<wbr>25400c583ad/custom/etcd_http_r<wbr>eceived_total]:<br>
> > [<br>
> > > {2016-12-28 21:02:01.638767339 +0000 UTC 622 map[method:DELETE]}<br>
> > > {2016-12-28 21:02:01.638767339 +0000 UTC 414756 map[method:GET]}<br>
> > > {2016-12-28 21:02:01.638767339 +0000 UTC 33647 map[method:PUT]}<br>
> > > ]<br>
> > ><br>
> > > But when trying to view this via the grafana datasource, only 1 metric<br>
> > and<br>
> > > the aggregated counts are shown. What i'd like to do is something like<br>
> > the<br>
> > > below:<br>
> > ><br>
> > ><br>
> > ><br>
> > > {<br>
> > > "start": 1482999755690,<br>
> > > "end": 1483000020093,<br>
> > > "order": "ASC",<br>
> > > "tags": "pod_namespace:etcd-testing",<br>
> > > "groupDatapointsByTagKey": "method"<br>
> > > }<br>
> > ><br>
> > > Search via tags or name (as-is) and group the datapoints by a tag key,<br>
> > which<br>
> > > would give you 3 lines, instead of 1.<br>
> > ><br>
> > > Does that sound possible?<br>
> > ><br>
> > > Cheers.<br>
> > ><br>
> > > ______________________________<wbr>_________________<br>
> > > hawkular-dev mailing list<br>
> > > <a href="mailto:hawkular-dev@lists.jboss.org" target="_blank">hawkular-dev@lists.jboss.org</a><br>
> > > <a href="https://lists.jboss.org/mailman/listinfo/hawkular-dev" rel="noreferrer" target="_blank">https://lists.jboss.org/mailma<wbr>n/listinfo/hawkular-dev</a><br>
> > ><br>
> > ______________________________<wbr>_________________<br>
> > hawkular-dev mailing list<br>
> > <a href="mailto:hawkular-dev@lists.jboss.org" target="_blank">hawkular-dev@lists.jboss.org</a><br>
> > <a href="https://lists.jboss.org/mailman/listinfo/hawkular-dev" rel="noreferrer" target="_blank">https://lists.jboss.org/mailma<wbr>n/listinfo/hawkular-dev</a><br>
> ><br>
><br>
</div></div></blockquote></div><br></div>
</div></div><br>______________________________<wbr>_________________<br>
hawkular-dev mailing list<br>
<a href="mailto:hawkular-dev@lists.jboss.org">hawkular-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/hawkular-dev" rel="noreferrer" target="_blank">https://lists.jboss.org/<wbr>mailman/listinfo/hawkular-dev</a><br>
<br></blockquote></div><br></div>