<div dir="ltr">Consistency helps :)</div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Mar 20, 2017 at 12:16 PM, John Mazzitelli <span dir="ltr"><<a href="mailto:mazz@redhat.com" target="_blank">mazz@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">It was pointed out to me (which I forgot) that WildFly itself supports the syntax ${env.X} to denote environment variables.<br>
<br>
Now, this Java Agent isn't based on WildFly and these ${x} tokens appear in the yaml file and not the standalone.xml so we technically do no have to be consistent with WildFly syntax, but I wonder if I should switch this anyway to use the ${env.X} syntax just to make it consistent for people that are familiar with WildFly syntax.<br>
<br>
Let me know - this would be a trivial change but I would like to make another release quickly if this change is to be made.<br>
<br>
--John Mazz<br>
<div class="HOEnZb"><div class="h5"><br>
----- Original Message -----<br>
> Thanks for the update ! And for releasing-early/releasing-<wbr>often<br>
><br>
> On Sat, Mar 18, 2017 at 3:22 PM, John Mazzitelli <<a href="mailto:mazz@redhat.com">mazz@redhat.com</a>> wrote:<br>
><br>
> > Just released Hawkular Java Agent 0.29.1.Final that contains a new feature.<br>
> ><br>
> > To support deploying Java Agent within containers (though this feature<br>
> > isn't restricted to that use-case), you can configure many settings in the<br>
> > Java Agent YAML config with ${x} expressions (similar to how HWFA can be<br>
> > configured in standalone.xml).<br>
> ><br>
> > It supports getting values from system properties, environment variables,<br>
> > with default values optionally defined. The following expressions are<br>
> > supported - hopefully this is self-explanatory:<br>
> ><br>
> > ${some.system.property}<br>
> ><br>
> > ${some.system.property:a-<wbr>default-value}<br>
> ><br>
> > ${ENV~SOME_ENV_VAR}<br>
> ><br>
> > ${ENV~SOME_ENV_VAR:a-default-<wbr>value}<br>
> ><br>
> > Not all properties support expressions (most don't need them) but<br>
> > properties that define things like hosts, ports, urls, passwords,<br>
> > filepaths, do support expressions.<br>
> ><br>
> > If I missed any, or if you'd like a property to support expressions that<br>
> > does not currently, write a HWKAGENT JIRA: <a href="https://issues.jboss.org/" rel="noreferrer" target="_blank">https://issues.jboss.org/</a><br>
> > projects/HWKAGENT<br>
> ><br>
> > ______________________________<wbr>_________________<br>
> > hawkular-dev mailing list<br>
> > <a href="mailto:hawkular-dev@lists.jboss.org">hawkular-dev@lists.jboss.org</a><br>
> > <a href="https://lists.jboss.org/mailman/listinfo/hawkular-dev" rel="noreferrer" target="_blank">https://lists.jboss.org/<wbr>mailman/listinfo/hawkular-dev</a><br>
> ><br>
> ><br>
> ><br>
><br>
______________________________<wbr>_________________<br>
hawkular-dev mailing list<br>
<a href="mailto:hawkular-dev@lists.jboss.org">hawkular-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/hawkular-dev" rel="noreferrer" target="_blank">https://lists.jboss.org/<wbr>mailman/listinfo/hawkular-dev</a><br>
<br>
<br>
</div></div></blockquote></div><br></div>