<div dir="ltr">I think the com.sun.* classes will work with OpenJDK (at least the JMX exporter works fine when using OpenJDK)<div><br></div><div>As to whether it will work with other JVMs is another question. Is this part of the code we are forking anyways? I assume since we need to make other modifications here to support https, we might as well update this section as well.</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Oct 27, 2017 at 4:26 AM, Heiko Rupp <span dir="ltr"><<a href="mailto:hrupp@redhat.com" target="_blank">hrupp@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">That package is indeed problematic. And may be even more so in the future on JDK9+ with the module system, where modules like this may be totally encapsulated away.</div><div class="gmail_extra"><div><div class="h5"><br><div class="gmail_quote">On Fri, Oct 27, 2017 at 5:07 AM, John Mazzitelli <span dir="ltr"><<a href="mailto:mazz@redhat.com" target="_blank">mazz@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Take a look at Prometheus's HTTPServer class:<br>
<br>
<a href="https://github.com/prometheus/client_java/blob/master/simpleclient_httpserver/src/main/java/io/prometheus/client/exporter/HTTPServer.java#L22-L24" rel="noreferrer" target="_blank">https://github.com/prometheus/<wbr>client_java/blob/master/simple<wbr>client_httpserver/src/main/<wbr>java/io/prometheus/client/<wbr>exporter/HTTPServer.java#L22-<wbr>L24</a><br>
<br>
This Prometheus HTTPServer class is what jmx exporter uses for its metrics endpoint - see:<br>
<br>
<a href="https://github.com/prometheus/jmx_exporter/blob/master/jmx_prometheus_javaagent/src/main/java/io/prometheus/jmx/JavaAgent.java#L8" rel="noreferrer" target="_blank">https://github.com/prometheus/<wbr>jmx_exporter/blob/master/jmx_p<wbr>rometheus_javaagent/src/main/j<wbr>ava/io/prometheus/jmx/JavaAgen<wbr>t.java#L8</a><br>
<a href="https://github.com/prometheus/jmx_exporter/blob/master/jmx_prometheus_httpserver/src/main/java/io/prometheus/jmx/WebServer.java#L7" rel="noreferrer" target="_blank">https://github.com/prometheus/<wbr>jmx_exporter/blob/master/jmx_p<wbr>rometheus_httpserver/src/main/<wbr>java/io/prometheus/jmx/WebServ<wbr>er.java#L7</a><br>
<br>
Since it uses com.sun.net.httpserver classes under the covers, I'll assume this rules out support for, say, IBM's JVM (does IBM's JRE implement these?). I think this is available on OpenJDK but didn't check to make 100% sure.<br>
______________________________<wbr>_________________<br>
hawkular-dev mailing list<br>
<a href="mailto:hawkular-dev@lists.jboss.org" target="_blank">hawkular-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/hawkular-dev" rel="noreferrer" target="_blank">https://lists.jboss.org/mailma<wbr>n/listinfo/hawkular-dev</a><br>
</blockquote></div><br><br clear="all"><div><br></div></div></div><span class="HOEnZb"><font color="#888888">-- <br><div class="m_-4532028287538982075gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div>Reg. Adresse: Red Hat GmbH, Technopark II, Haus C,<br></div><div>Werner-von-Siemens-Ring 14, D-85630 Grasbrunn</div><div>Handelsregister: Amtsgericht München HRB 153243</div><div>Geschäftsführer: Charles Cachera, Michael Cunningham, Michael O'Neill, Eric Shander</div></div></div></div></div>
</font></span></div>
<br>______________________________<wbr>_________________<br>
hawkular-dev mailing list<br>
<a href="mailto:hawkular-dev@lists.jboss.org">hawkular-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/hawkular-dev" rel="noreferrer" target="_blank">https://lists.jboss.org/<wbr>mailman/listinfo/hawkular-dev</a><br>
<br></blockquote></div><br></div>