<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Oct 27, 2017 at 5:56 PM, John Mazzitelli <span dir="ltr"><<a href="mailto:mazz@redhat.com" target="_blank">mazz@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">> I think the com.sun.* classes will work with OpenJDK (at least the JMX<br>
> exporter works fine when using OpenJDK)<br>
><br>
> As to whether it will work with other JVMs is another question. Is this<br>
> part of the code we are forking anyways? I assume since we need to make<br>
> other modifications here to support https, we might as well update this<br>
> section as well.<br>
<br>
<br>
</span>We are using it in our forked class here:<br>
<br>
<a href="https://github.com/jmazzitelli/hawkular-agent/blob/remove-h-metrics/hawkular-agent-core/src/main/java/org/hawkular/agent/monitor/prometheus/WebServer.java#L47" rel="noreferrer" target="_blank">https://github.com/<wbr>jmazzitelli/hawkular-agent/<wbr>blob/remove-h-metrics/<wbr>hawkular-agent-core/src/main/<wbr>java/org/hawkular/agent/<wbr>monitor/prometheus/WebServer.<wbr>java#L47</a><br>
<br>
Unfortunately, the way they coded up this class, it can't be subclasses and overridden. We'd have to write our own and integrate the jmx exporter stuff ourselves. Means we'll be writing a bit more code, but, yeah, once we start implementing the https stuff, we can do it all at once.<br>
<div class="HOEnZb"><div class="h5"><br>
<br></div></div></blockquote><div><br>can some code be contributed to fix that class in the java client itself? <br><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="HOEnZb"><div class="h5">
<br>
><br>
> On Fri, Oct 27, 2017 at 4:26 AM, Heiko Rupp <<a href="mailto:hrupp@redhat.com">hrupp@redhat.com</a>> wrote:<br>
><br>
> > That package is indeed problematic. And may be even more so in the future<br>
> > on JDK9+ with the module system, where modules like this may be totally<br>
> > encapsulated away.<br>
> ><br>
> > On Fri, Oct 27, 2017 at 5:07 AM, John Mazzitelli <<a href="mailto:mazz@redhat.com">mazz@redhat.com</a>> wrote:<br>
> ><br>
> >> Take a look at Prometheus's HTTPServer class:<br>
> >><br>
> >> <a href="https://github.com/prometheus/client_java/blob/master/simple" rel="noreferrer" target="_blank">https://github.com/prometheus/<wbr>client_java/blob/master/simple</a><br>
> >> client_httpserver/src/main/<wbr>java/io/prometheus/client/<br>
> >> exporter/HTTPServer.java#L22-<wbr>L24<br>
> >><br>
> >> This Prometheus HTTPServer class is what jmx exporter uses for its<br>
> >> metrics endpoint - see:<br>
> >><br>
> >> <a href="https://github.com/prometheus/jmx_exporter/blob/master/jmx_p" rel="noreferrer" target="_blank">https://github.com/prometheus/<wbr>jmx_exporter/blob/master/jmx_p</a><br>
> >> rometheus_javaagent/src/main/<wbr>java/io/prometheus/jmx/<wbr>JavaAgent.java#L8<br>
> >> <a href="https://github.com/prometheus/jmx_exporter/blob/master/jmx_p" rel="noreferrer" target="_blank">https://github.com/prometheus/<wbr>jmx_exporter/blob/master/jmx_p</a><br>
> >> rometheus_httpserver/src/main/<wbr>java/io/prometheus/jmx/<wbr>WebServer.java#L7<br>
> >><br>
> >> Since it uses com.sun.net.httpserver classes under the covers, I'll<br>
> >> assume this rules out support for, say, IBM's JVM (does IBM's JRE<br>
> >> implement<br>
> >> these?). I think this is available on OpenJDK but didn't check to make<br>
> >> 100%<br>
> >> sure.<br>
> >> ______________________________<wbr>_________________<br>
> >> hawkular-dev mailing list<br>
> >> <a href="mailto:hawkular-dev@lists.jboss.org">hawkular-dev@lists.jboss.org</a><br>
> >> <a href="https://lists.jboss.org/mailman/listinfo/hawkular-dev" rel="noreferrer" target="_blank">https://lists.jboss.org/<wbr>mailman/listinfo/hawkular-dev</a><br>
> >><br>
> ><br>
> ><br>
> ><br>
> > --<br>
> > Reg. Adresse: Red Hat GmbH, Technopark II, Haus C,<br>
> > Werner-von-Siemens-Ring 14, D-85630 Grasbrunn<br>
> > Handelsregister: Amtsgericht München HRB 153243<br>
> > Geschäftsführer: Charles Cachera, Michael Cunningham, Michael O'Neill,<br>
> > Eric Shander<br>
> ><br>
> > ______________________________<wbr>_________________<br>
> > hawkular-dev mailing list<br>
> > <a href="mailto:hawkular-dev@lists.jboss.org">hawkular-dev@lists.jboss.org</a><br>
> > <a href="https://lists.jboss.org/mailman/listinfo/hawkular-dev" rel="noreferrer" target="_blank">https://lists.jboss.org/<wbr>mailman/listinfo/hawkular-dev</a><br>
> ><br>
> ><br>
><br>
<br>
______________________________<wbr>_________________<br>
hawkular-dev mailing list<br>
<a href="mailto:hawkular-dev@lists.jboss.org">hawkular-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/hawkular-dev" rel="noreferrer" target="_blank">https://lists.jboss.org/<wbr>mailman/listinfo/hawkular-dev</a><br>
</div></div></blockquote></div><br></div></div>