<div dir="ltr"><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Nov 23, 2017 at 7:35 PM, Alissa Bonas <span dir="ltr"><<a href="mailto:abonas@redhat.com" target="_blank">abonas@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div><div>Thomas, I believe Lucas means moving those files between miq repos, so the release process for them remains the same.<br></div>Lucas, correct me if I'm wrong, but you are talking about those files<br><a href="https://github.com/ManageIQ/manageiq/tree/master/product/live_metrics" target="_blank">https://github.com/ManageIQ/ma<wbr>nageiq/tree/master/product/liv<wbr>e_metrics</a><br><br></div>I don't think there would be any objections (the proposal makes sense to me ), the only thing I am wondering/concerned about whether that will work well. Because our repo is considered and packaged as a gem (while the main repo is a rails app), so I guess it would be mainly a question of *will it work or not*<br><br></div></blockquote><div><br></div><div>Yes, it is just an implementation detail.</div><div><br></div><div>Today, we have a 1 to 1 mapping between middleware_server in MiQ and metrics that are supported in Hawkular.</div><div>This more or less worked fine until now.</div><div>So, as potentially we might have different servers with different metrics, this also impacts on this.</div><div><br></div><div>But I have been tested and I guess the current mechanism to re-join the manageiq reports gems is not prepared for the product/ folder.</div><div>(Tested locally doesn't work)</div><div><br></div><div>Anyway, it's not a problem, I can maintain files in the main repo, or change the folder if you know some folder we can use to place our config files, it is not a problem, just to change a path.</div><div><br></div><div>So I would rephrase my question, if I would like to add config files specific for the provider, where I can put them in the manageiq-providers-hawkular repo in order those are copied in the main manageiq repo when gem is used ? </div><div>(If it it's technically possible)</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Nov 23, 2017 at 6:55 PM, Thomas Heute <span dir="ltr"><<a href="mailto:theute@redhat.com" target="_blank">theute@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div>One reason for the remote config files is to be able to relatively quickly push an image to fix an issue, if moved to manageiq-providers-hawkular, one would have to wait until a new version of ManageIQ gets released.<br><br></div>Thomas<br></div><div class="gmail_extra"><br><div class="gmail_quote"><div><div class="h5"><div><div class="m_-9030842813154239513m_7908282769256716747h5">On Thu, Nov 23, 2017 at 5:35 PM, Lucas Ponce <span dir="ltr"><<a href="mailto:lponce@redhat.com" target="_blank">lponce@redhat.com</a>></span> wrote:<br></div></div></div></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div class="h5"><div><div class="m_-9030842813154239513m_7908282769256716747h5"><div dir="ltr">Hi,<div><br></div><div>In the context of tasks of HAWKULAR-1275 I think that moving those config files inside manageiq-providers-hawkular may make sense as probably I need to split them per type (EAP6 might have different metrics than EAP7, for example).</div><div><br></div><div>I guess it shouldn't be a problem as our provider is the only user for this.</div><div><br></div><div>Does anyone see any issue if I perform this change ?</div><div><br></div><div>Thanks,</div><div>Lucas</div><div><br></div></div>
<br></div></div></div></div>______________________________<wbr>_________________<br>
hawkular-dev mailing list<br>
<a href="mailto:hawkular-dev@lists.jboss.org" target="_blank">hawkular-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/hawkular-dev" rel="noreferrer" target="_blank">https://lists.jboss.org/mailma<wbr>n/listinfo/hawkular-dev</a><br>
<br></blockquote></div><br></div>
<br>______________________________<wbr>_________________<br>
hawkular-dev mailing list<br>
<a href="mailto:hawkular-dev@lists.jboss.org" target="_blank">hawkular-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/hawkular-dev" rel="noreferrer" target="_blank">https://lists.jboss.org/mailma<wbr>n/listinfo/hawkular-dev</a><br>
<br></blockquote></div><br></div></div>
</blockquote></div><br></div></div>