[hibernate-dev] H.Search: EventListenerRegister

[Sanne Grinovero]

Hello all,
I am currently doing some cleanup in the EventListenerRegister used in Search,
but I'm needing some clarifications (and please don't make any changes to it).

the code checks for the presence of a FullTextIndexEventListener on each
listener type, but doesn't want to use "isAssignableFrom" to let the user
subclass (this is said by a comment there). BUT it checks for
a listener of type FullTextIndexEventListener.class OR any direct extension,
to recognize also the now deprecated FullTextIndexCollectionEventListener.
Also the check is not done on both the class and it's subclass in each case.

What is the purpose exactly?
if a user creates an extension and registers it, shouldn't
we have to skip registration? so IMHO we should actually use "isAssignableFrom".
If you prefer to register our own listener anyway, maybe we should check
for the exact type FullTextIndexEventListener.class and
FullTextIndexCollectionEventListener.class (not any subtype).

regards,
Sanne