[hibernate-dev] Hibernate Search: ReaderProvider.destroy()

[Emmanuel Bernard]

Good
In DP it's stop() as the opposite of start() (initialize() has a  
different semantic for DPs)
And in RP it's destroy() as the opposite of initialize() like the  
Hibernate EventListeners

There is consistency :)

--
Emmanuel Bernard
http://in.relation.to/Bloggers/Emmanuel | http://blog.emmanuelbernard.com 
  | http://twitter.com/emmanuelbernard
Hibernate Search in Action (http://is.gd/Dl1)

On  Jul 19, 2008, at 03:21, Sanne Grinovero wrote:

> Yes I agree, good catch.
> Additionally I could add some minor performance improvement
> using a background thread in SharingBufferReaderProvider,
> (to have the file-closing operations of unneeded segments run async)
> but didn't implement that as I was lacking a shutdown hook.
>
> But DirectoryProvider(s) are doing the same stuff using a "stop()"  
> method,
> however I like the "destroy()" name more.
> I think for consistency they should be named the same.
>
> As the "stop" feature for DirectoryProviders is new in Search 3.1,
> maybe it's still ok to change it's name?
>
> Sanne
>
> 2008/7/19 Emmanuel Bernard <emmanuel at hibernate.org>:
> Should we need a readerProvider.destroy()?
>
> ReaderProvider typically keep IndexReaders open till they are in use  
> or if the index has been updated. But it has no hook to close the  
> "current" IndexReaders when Hibernate Search goes down.
>
> I imagine the current code can become problematic on some VMs if we  
> do lots of hot redeployments.
>
> --
> Emmanuel Bernard
> http://in.relation.to/Bloggers/Emmanuel | http://blog.emmanuelbernard.com 
>  | http://twitter.com/emmanuelbernard
> Hibernate Search in Action (http://is.gd/Dl1)
>
>
> _______________________________________________
> hibernate-dev mailing list
> hibernate-dev at lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/hibernate-dev
>
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.jboss.org/pipermail/hibernate-dev/attachments/20080719/a860c1dc/attachment.html