[hibernate-dev] [Search] Dynamic sharding configuration

Sanne Grinovero sanne at hibernate.org
Mon Oct 7 18:56:19 EDT 2013


I've included an example which represents a good reason to provide the
controversial method.
Technically the test is crafted as a static sharding approach but is
using the new API; you can easily figure the same case for a dynamic
sharding case; also considering we're deprecating the older static
sharding API, this should also be able to replace whatever was
possible before.

Could you have a look, reject one and review/merge the other:
 - https://github.com/hibernate/hibernate-search/pull/501
 - https://github.com/hibernate/hibernate-search/pull/502

I personally have a mild preference for "proposal A", as I think the
additional interface introduced in "proposal B" doesn't simplify but
adds an additional mark on the list of things the user needs to learn
about, but I'm happy with both solutions as long as we move on with
one.

We'll update documentation in a second PR, depending which way we go :-)

Cheers,
Sanne


More information about the hibernate-dev mailing list