[hibernate-dev] Compile error in hibernate-infinispan

[Steve Ebersole]

So the problem was that ultimately, compiled with Java 8, javac picks up
the default remove() impl from Iterator.  Pre-Java8 of course default
methods are not available.  I just added an impl of remove().

On Wed, Aug 19, 2015 at 12:27 PM Steve Ebersole <steve at hibernate.org> wrote:

> https://hibernate.atlassian.net/browse/HHH-10040
>
>
> On Wed, Aug 19, 2015 at 9:36 AM Steve Ebersole <steve at hibernate.org>
> wrote:
>
>> I few things...
>>
>> 1) Remember that JAVA6_HOME really needs to point to a JDK 7 HOME.
>> 2) We had a discussion on IRC wrt Infinispan 7 versus 8.  Infinispan 7 is
>> supposed to require at least Java 7; Infinispan 8 requires at least Java 8
>> 3) hibernate-infinispan pulls in Infinispan 7 (yes, there is a CI job
>> that tests against Infinispan 8)
>>
>> So all things told, assuming Java 7 is really used, I am not
>> understanding why hibernate-infinispan would not compile.  Unless
>> hibernate-infinispan is using some Java 7 specific API, but then why would
>> AnimalSniffer not complain?
>>
>>
>> On Wed, Aug 19, 2015 at 9:21 AM Sanne Grinovero <sanne at hibernate.org>
>> wrote:
>>
>>> On 19 August 2015 at 15:04, andrea boriero <dreborier at gmail.com> wrote:
>>> > I noticed the problem only when i run the build with  AVA6_HOME set
>>>
>>> Ah, great that might explain it!
>>> CI isn't setting that (and I'm also not setting that locally).
>>> Still, the hibernate-infinispan module is not compatible with Java6,
>>> so could you patch the build to not apply that for this module?
>>>
>>> Thanks,
>>> Sanne
>>>
>>> >
>>> > On 19 August 2015 at 13:27, Sanne Grinovero <sanne at hibernate.org>
>>> wrote:
>>> >>
>>> >> Hi Gail,
>>> >> I tried to build it as well but I couldn't reproduce the problem; how
>>> >> are you building it to trigger the error? Could you confirm which
>>> >> commit id you were building?
>>> >>
>>> >> While I don't have compile issues, I do however see some test failures
>>> >> after your last commit, and CI seems to agree:
>>> >>  - http://ci.hibernate.org/view/ORM/job/hibernate-orm-master-h2/1069/
>>> >>
>>> >> Thanks,
>>> >> Sanne
>>> >>
>>> >> On 18 August 2015 at 19:25, Gail Badner <gbadner at redhat.com> wrote:
>>> >> > I just pulled from master and tried building but got:
>>> >> >
>>> >> >
>>> >> >
>>> /home/gbadner/git/hibernate-orm-HHH-redo-again/hibernate-infinispan/src/main/java/org/hibernate/cache/infinispan/util/Caches.java:307:
>>> >> > error: <anonymous org.hibernate.cache.infinispan.util.Caches$2$1>
>>> is not
>>> >> > abstract and does not override abstract method remove() in Iterator
>>> >> >                                 return new CloseableIterator() {
>>> >> >                                                                ^
>>> >> > _______________________________________________
>>> >> > hibernate-dev mailing list
>>> >> > hibernate-dev at lists.jboss.org
>>> >> > https://lists.jboss.org/mailman/listinfo/hibernate-dev
>>> >> _______________________________________________
>>> >> hibernate-dev mailing list
>>> >> hibernate-dev at lists.jboss.org
>>> >> https://lists.jboss.org/mailman/listinfo/hibernate-dev
>>> >
>>> >
>>> _______________________________________________
>>> hibernate-dev mailing list
>>> hibernate-dev at lists.jboss.org
>>> https://lists.jboss.org/mailman/listinfo/hibernate-dev
>>>
>>