[hibernate-dev] [Hibernate Search] Checkstyle and Eclipse

[Gunnar Morling]

Hi Flemming,

Ah yes, I think that's the issue which made me abandon the plug-in in
the end :/ It's just coming to my mind again.

The Eclipse plug-in does not know about the custom HSEARCH checks.
Apparently there is a way for achieving this (see
http://eclipse-cs.sourceforge.net/#!/custom-checks), but I decided to
not follow up on this and don't use CS in Eclipse for Hibernate
Search. But if you'd like that to give a go (and CS and the custom
checks still work via Maven, too), this would be interesting. For sure
the experience of instant feedback in the IDE is much nicer.

The custom checks are located here:
https://github.com/hibernate/hibernate-search/tree/master/build-config/src/main/java/org/hibernate/checkstyle

Cheers,

--Gunnar



2015-09-03 18:25 GMT+02:00 Flemming Harms <flemming.harms at gmail.com>:
> You are right Gunnar I was working on a old branch, update fixed the problem
> with RedundantThrows.
>
> But now I get this : cannot initialize module TreeWalker - Unable to
> instantiate org.hibernate.checkstyle.checks.regexp.DoubleSpaces
>
> See this before?
>
> 2015-09-03 16:41 GMT+02:00 Gunnar Morling <gunnar at hibernate.org>:
>>
>> I remember having the same issue a while ago and fixed it back then by
>> removing the RedundantThrows check from HS' checkstyle.xml (see
>>
>> https://github.com/hibernate/hibernate-search/commit/543a9b1a9b86c22a3f4ad005ae6500fedaa83b67).
>>
>> So are you either on another branch or have the Eclipse CS plug-in
>> configured to work with another checkstyle.xml config?
>>
>> 2015-09-03 16:21 GMT+02:00 Sanne Grinovero <sanne at hibernate.org>:
>> > Hi Flemmings,
>> > others might know better, but personally I don't use the Checkstyle
>> > plugin for Eclipse but we created templates and formatting rules to
>> > match our coding conventions:
>> >
>> > https://github.com/hibernate/hibernate-ide-codestyles
>> >
>> > Sanne
>> >
>> > On 3 September 2015 at 14:59, Flemming Harms <flemming.harms at gmail.com>
>> > wrote:
>> >> Hi
>> >>
>> >> What version of the Eclipse checkstyle plug-in should I use? The latest
>> >> seems to have trouble using the current configuration due to
>> >> RedundantThrows was removed
>> >>
>> >> --
>> >>
>> >> Kind regards / Med Venlig Hilsen
>> >> Flemming Harms
>> >>
>> >>    -
>> >> _______________________________________________
>> >> hibernate-dev mailing list
>> >> hibernate-dev at lists.jboss.org
>> >> https://lists.jboss.org/mailman/listinfo/hibernate-dev
>> > _______________________________________________
>> > hibernate-dev mailing list
>> > hibernate-dev at lists.jboss.org
>> > https://lists.jboss.org/mailman/listinfo/hibernate-dev
>
>
>
>
> --
>
> Kind regards / Med Venlig Hilsen
> Flemming Harms
>
> https://twitter.com/fnharms
> https://dk.linkedin.com/in/fharms
>