[hibernate-dev] Antlr sources generated into default package

[Gunnar Morling]

Yes, the common directory structure is not strictly mandated.

But Eclipse's compiler does not like the flat style, so it's basically
impossible to run tests in Eclipse due to the gazillion compile
errors. So it'd be great to do the update to Gradle 2.7 quickly once
it's out.

2015-09-28 14:04 GMT+02:00 Steve Ebersole <steve at hibernate.org>:
> Java sources do not need to be kept in directory corresponding to their
> package.  It is a in-accurate common belief that that is needed.  It is
> convention, sure, but not needed.  That said, as Gunnar pointed out it is a
> regression in the Gradle Antlr parser that I actually reported to them.   I
> had not realized it was addressed yet.  And since it is "cosmetic" I reallly
> did not put much effort into it.
>
>
> On Mon, Sep 28, 2015 at 2:52 AM Gunnar Morling <gunnar at hibernate.org> wrote:
>>
>> Thanks, Sanne.
>>
>> Apparently it's a regression of the Gradle Antlr integration
>>
>> (https://discuss.gradle.org/t/antlr-plugin-should-preserve-package-structure/10153)
>> which should be fixed in Gradle 2.7.
>>
>> 2015-09-28 9:27 GMT+02:00 Sanne Grinovero <sanne at hibernate.org>:
>> > Hi Gunnar,
>> > I observed the same issue recently, but didn't search too hard for a
>> > solution, sorry. I'm compiling it from commandline.
>> >
>> > Sanne
>> >
>> > On 28 September 2015 at 09:02, Gunnar Morling <gunnar at hibernate.org>
>> > wrote:
>> >> Hi,
>> >>
>> >> When building hibernate-core, I am observing a strange mismatch of
>> >> package declaration and file location of generated Antlr sources (this
>> >> is about the current parser in ORM, not SQM):
>> >>
>> >> The files are generated into
>> >> hibernate-core/target/generated-src/antlr/main/, i.e. the default
>> >> package. But the package declarations within the files are
>> >> "org.hibernate.sql.ordering.antlr" and
>> >> "org.hibernate.hql.internal.antlr". Subsequently, I am seeing lots of
>> >> compile errors in Eclipse.
>> >>
>> >> Apparently it's not an issue with Gradle and I suppose also not in
>> >> IntelliJ, but I am puzzled how this actually works. Anyone observing
>> >> the same and with an idea how to generate the files into a directory
>> >> structure matching their package statements?
>> >>
>> >> Thanks,
>> >>
>> >> --Gunnar
>> >> _______________________________________________
>> >> hibernate-dev mailing list
>> >> hibernate-dev at lists.jboss.org
>> >> https://lists.jboss.org/mailman/listinfo/hibernate-dev
>> _______________________________________________
>> hibernate-dev mailing list
>> hibernate-dev at lists.jboss.org
>> https://lists.jboss.org/mailman/listinfo/hibernate-dev