[hibernate-dev] [Search] Range faceting for Longs and Dates not taking into account hasZeroCountsIncluded

[Gunnar Morling]

Guillaume, just in case, if you plan to work on stuff around the ES
backend, I'd recommend you do so based on my pending PR
https://github.com/hibernate/hibernate-search/pull/960. This changes
quit a bit, so you may be in merge hell otherwise.

2016-02-03 9:15 GMT+01:00 Emmanuel Bernard <emmanuel at hibernate.org>:
> It's probably a bug, Hardy, you confirm?
>
> On Tue 2016-02-02 15:40, Guillaume Smet wrote:
>> Hi,
>>
>> While playing with ElasticSearch faceting (and having tests failing due to
>> that), I noticed that for Longs and Dates, the preexisting range faceting
>> doesn't take into account facetRequest.hasZeroCountsIncluded().
>>
>> See
>> https://github.com/hibernate/hibernate-search/blob/master/engine/src/main/java/org/hibernate/search/query/engine/impl/QueryHits.java#L308
>> and a few lines below for floating point ranges which take into account
>> this very parameter.
>>
>> Is this something expected? Should I prepare a PR to fix it?
>>
>> --
>> Guillaume
>> _______________________________________________
>> hibernate-dev mailing list
>> hibernate-dev at lists.jboss.org
>> https://lists.jboss.org/mailman/listinfo/hibernate-dev
> _______________________________________________
> hibernate-dev mailing list
> hibernate-dev at lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/hibernate-dev