[hibernate-dev] SchemaCreatorImpl always creating a poolable sequence

Mark Rotteveel mark at lawinegevaar.nl
Fri Jul 29 07:53:04 EDT 2016


On 2016-07-28 17:07, Steve Ebersole wrote:
> I do think this is an error.  I think the proper fix is to first
> make use of Exporter<Sequence>#getSqlCreateStrings via
> Dialect#getSequenceExporter.  
>
> From there, either:
>
> 	* Change the standard Exporter<Sequence> to look at
> Dialect#supportsPooledSequences and deciding which
> Dialect#getCreateSequenceStrings form to call
> 	* Change Firebirds Exporter<Sequence> impl
>
> Id also suggest we properly deprecate 
> Dialect#supportsPooledSequences,
> Dialect#getCreateSequenceStrings directing to
> Dialect#getSequenceExporter.  

I will look this weekend if I can do that as part of my dialect 
implementation; I will likely do it with a separate pull request.

Mark


More information about the hibernate-dev mailing list