[hibernate-dev] ORM - HHH-12332 - Releasing a 5.2.15 quickly?

[Sanne Grinovero]

Let's not rush things and see what Christian thinks: he should be
allowed to analyze this - if he has time and wants to - w/o too much
pressure. I see the last report is an NPE, that's typically not too
hard to fix so I'd rather try again.

The risk with a full revert is that it's never getting fixed: we're
missing some unit tests for "unknown" corner cases, so I propose we
put ourselves at least in the position to be able to collect enough
feedback to be able to (eventually) reproduce them and then proceed
with confidence.





On 7 March 2018 at 12:39, andrea boriero <andrea at hibernate.org> wrote:
> I agree with the revert solution Guillaume proposed.
>
> On 7 March 2018 at 12:25, Guillaume Smet <guillaume.smet at gmail.com> wrote:
>
>> Apparently, there is still an issue with the latest fix but a different
>> one:
>> https://hibernate.atlassian.net/browse/HHH-12332?page=com.
>> atlassian.jira.plugin.system.issuetabpanels%3Acomment-
>> tabpanel&focusedCommentId=101427#comment-101427
>>
>> I posted a message to try to help the OP isolating the issue.
>>
>> I know it's not very satisfactory but I would really prefer that we revert
>> this all for now. It's too risky just to fix a corner case.
>>
>> --
>> Guillaume
>>
>> On Wed, Mar 7, 2018 at 12:11 PM, andrea boriero <andrea at hibernate.org>
>> wrote:
>>
>>> sorry but I had an horrible night and not feeling great right now so I'll
>>> do the release late this afternoon or tomorrow morning.
>>>
>>> On 6 March 2018 at 19:32, Chris Cranford <chris at hibernate.org> wrote:
>>>
>>> > Gail -
>>> >
>>> > I asked Andrea earlier and he hoped Wednesday March 7th; however he did
>>> > say it depends on the status of Christian's fix.
>>> >
>>> > On 03/06/2018 02:13 PM, Gail Badner wrote:
>>> > > When are you planning to release? I'd like to take a look at the
>>> original
>>> > > fix and PR as well.
>>> > >
>>> > > On Tue, Mar 6, 2018 at 5:44 AM, Steve Ebersole <steve at hibernate.org>
>>> > wrote:
>>> > >
>>> > >> +1
>>> > >>
>>> > >> If you are confident, that's good for me
>>> > >>
>>> > >>
>>> > >> On Tue, Mar 6, 2018, 7:24 AM Sanne Grinovero <sanne at hibernate.org>
>>> > wrote:
>>> > >>
>>> > >>> On 6 March 2018 at 11:21, Christian Beikov <
>>> christian.beikov at gmail.com
>>> > >
>>> > >>> wrote:
>>> > >>>> Hey,
>>> > >>>>
>>> > >>>> I'm fine with reverting the patch as well, though I just fixed the
>>> > >> issue
>>> > >>>> Andrea found and am confident about the solution now.
>>> > >>> Hi Christian, that's great! Let's go with your fix then.
>>> > >>>
>>> > >>> Thanks,
>>> > >>> Sanne
>>> > >>>
>>> > >>>
>>> > >>>>
>>> > >>>> Mit freundlichen Grüßen,
>>> > >>>> ------------------------------------------------------------
>>> > >> ------------
>>> > >>>> *Christian Beikov*
>>> > >>>> Am 06.03.2018 um 11:57 schrieb Guillaume Smet:
>>> > >>>>> Hi,
>>> > >>>>>
>>> > >>>>> So, AFAICS, Andrea found another failing case for the new PR.
>>> > >>>>>
>>> > >>>>> I would vote for reverting the original patch [
>>> > >>>>> https://hibernate.atlassian.net/browse/HHH-11544] for now and let
>>> > >>> Christian
>>> > >>>>> the time to think of a proper fix. I'm a bit worried we will miss
>>> > >>> something
>>> > >>>>> if we try to find a fix in a hurry.
>>> > >>>>>
>>> > >>>>> AFAICS, the original issue was a bit of a corner case so better
>>> get
>>> > >> the
>>> > >>>>> other more common cases working.
>>> > >>>>>
>>> > >>>>> Anyone against reverting the original patch? Christian?
>>> > >>>>>
>>> > >>>> _______________________________________________
>>> > >>>> hibernate-dev mailing list
>>> > >>>> hibernate-dev at lists.jboss.org
>>> > >>>> https://lists.jboss.org/mailman/listinfo/hibernate-dev
>>> > >>> _______________________________________________
>>> > >>> hibernate-dev mailing list
>>> > >>> hibernate-dev at lists.jboss.org
>>> > >>> https://lists.jboss.org/mailman/listinfo/hibernate-dev
>>> > >> _______________________________________________
>>> > >> hibernate-dev mailing list
>>> > >> hibernate-dev at lists.jboss.org
>>> > >> https://lists.jboss.org/mailman/listinfo/hibernate-dev
>>> > >>
>>> > > _______________________________________________
>>> > > hibernate-dev mailing list
>>> > > hibernate-dev at lists.jboss.org
>>> > > https://lists.jboss.org/mailman/listinfo/hibernate-dev
>>> >
>>> > _______________________________________________
>>> > hibernate-dev mailing list
>>> > hibernate-dev at lists.jboss.org
>>> > https://lists.jboss.org/mailman/listinfo/hibernate-dev
>>> >
>>> _______________________________________________
>>> hibernate-dev mailing list
>>> hibernate-dev at lists.jboss.org
>>> https://lists.jboss.org/mailman/listinfo/hibernate-dev
>>>
>>
>>
> _______________________________________________
> hibernate-dev mailing list
> hibernate-dev at lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/hibernate-dev