[hibernate-dev] Hibernate ORM : format of the version logged on boot

[Sanne Grinovero]

On Mon, 17 Feb 2020 at 14:20, Steve Ebersole <steve at hibernate.org> wrote:
>
> I tend to agree with Gail here.  Sure Sanne I understand your view there, but realistically:
> 1) which other ORM jars do you see printing its version?

None, but I'm wondering if we wanted to improve on that.

> 2) when are you expecting that ORM jar versions can be mixed amongst the different modules?

I don't expect that to be "supported", but people might do it, so
having such logs could theoretically help us to spot a misalignment.

I have no strong opinion about this, I just felt more inclined to go
for the more conservative change - especially as I had not heard your
opinion yet: If you prefer to polish this further I have no
objections.

Thanks!


>
> On Thu, Feb 13, 2020 at 10:42 AM Sanne Grinovero <sanne at hibernate.org> wrote:
>>
>> Thanks all, I'll make the changes then:
>>  - https://hibernate.atlassian.net/browse/HHH-13863
>>
>> Gail, answered to you below - sorry it took so long.
>>
>> On Fri, 7 Feb 2020 at 18:24, Gail Badner <gbadner at redhat.com> wrote:
>> >
>> > +1 to changing it.
>> >
>> > The name was changed from "core" to "ORM" some years back. Can "core" just be dropped now?
>>
>> I'd prefer keeping the qualifier as it's referring to the
>> "hibernate-core" jar, in the sense it's one jar among the various jars
>> in Hibernate ORM as a whole.
>>
>> The reason is that there's tooling coming to help spotting misaligned
>> jars, so say hibernate-core and hibernate-ehcache need to be at the
>> same version, as they both belong to Hibernate ORM as whole.
>> Essentially, we still need a way to identify the parts as they are
>> packaged into different jars, so the qualifier is still useful in some
>> contexts.
>>
>> >
>> > On Fri, Feb 7, 2020 at 6:20 AM Yoann Rodiere <yoann at hibernate.org> wrote:
>> >>
>> >> +1
>> >>
>> >>
>> >> Yoann Rodière
>> >> Hibernate Team
>> >> yoann at hibernate.org
>> >>
>> >>
>> >> On Fri, 7 Feb 2020 at 14:58, Sanne Grinovero <sanne at hibernate.org> wrote:
>> >>
>> >> > It's minor cosmetics, but I'd like to change the format of the message
>> >> > we log on boot.
>> >> >
>> >> > Currently we have:
>> >> >     INFO  [org.hib.Version] HHH000412: Hibernate Core {5.4.11-SNAPSHOT}
>> >> >
>> >> > I would like to change it into:
>> >> >    INFO  [org.hib.Version] HHH000412: Hibernate ORM core version
>> >> > 5.4.11-SNAPSHOT
>> >> >
>> >> > in particular:
>> >> >  - to remove the "{}" wrapping around the number
>> >> >  - add "ORM"
>> >> >  - lowercase "core" and add "version"
>> >> >
>> >> > Looks good? It would be more consistent with our own project
>> >> > naming/branding, and with the format of similar messages being logged
>> >> > by other popular libraries.
>> >> >
>> >> > Thanks,
>> >> > Sanne
>> >> > _______________________________________________
>> >> > hibernate-dev mailing list
>> >> > hibernate-dev at lists.jboss.org
>> >> > https://lists.jboss.org/mailman/listinfo/hibernate-dev
>> >> >
>> >> >
>> >> _______________________________________________
>> >> hibernate-dev mailing list
>> >> hibernate-dev at lists.jboss.org
>> >> https://lists.jboss.org/mailman/listinfo/hibernate-dev
>>
>> _______________________________________________
>> hibernate-dev mailing list
>> hibernate-dev at lists.jboss.org
>> https://lists.jboss.org/mailman/listinfo/hibernate-dev