<html><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><div>I've (re-)fixed the conflict of patches we had between Navin's commit and my original proposed fixes. I've also fixed a but between annotations head and search head wrt event listener initializations (that's why I don't like ivy not pointing to latest :) )</div><div><br></div><div>Please please please everyone:</div><div> - use the right style template. I have one for IntelliJ I can provide, I'm sure someone has one for Eclipse. No more style conflict madness.</div><div> - run ant clean junit before committing. If it fails, do not commit.</div><div><br></div><div><br></div><div>BTW We are close to the beta 1 freeze, likely to be tonight or tomorrow</div><div><br></div><div>A few questions and comments</div><div><span class="Apple-tab-span" style="white-space: pre; "> </span>@ProvidedId</div><div>Should @ProvidedId be renamed @ExternalId?<br>ProvidedId.bridge() is no longer of type Class<StringBridge>, just Class (see later)<br>name() defaults to providedId (I still think "id" is a better name, though)</div><div><br></div><div><span class="Apple-tab-span" style="white-space:pre"> </span>SearchFactoryImpl<br>I've done various refactorings to eliminate the dependency between o.h.c.Configuration and SearchFactoryImpl<br>The event system is now responsible for converting the o.h.c.Configuration into a Search configuration<br></div><div><br></div><div><span class="Apple-tab-span" style="white-space:pre"> </span>TransactionContext</div>I moved them next to the Worker and Worker queues in backend (its implementation is in backend.impl<br>renamed isTxInProgress() to a readable name<div>I removed TransactionContext as Serializable, each implementation shold make its own decision. EventsourceTC is not serialzible: they could use transient / readObject / writeObject<br><div><br></div><div><span class="Apple-tab-span" style="white-space:pre"> </span>SearchConfiguration<br></div><div>The HibernameImplementation now deal with getMappedClass() returning null. I used Class<?> instead of the raw Class in the interface.</div><div><br></div><div><br></div><div><br></div><div><br></div><div>Here are the things Navin still needs to work on:<br><span class="Apple-tab-span" style="white-space: pre; "> </span>DocumentBuilder<br>1. @ProvidedId can be set on a superclass, your code does not deal with it<br>2. you've hardcoded the bridge implementation to StringBridge, this is not good and should be configured by ProvidedId.bridge().This should be done more or less like BridgeFactory.extractType(ClassBridge);<br><br></div><div>Those 2 need to be fixed before we go and release the @ProvidedId feature but this can wait till after Beta1</div><div><br></div><div><br></div><div><br></div><div><br><div> <span class="Apple-style-span" style="border-collapse: separate; color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0; "><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><span class="Apple-style-span" style="border-collapse: separate; color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; "><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><span class="Apple-style-span" style="border-collapse: separate; color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; "><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><div>--</div><div><div>Emmanuel Bernard</div><div><a href="http://in.relation.to/Bloggers/Emmanuel">http://in.relation.to/Bloggers/Emmanuel</a> | <a href="http://blog.emmanuelbernard.com/">http://blog.emmanuelbernard.com</a> | <a href="http://twitter.com/emmanuelbernard">http://twitter.com/emmanuelbernard</a></div><div>Hibernate Search in Action (<a href="http://is.gd/Dl1">http://is.gd/Dl1</a>)</div></div></div></span></div></span></div></span> </div><br></div></div></body></html>