<html><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><div>Hey Navin,</div><div>I reverted to patch on the Jboss cache / hsearch tests. It did not respect the project's style convention (XML and Java).</div><div><a href="http://fisheye.jboss.org/rdiff/Hibernate?csid=14963&u&N">http://fisheye.jboss.org/rdiff/Hibernate?csid=14963&u&N</a></div><div><br></div><div>More generally speaking, it seems wrong to add a dependency to jboss cache and JBoss Cache Searchable from Hibernate Search. That would create circular dependencies. I imagine those tests should live in JBoss Cache Searchable.</div><div>It is better to add unit tests about @ProvidedId but using Hibernate Core (as opposed to the cache API). Place them in the package org.hibernate.search.test.id.providedid</div><div><br></div><br><div> <span class="Apple-style-span" style="border-collapse: separate; color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0; "><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><span class="Apple-style-span" style="border-collapse: separate; color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; "><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><span class="Apple-style-span" style="border-collapse: separate; color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; "><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><div>--</div><div><div>Emmanuel Bernard</div><div><a href="http://in.relation.to/Bloggers/Emmanuel">http://in.relation.to/Bloggers/Emmanuel</a> | <a href="http://blog.emmanuelbernard.com/">http://blog.emmanuelbernard.com</a> | <a href="http://twitter.com/emmanuelbernard">http://twitter.com/emmanuelbernard</a></div><div>Hibernate Search in Action (<a href="http://is.gd/Dl1">http://is.gd/Dl1</a>)</div></div></div></span></div></span></div></span> </div><br></body></html>