<html><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">Hey Lukasz,<div>Your patch looks quite good and pass tests on my side.</div><div><br></div><div>I encourage others to check out the patch before we apply it (ideally another person form HSearch and one person from infinispan.</div><div><br></div><div><br></div><div>Lukasz, I have a few questions/remarks though before applying it. Can you answer / adjust the patch?</div><div><br></div><div>IndexWriterSetting</div><div><div>Why move to return Object in parsing from the initial int?</div><div><br></div><div>Move DPHelper#createInfinispanCacheManager to IDP</div><div>this is not something that can be shared as it creates a hard dependency on infinispan otherwise.</div><div><br></div><div>in createInfinispanCacheManager</div><div>Don't log in error the fact that xml is not used if a default config is used. Just log in trace at best.</div><div><br></div><div>Rename InfinispanCacheManagerConfigurationImpl to DefaultInfinispanCacheManagerConfiguration or even better with a name describing nicely the behavior of the infinispan config.</div><div><br></div><div>in InfinispanIndexOutput, is it possible to get writeBytes bigger than buffer size? If yes, does newCheck creates the appropriate numbers of chunks?</div><div><br></div><div>InfinispanDirectoryProvider</div><div>put the configuration proeprties available in the InfinispanDirectoryProvider javadoc.</div><div><br></div><div>I think the default cache name should be "Hibernate Search" instead of "HSInfinispanCache". We know it's in infinispan :)</div><div><br></div><div>what's the try catch opening and closing an IW about? It looks weird.</div><div><br></div><div>in stop()</div><div>you don't close the CacheManager? How is that?</div><div><br></div><div>InfinispanCacheManagerConfigurationImpl</div><div>What does "Infinispan-Cluster" correspond to? Why this name? Shouldn't it be "Hibernate Search cluster"?</div><div>Is it safe to override the GlobalConfiguration? What if JBoss AS use infinispan to run?</div><div><br></div><div><div>Why the use of DummyTransactionManagerLookup. Doesn't Infinispan guess the right TM depending on the environment? e in JBoss As use the JBoss one etc? I think GenericTransactionManagerLookup does that.</div><div><br></div></div><div>InfinispanCacheManagerConfiguration</div><div>some javadoc on the methods would be useful. I don't know what do implement here.</div><div><br></div><div><br></div><div>Is there a better name for Metadata? Like FileMetadata maybe?</div><div><br></div><div>Where is ispn-cache-default-conf.xml used? For tests only? If not: is it possible to use a programmatic version instead and what is "It's a movie cache"?</div><div><br></div><div>Emmanuel</div><div><br></div></div><div><br><div><br><div>Begin forwarded message:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; "><font face="Helvetica" size="3" color="#000000" style="font: 12.0px Helvetica; color: #000000"><b>From: </b></font><font face="Helvetica" size="3" style="font: 12.0px Helvetica">Łukasz Moreń <<a href="mailto:lukasz.moren@gmail.com">lukasz.moren@gmail.com</a>></font></div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; "><font face="Helvetica" size="3" color="#000000" style="font: 12.0px Helvetica; color: #000000"><b>Date: </b></font><font face="Helvetica" size="3" style="font: 12.0px Helvetica">21 août 2009 02:11:03 HAEC</font></div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; "><font face="Helvetica" size="3" color="#000000" style="font: 12.0px Helvetica; color: #000000"><b>To: </b></font><font face="Helvetica" size="3" style="font: 12.0px Helvetica">Emmanuel Bernard <<a href="mailto:emmanuel@hibernate.org">emmanuel@hibernate.org</a>></font></div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; "><font face="Helvetica" size="3" color="#000000" style="font: 12.0px Helvetica; color: #000000"><b>Subject: </b></font><font face="Helvetica" size="3" style="font: 12.0px Helvetica"><b>GSoC patch with Infinispan Directory Provider</b></font></div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; min-height: 14px; "><br></div> </div><div>I'm sending patch and piece of documentation - not much but necessary information are included. </div><div>There are some todos but I didn't manage to finish it yet.</div><div>I changed maven jgroups dependency to 2.8.beta2, before version was clashed with used by infinispan.</div> <div>In pom file there was dependency on hibernate common annotations 3.2.shapshot. It should't be 3.5?</div><div><br></div>Cheers,<div>Lukasz</div> </blockquote></div></div></body></html>