<html><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div><div>On 27 Aug 2009, at 13:06, Emmanuel Bernard wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div><br>On 27 août 09, at 13:07, Manik Surtani wrote:<br><br><blockquote type="cite">Very elegant. I'm generally a big fan of 'builder' patterns like this, but this really isn't a DSL, is it? :) When you first mentioned a DSL I had visions of defining a new grammar and an ANTLR parser, etc. But that is overkill.<br></blockquote><br>This is called an internal DSL, ie you use Java as the language, not some external representation.<br><br><blockquote type="cite"><br></blockquote><blockquote type="cite">This approach certainly works, and will almost certainly perform better too. One question: for the sake of brevity, why SealedQueryBuilder instead of QueryBuilder ? :)<br></blockquote><br>The name is not right yet<br><br>There are two things:<br> - the query builder that lets you define the analyzer<br> - the query builder that has an analyzer assigned and lets you build query<br>What name is best for each of them.<br></div></blockquote><div><br></div><div>I thought this stuff you mentioned made sense:</div><div><br></div><div></div><blockquote type="cite"><div><span class="Apple-style-span" style="font-family: Arial; ">queryBuilder.withAnalyzer(Analyzer)</span></div><div><span class="Apple-style-span" style="font-family: Arial; "><div>queryBuilder.withEntityAnalyzer(Class<?>)</div><div>queryBuilder.basedOnEntityAnalyzer(Class<?>)</div><div> .overridesForField(String field, Analyzer)</div><div> .overridesForField(String field, Analyzer)</div><div> .build() //sucky name</div></span></div></blockquote><div><br></div><div>Perhaps rename the static factory methods to something like:</div><div><br></div><div>QueryBuilder.getQueryBuilder(Analyzer)</div><div>QueryBuilder.getQueryBuilder(Class<?>)</div><div><br></div><div>and QueryBuilder instances have overrideAnalyzerForField(String, Analyzer). Why do you need the build() method at the end?</div><div><br></div><br><blockquote type="cite"><div><br><blockquote type="cite"><br></blockquote><blockquote type="cite">Also, I still think that if this is a generic helper factory that helps you build Lucene queries - and has no knowledge of how and where the query is used (why should it?) - then this should be something people can use outside of HS or Infinispan. E.g., directly with Lucene.<br></blockquote><br>As of today this code is technically pure Lucene but to be honest the idea of passing an analyzer multiplexer (like the one we receive from searchFactory.getAnalyzer<Class<?>)) is not wildly spread in Lucene and potentially cumbersome wo the declarative approach of HSearch.<br><br>The second problem is that some potential improvements will require inner knowledge of HSearch:<br> - object parameters (and not string params) do require to know the FieldBridge of the property. This is a pure HSearch notion.<br> - "property literal" like JPA is introducing could be added to replace the String-based field approach in some situations. Though I don't think that it would be a perfect fit.<br> - spell checker (the old idea we had)<br><br>That been said, if the API ends up being pure Lucene and once we stabilize it, we can contribute it back even though I am not necessarily a huge fan of ASL.<br></div></blockquote><div><br></div><div>Not it doesn't have to be either ASL or even hosted at Apache. I guess what I am suggesting is perhaps even a separate project - LuceneQueryBuilder or something - which plain-old-Lucene users could use as well. Doesn't matter where it's hosted or what the license is - as long as its ASL or LGPL :)</div><div><br></div><div>--</div></div><div apple-content-edited="true"><span class="Apple-style-span" style="border-collapse: separate; color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0; "><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><span class="Apple-style-span" style="border-collapse: separate; color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; "><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><div>Manik Surtani</div><div><a href="mailto:manik@jboss.org">manik@jboss.org</a></div><div>Lead, Infinispan</div><div>Lead, JBoss Cache</div><div><a href="http://www.infinispan.org">http://www.infinispan.org</a></div><div><a href="http://www.jbosscache.org">http://www.jbosscache.org</a></div><div><br></div></div></span><br class="Apple-interchange-newline"></div></span><br class="Apple-interchange-newline"> </div><br></body></html>