[hibernate-issues] [Hibernate-JIRA] Created: (HHH-3084) DialectFactory.java doesn't map the IngresDialect

[Michael Leo (JIRA)]

DialectFactory.java doesn't map the IngresDialect
-------------------------------------------------

                 Key: HHH-3084
                 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3084
             Project: Hibernate3
          Issue Type: Bug
          Components: core
    Affects Versions: 3.2.5, 3.2.4.sp1, 3.2.4, 3.2.3, 3.2.2, 3.2.1, 3.2.0.ga, 3.2.0.cr5, 3.2.0.cr4, 3.2.0.cr3, 3.2.0.cr2, 3.2.0 cr1, 3.1.3, 3.2.0.alpha2, 3.2.0.alpha1, 3.1.2, 3.1.1, 3.1, 3.1 rc3, 3.1 rc2, 3.1 rc 1, 3.1 beta 2, 3.1 beta 1, 3.0.5, 3.0.4, 3.0.3, 3.0.2, 3.0.1, 3.0 final, 3.0 rc 1, 3.0 beta 4, 3.0 beta 3, 3.0 beta 2, 3.0 beta 1, 3.0 alpha
         Environment: Hibernate 3.x and frameworks based on the Spring Framework, like Grails
            Reporter: Michael Leo
         Attachments: DialectFactory.java.patch

Although Hibernate ships with an Ingres dialect 

    org.hibernate.dialect.IngresDialect

 it can't be found by the dialect factory

    org.hibernate.dialect.DialectFactory

Although most tools can be forced to use the proper dialect, there is a circumstance
in Grails where there is no way to specify the correct Hibernate dialect for a custom 
data source.

The patch is pretty straightforward.  I've attached the output of "svn diff" from the 
root of the latest branch.

Hope this makes sense,

Mike Leo

$ svn diff
Index: src/org/hibernate/dialect/DialectFactory.java
===================================================================
--- src/org/hibernate/dialect/DialectFactory.java       (revision 14289)
+++ src/org/hibernate/dialect/DialectFactory.java       (working copy)
@@ -112,6 +112,9 @@
        private static final Map MAPPERS = new HashMap();
        static {
                // TODO : this is the stuff it'd be nice to move to a properties file or some other easily user-editable place
+               MAPPERS.put( "Ingres", new VersionInsensitiveMapper( "org.hibernate.dialect.IngresDialect" ) );
+               MAPPERS.put( "ingres", new VersionInsensitiveMapper( "org.hibernate.dialect.IngresDialect" ) );
+               MAPPERS.put( "INGRES", new VersionInsensitiveMapper( "org.hibernate.dialect.IngresDialect" ) );
                MAPPERS.put( "HSQL Database Engine", new VersionInsensitiveMapper( "org.hibernate.dialect.HSQLDialect" ) );
                MAPPERS.put( "DB2/NT", new VersionInsensitiveMapper( "org.hibernate.dialect.DB2Dialect" ) );
                MAPPERS.put( "DB2/LINUX", new VersionInsensitiveMapper( "org.hibernate.dialect.DB2Dialect" ) );
$

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira