<style>
/* Changing the layout to use less space for mobiles */
@media screen and (max-device-width: 480px), screen and (-webkit-min-device-pixel-ratio: 2) {
#email-body { min-width: 30em !important; }
#email-page { padding: 8px !important; }
#email-banner { padding: 8px 8px 0 8px !important; }
#email-avatar { margin: 1px 8px 8px 0 !important; padding: 0 !important; }
#email-fields { padding: 0 8px 8px 8px !important; }
#email-gutter { width: 0 !important; }
}
</style>
<div id="email-body">
<table id="email-wrap" align="center" border="0" cellpadding="0" cellspacing="0" style="background-color:#f0f0f0;color:#000000;width:100%;">
<tr valign="top">
<td id="email-page" style="padding:16px !important;">
<table align="center" border="0" cellpadding="0" cellspacing="0" style="background-color:#ffffff;border:1px solid #bbbbbb;color:#000000;width:100%;">
<tr valign="top">
<td bgcolor="#3e4c4e" style="background-color:#3e4c4e;color:#ffffff;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;line-height:1;"><img src="https://www.jboss.org/dms/hibernate/images/jira/jiraheader_hibernate.png" alt="" style="vertical-align:top;" /></td>
</tr><tr valign="top">
<td id="email-banner" style="padding:32px 32px 0 32px;">
<table align="left" border="0" cellpadding="0" cellspacing="0" width="100%" style="width:100%;">
<tr valign="top">
<td style="color:#505050;font-family:Arial,FreeSans,Helvetica,sans-serif;padding:0;">
<img id="email-avatar" src="https://hibernate.onjira.com/secure/useravatar?ownerId=steve&avatarId=10346" alt="" height="48" width="48" border="0" align="left" style="padding:0;margin: 0 16px 16px 0;" />
<div id="email-action" style="padding: 0 0 8px 0;font-size:12px;line-height:18px;">
<a class="user-hover" rel="steve" id="email_steve" href="https://hibernate.onjira.com/secure/ViewProfile.jspa?name=steve" style="color:#6c797f;">Steve Ebersole</a>
updated <img src="https://hibernate.onjira.com/images/icons/improvement.gif" height="16" width="16" border="0" align="absmiddle" alt="Improvement"> <a style='color:#6c797f;text-decoration:none;' href='https://hibernate.onjira.com/browse/HHH-4394'>HHH-4394</a>
</div>
<div id="email-summary" style="font-size:16px;line-height:20px;padding:2px 0 16px 0;">
<a style='color:#6c797f;text-decoration:none;' href='https://hibernate.onjira.com/browse/HHH-4394'><strong>@OrderBy usage on a joined classes (when using join table) produces incorred SQL syntax.</strong></a>
</div>
</td>
</tr>
</table>
</td>
</tr>
<tr valign="top">
<td id="email-fields" style="padding:0 32px 32px 32px;">
<table border="0" cellpadding="0" cellspacing="0" style="padding:0;text-align:left;width:100%;" width="100%">
<tr valign="top">
<td id="email-gutter" style="width:64px;white-space:nowrap;"></td>
<td>
<table border="0" cellpadding="0" cellspacing="0" width="100%">
<tr valign="top">
<td colspan="2" style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 0 16px 0;width:100%;">
<div class="comment-block" style="background-color:#edf5ff;border:1px solid #dddddd;color:#000000;padding:12px;"><p>Fixed formatting to be able to actually read this</p></div>
<div style="color:#505050;padding:4px 0 0 0;"> </div>
</td>
</tr>
<tr valign="top">
<td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 10px 10px 0;white-space:nowrap;">
<strong style="font-weight:normal;color:#505050;">Change By:</strong>
</td>
<td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 0 10px 0;width:100%;">
<a class="user-hover" rel="steve" id="email_steve" href="https://hibernate.onjira.com/secure/ViewProfile.jspa?name=steve" style="color:#6c797f;">Steve Ebersole</a>
(14/Jun/12 12:37 PM)
</td>
</tr>
<tr valign="top">
<td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 10px 10px 0;white-space:nowrap;">
<strong style="font-weight:normal;color:#505050;">Description:</strong>
</td>
<td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 0 10px 0;width:100%;">
<span class="diffcontext">Please consider the following mapping :<br><br></span>
<span class="diffaddedchars" style="background-color:#ddfade;">{code}<br></span>
<span class="diffcontext">@ManyToMany(cascade = {CascadeType.PERSIST, CascadeType.MERGE}, fetch = FetchType.LAZY)<br> @IndexColumn(name = "ListIndex")<br> @JoinTable(</span>
<span class="diffaddedchars" style="background-color:#ddfade;"><br></span>
<span class="diffcontext">name = "odp_rulemanipulatorjoin",</span>
<span class="diffaddedchars" style="background-color:#ddfade;"> <br></span>
<span class="diffcontext"> joinColumns = @JoinColumn(name = "RoutingRuleId"),</span>
<span class="diffaddedchars" style="background-color:#ddfade;"> <br></span>
<span class="diffcontext"> inverseJoinColumns = @JoinColumn(name = "ManipulatorComponentId")</span>
<span class="diffaddedchars" style="background-color:#ddfade;"><br></span>
<span class="diffcontext">)<br> @OrderBy(value = "priority asc")<br> public List<RoutingManipulationComponent> getManipulators() {<br> if (manipulators == null) {<br> manipulators = new ArrayList<RoutingManipulationComponent>();<br> }<br><br> return manipulators;<br> }<br></span>
<span class="diffaddedchars" style="background-color:#ddfade;">{code}</span>
<span class="diffcontext"><br></span>
<span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;">***********************************</span>
<span class="diffcontext"><br></span>
<span class="diffaddedchars" style="background-color:#ddfade;">{code}<br></span>
<span class="diffcontext">@Entity(name = "RoutingManipulationComponent")<br>@DiscriminatorValue("RoutingManipulationComponent")<br>public abstract class RoutingManipulationComponent</span>
<span class="diffaddedchars" style="background-color:#ddfade;"> <br></span>
<span class="diffcontext"> extends RoutingComponent implements Initializable {<br><br> /**<br> * Applies the manipulation to the given context.<br> *<br> * @param context the routing context to manipulate<br> * @return true if any manipulation was applied, false if no manipulation<br> * occurred<br> */<br> public abstract boolean apply(RoutingContext context);<br><br>}<br></span>
<span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;">******************************************</span>
<span class="diffaddedchars" style="background-color:#ddfade;">{code}</span>
<span class="diffcontext"><br><br></span>
<span class="diffaddedchars" style="background-color:#ddfade;">{code}<br></span>
<span class="diffcontext">@Entity(name = "RoutingComponent")<br>@Inheritance(strategy = InheritanceType.SINGLE_TABLE)<br>@DiscriminatorColumn(</span>
<span class="diffaddedchars" style="background-color:#ddfade;"><br></span>
<span class="diffcontext">name = "RoutingComponentType",</span>
<span class="diffaddedchars" style="background-color:#ddfade;"> <br></span>
<span class="diffcontext"> discriminatorType = DiscriminatorType.STRING</span>
<span class="diffaddedchars" style="background-color:#ddfade;"><br></span>
<span class="diffcontext">)<br>@DiscriminatorValue("RoutingComponent")<br>@Table(name = "odp_routingcomponent")<br>public abstract class RoutingComponent extends DialPlanProvisionalEntity { <br> @Deprecated<br> public RoutingComponent() {<br> // blank<br> }<br> <br> /**<br> * @param name<br> * @param description<br> */<br> public RoutingComponent(String name, String description) {<br> super(name, description);<br> }<br><br>}<br></span>
<span class="diffaddedchars" style="background-color:#ddfade;">{code}</span>
<span class="diffcontext"><br></span>
<span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;">*******************************</span>
<span class="diffcontext"><br></span>
<span class="diffaddedchars" style="background-color:#ddfade;">{code}</span>
<span class="diffcontext"><br>@MappedSuperclass<br>@Cache(usage = CacheConcurrencyStrategy.READ_WRITE)<br>public abstract class DialPlanProvisionalEntity</span>
<span class="diffaddedchars" style="background-color:#ddfade;"> <br></span>
<span class="diffcontext"> extends ProvisionalEntity</span>
<span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;"><br></span>
<span class="diffcontext"> implements Initializable {<br><br> private Long entityId;<br> private boolean visible = true;<br> private int priority;<br><br> /**<br> * Not for direct instantiation - this constructor also serves as public<br> * constructor for hibernate, jax-ws etc. <br><br> */<br> @Deprecated<br> public DialPlanProvisionalEntity() {<br> this("(no name set)", "(no description set)");<br> }<br><br> /**<br> * @param name<br> * @param description<br> */<br> public DialPlanProvisionalEntity(String name, String description) { <br> creationDate = GregorianCalendar.getInstance(); // now<br> }<br><br></span>
<span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;"><br></span>
<span class="diffcontext"> @Id<br> @GeneratedValue(strategy = GenerationType.AUTO)<br> @Override<br> public Long getId() {<br> return entityId;<br> }<br><br> @Override<br> public void setId(Long ruleCollectionId) {<br> this.entityId = ruleCollectionId;<br> }<br><br> /**<br> * @return Returns the priority.<br> */<br> public int getPriority() {<br> return priority;<br> }<br><br> /**<br> * @param priority The priority to set.<br> */<br> public void setPriority(int priority) {<br> this.priority = priority;<br> }<br><br> @Override<br> public boolean equals(Object o) {<br> if (this == o) {<br> return true;<br> }<br> if (o == null || Hibernate.getClass(this) != Hibernate.getClass(o)) {<br> return false;<br> }<br><br> final ProvisionalEntity other = (ProvisionalEntity) o;<br> return MiscUtils.equalOrBothNull(this.getName(), other.getName());<br> }<br><br> @Override<br> public int hashCode() {<br> String name = this.getName();<br> return getClass().getName().hashCode() + 13 * name.hashCode();<br> }<br>}<br></span>
<span class="diffaddedchars" style="background-color:#ddfade;">{code}</span>
<span class="diffcontext"><br><br><br><br></span>
<span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;"><br></span>
<span class="diffcontext">The above mapping should use the "priority" field to the ordering.<br><br>SQL that is produced is :<br></span>
<span class="diffaddedchars" style="background-color:#ddfade;">{noformat} <br></span>
<span class="diffcontext">select criteria0_.RoutingRuleId as RoutingR1_1_, criteria0_.CriteriaComponentId as Criteria2_1_,<br> criteria0_.ListIndex as ListIndex1_,<br> routingcri1_.id as id73_0_,<br> routingcri1_.creationDate as creation3_73_0_,<br> routingcri1_.description as descript4_73_0_,<br> routingcri1_.lastModificationDate as lastModi5_73_0_,<br> routingcri1_.name as name73_0_,<br> routingcri1_.predefined as predefined73_0_,<br> routingcri1_.status as status73_0_,<br> routingcri1_.priority as priority73_0_,<br> routingcri1_.visible as visible73_0_,<br> routingcri1_.matcher_id as matcher25_73_0_,<br> routingcri1_.criterion_id as criterion27_73_0_,<br> routingcri1_.location_id aslocation26_73_0_,<br> routingcri1_.RoutingComponentType as RoutingC1_73_0_<br> from odp_rulecriteriajoin criteria0_<br> left outer join odp_routingcomponent as routingcri1_ on criteria0_.CriteriaComponentId=routingcri1_.id<br> where criteria0_.RoutingRuleId=1 order by odp_routingcomponent .priority asc<br></span>
<span class="diffaddedchars" style="background-color:#ddfade;">{noformat}</span>
<span class="diffcontext"><br><br>It is wrong since not the table alias is used in the order by clause, but the real table name.<br><br>Mysql fails with exception that odp_rulecriteriajoin.priority is unknown table.<br><br>Changing the query to include "order by criteria0_.priority asc" returns the correct result.</span>
</td>
</tr>
</table>
</td>
</tr>
</table>
</td>
</tr>
</table>
</td><!-- End #email-page -->
</tr>
<tr valign="top">
<td style="color:#505050;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:10px;line-height:14px;padding: 0 16px 16px 16px;text-align:center;">
This message is automatically generated by JIRA.<br />
If you think it was sent incorrectly, please contact your <a style='color:#6c797f;' href='https://hibernate.onjira.com/secure/ContactAdministrators!default.jspa'>JIRA administrators</a>.<br />
For more information on JIRA, see: <a style='color:#6c797f;' href='http://www.atlassian.com/software/jira'>http://www.atlassian.com/software/jira</a>
</td>
</tr>
</table><!-- End #email-wrap -->
</div><!-- End #email-body -->