<style>
/* Changing the layout to use less space for mobiles */
@media screen and (max-device-width: 480px), screen and (-webkit-min-device-pixel-ratio: 2) {
#email-body { min-width: 30em !important; }
#email-page { padding: 8px !important; }
#email-banner { padding: 8px 8px 0 8px !important; }
#email-avatar { margin: 1px 8px 8px 0 !important; padding: 0 !important; }
#email-fields { padding: 0 8px 8px 8px !important; }
#email-gutter { width: 0 !important; }
}
</style>
<div id="email-body">
<table id="email-wrap" align="center" border="0" cellpadding="0" cellspacing="0" style="background-color:#f0f0f0;color:#000000;width:100%;">
<tr valign="top">
<td id="email-page" style="padding:16px !important;">
<table align="center" border="0" cellpadding="0" cellspacing="0" style="background-color:#ffffff;border:1px solid #bbbbbb;color:#000000;width:100%;">
<tr valign="top">
<td bgcolor="#3e4c4e" style="background-color:#3e4c4e;color:#ffffff;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;line-height:1;"><img src="https://www.jboss.org/dms/hibernate/images/jira/jiraheader_hibernate.png" alt="" style="vertical-align:top;" /></td>
</tr><tr valign="top">
<td id="email-banner" style="padding:32px 32px 0 32px;">
<table align="left" border="0" cellpadding="0" cellspacing="0" width="100%" style="width:100%;">
<tr valign="top">
<td style="color:#505050;font-family:Arial,FreeSans,Helvetica,sans-serif;padding:0;">
<img id="email-avatar" src="https://hibernate.onjira.com/secure/useravatar?avatarId=10162" alt="" height="48" width="48" border="0" align="left" style="padding:0;margin: 0 16px 16px 0;" />
<div id="email-action" style="padding: 0 0 8px 0;font-size:12px;line-height:18px;">
<a class="user-hover" rel="mcbain4711" id="email_mcbain4711" href="https://hibernate.onjira.com/secure/ViewProfile.jspa?name=mcbain4711" style="color:#6c797f;">mcbain4711</a>
commented on <img src="https://hibernate.onjira.com/images/icons/bug.gif" height="16" width="16" border="0" align="absmiddle" alt="Bug"> <a style='color:#6c797f;text-decoration:none;' href='https://hibernate.onjira.com/browse/HHH-7403'>HHH-7403</a>
</div>
<div id="email-summary" style="font-size:16px;line-height:20px;padding:2px 0 16px 0;">
<a style='color:#6c797f;text-decoration:none;' href='https://hibernate.onjira.com/browse/HHH-7403'><strong>[JPA] Double insert with @OneToMany and CASCADE.ALL</strong></a>
</div>
</td>
</tr>
</table>
</td>
</tr>
<tr valign="top">
<td id="email-fields" style="padding:0 32px 32px 32px;">
<table border="0" cellpadding="0" cellspacing="0" style="padding:0;text-align:left;width:100%;" width="100%">
<tr valign="top">
<td id="email-gutter" style="width:64px;white-space:nowrap;"></td>
<td>
<table border="0" cellpadding="0" cellspacing="0" width="100%">
<tr valign="top">
<td colspan="2" style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 0 16px 0;width:100%;">
<div class="comment-block" style="background-color:#edf5ff;border:1px solid #dddddd;color:#000000;padding:12px;"><p>// cannot edit the bug description after creation!?</p>
<p>Simple 1:n relationship (1:Parent n:Child) inserts childs twice on addition and merge on parent. This happens only with CascadeType.ALL (CascadeType.ALL merge works).<br/>
For tests purpose only the Child.hashcode() and Child.equals() method throw an exception, to ensure that the a not invoked during the test.</p>
<p>Note: The tests uses the Spring 3.1.1 TransactionTemplate which only opens/closes/commits the session.</p>
<p>@Test<br/>
public void twiceInsert() {<br/>
final Integer parentId = transactionTemplate.execute(new TransactionCallback<Integer>() {<br/>
@Override<br/>
public Integer doInTransaction(TransactionStatus status) {
Parent p = new Parent();
// merge with 0 childs, and assign Parent.id
p = entityManager.merge(p);
return p.getId();
}<br/>
});</p>
<p> transactionTemplate.execute(new TransactionCallback<Object>() {<br/>
@Override<br/>
public ObjectdoInTransaction(TransactionStatus status) {
// reload parent wiht id, within THIS transaction
Parent p = entityManager.find(Parent.class, parentId);
final Child A = new Child();
A.setParent(p);
p.getChildren().add(A);
// Expectation: assign id to the child A
p = entityManager.merge(p);
return null;
}<br/>
});</p>
<p> transactionTemplate.execute(new TransactionCallback<Object>() {<br/>
@Override<br/>
public Object doInTransaction(TransactionStatus status) {
// again, load the Parent by id
Parent p = entityManager.find(Parent.class, parentId);
// FAILURE: 1 expected, but 2 childs in List
Assert.assertEquals(1, p.getChildren().size());
return 0;
}<br/>
});<br/>
}</p>
<p>@Entity<br/>
public class Parent {<br/>
@Id<br/>
@GeneratedValue(strategy = AUTO)<br/>
Integer id;</p>
<p> @OneToMany(mappedBy = "parent", cascade = {CascadeType.ALL})<br/>
List<Child> children = new ArrayList<Child>();</p>
<p> public Integer getId() {
return id;
}<br/>
<br/>
public List<Child> getChildren() {
return children;
}<br/>
<br/>
public void setChildren(List<Child> children) {
this.children = children;
}<br/>
}<br/>
<br/>
@Entity<br/>
public class Child {<br/>
@Id<br/>
@GeneratedValue(strategy = AUTO)<br/>
Integer id;<br/>
<br/>
@ManyToOne<br/>
Parent parent;<br/>
<br/>
public Integer getId() {
return id;
} }</p>
<p> public Parent getParent() {
return parent;
}</p>
<p> public void setParent(Parent parent) {
this.parent = parent;
}</p>
<p> @Override<br/>
public boolean equals(Object o) {
throw new UnsupportedOperationException();
}<br/>
<br/>
@Override<br/>
public int hashCode() {
throw new UnsupportedOperationException();
} }<br/>
}</p>
</div>
<div style="color:#505050;padding:4px 0 0 0;"> </div>
</td>
</tr>
</table>
</td>
</tr>
</table>
</td>
</tr>
</table>
</td><!-- End #email-page -->
</tr>
<tr valign="top">
<td style="color:#505050;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:10px;line-height:14px;padding: 0 16px 16px 16px;text-align:center;">
This message is automatically generated by JIRA.<br />
If you think it was sent incorrectly, please contact your <a style='color:#6c797f;' href='https://hibernate.onjira.com/secure/ContactAdministrators!default.jspa'>JIRA administrators</a>.<br />
For more information on JIRA, see: <a style='color:#6c797f;' href='http://www.atlassian.com/software/jira'>http://www.atlassian.com/software/jira</a>
</td>
</tr>
</table><!-- End #email-wrap -->
</div><!-- End #email-body -->