<style>
/* Changing the layout to use less space for mobiles */
@media screen and (max-device-width: 480px), screen and (-webkit-min-device-pixel-ratio: 2) {
#email-body { min-width: 30em !important; }
#email-page { padding: 8px !important; }
#email-banner { padding: 8px 8px 0 8px !important; }
#email-avatar { margin: 1px 8px 8px 0 !important; padding: 0 !important; }
#email-fields { padding: 0 8px 8px 8px !important; }
#email-gutter { width: 0 !important; }
}
</style>
<div id="email-body">
<table id="email-wrap" align="center" border="0" cellpadding="0" cellspacing="0" style="background-color:#f0f0f0;color:#000000;width:100%;">
<tr valign="top">
<td id="email-page" style="padding:16px !important;">
<table align="center" border="0" cellpadding="0" cellspacing="0" style="background-color:#ffffff;border:1px solid #bbbbbb;color:#000000;width:100%;">
<tr valign="top">
<td bgcolor="#3e4c4e" style="background-color:#3e4c4e;color:#ffffff;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;line-height:1;"><img src="https://www.jboss.org/dms/hibernate/images/jira/jiraheader_hibernate.png" alt="" style="vertical-align:top;" /></td>
</tr><tr valign="top">
<td id="email-banner" style="padding:32px 32px 0 32px;">
<table align="left" border="0" cellpadding="0" cellspacing="0" width="100%" style="width:100%;">
<tr valign="top">
<td style="color:#505050;font-family:Arial,FreeSans,Helvetica,sans-serif;padding:0;">
<img id="email-avatar" src="https://hibernate.onjira.com/secure/useravatar?ownerId=emmanuel&avatarId=10641" alt="" height="48" width="48" border="0" align="left" style="padding:0;margin: 0 16px 16px 0;" />
<div id="email-action" style="padding: 0 0 8px 0;font-size:12px;line-height:18px;">
<a class="user-hover" rel="emmanuel" id="email_emmanuel" href="https://hibernate.onjira.com/secure/ViewProfile.jspa?name=emmanuel" style="color:#6c797f;">Emmanuel Bernard</a>
commented on <img src="https://hibernate.onjira.com/images/icons/bug.gif" height="16" width="16" border="0" align="absmiddle" alt="Bug"> <a style='color:#6c797f;text-decoration:none;' href='https://hibernate.onjira.com/browse/OGM-208'>OGM-208</a>
</div>
<div id="email-summary" style="font-size:16px;line-height:20px;padding:2px 0 16px 0;">
<a style='color:#6c797f;text-decoration:none;' href='https://hibernate.onjira.com/browse/OGM-208'><strong>Create facility for OGM core and Dialects to receive custom metadata (annotation, programmatic) associated to entities, properties or associations</strong></a>
</div>
</td>
</tr>
</table>
</td>
</tr>
<tr valign="top">
<td id="email-fields" style="padding:0 32px 32px 32px;">
<table border="0" cellpadding="0" cellspacing="0" style="padding:0;text-align:left;width:100%;" width="100%">
<tr valign="top">
<td id="email-gutter" style="width:64px;white-space:nowrap;"></td>
<td>
<table border="0" cellpadding="0" cellspacing="0" width="100%">
<tr valign="top">
<td colspan="2" style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 0 16px 0;width:100%;">
<div class="comment-block" style="background-color:#edf5ff;border:1px solid #dddddd;color:#000000;padding:12px;"><p>Here is my next rev on options. I tried to make it more type-safe for the read API and simplify it at the same time.</p>
<h3><a name="Iterationnumber2"></a>Iteration number 2</h3>
<p>By merging the notion of `Option` and `OptionValueTupple` in a single element and using the Option class<br/>
as identifier for the option, we simplify the number of classes and make it more type safe when using it.<br/>
Options would then be identified by their class and possibly their unique identifier.</p>
<p>Note that we end up using classes instead of interfaces for the design. Is that a bad thing?</p>
<div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent">
<pre class="code-java"><span class="code-comment">// Provided by Hibernate OGM
</span> <span class="code-keyword">public</span> <span class="code-keyword">abstract</span> class Option<Type <span class="code-keyword">extends</span> Option<Type,Identifier>, Identifier> {
<span class="code-keyword">private</span> <span class="code-object">Class</span><Type> type;
<span class="code-keyword">public</span> Option(<span class="code-object">Class</span><Type> type) { <span class="code-keyword">this</span>.type = type; }
<span class="code-keyword">public</span> <span class="code-keyword">abstract</span> Identifier getOptionIdentifier();
<span class="code-keyword">public</span> <span class="code-object">Class</span><Type> getOptionType() { <span class="code-keyword">return</span> type; }
<span class="code-keyword">public</span> <span class="code-object">boolean</span> equals(<span class="code-object">Object</span> that) {
<span class="code-comment">//equals based on getOptionIdentifier() and getOptionType()
</span> }
<span class="code-keyword">public</span> <span class="code-object">int</span> hashCode() {
<span class="code-comment">//same as equals
</span> }
}
<span class="code-comment">// Provided by Hibernate OGM
</span> /**
* Specialized class used by options that defined only once.
* Most options should subclass <span class="code-keyword">this</span> class
*/
<span class="code-keyword">public</span> <span class="code-keyword">abstract</span> class UniqueOption<Type <span class="code-keyword">extends</span> UniqueOption<Type>>
<span class="code-keyword">extends</span> Option<Type,<span class="code-object">Object</span>> {
<span class="code-keyword">private</span> <span class="code-keyword">static</span> <span class="code-object">Object</span> IDENTITY = <span class="code-keyword">new</span> <span class="code-object">Object</span>();
<span class="code-keyword">public</span> UniqueOption(<span class="code-object">Class</span><Type> type) { <span class="code-keyword">super</span>(type); }
<span class="code-keyword">public</span> <span class="code-object">Object</span> getOptionIdentifier() { <span class="code-keyword">return</span> IDENTITY; }
}
<span class="code-comment">// Some examples
</span> <span class="code-comment">// Simple unique option
</span> <span class="code-keyword">public</span> class Quorum <span class="code-keyword">extends</span> UniqueOption<Quorum> {
<span class="code-keyword">public</span> Quorum(<span class="code-object">int</span> read, <span class="code-object">int</span> write) {
<span class="code-keyword">super</span>(Quorum.class);
<span class="code-keyword">this</span>.read = read;
<span class="code-keyword">this</span>.write = write;
}
<span class="code-keyword">public</span> void getRead(<span class="code-object">int</span> read) { <span class="code-keyword">this</span>.read = read; }
<span class="code-keyword">private</span> <span class="code-object">int</span> read;
<span class="code-keyword">public</span> void getWrite(<span class="code-object">int</span> write) { <span class="code-keyword">this</span>.write = write; }
<span class="code-keyword">private</span> <span class="code-object">int</span> write;
}
<span class="code-comment">// multiple options
</span> <span class="code-keyword">public</span> class NamedQuery <span class="code-keyword">extends</span> Option<NamedQuery, <span class="code-object">String</span>> {
<span class="code-keyword">public</span> NamedQuery(<span class="code-object">String</span> name, <span class="code-object">String</span> hql) {
<span class="code-keyword">super</span>(NamedQuery.class);
<span class="code-keyword">this</span>.name = name;
<span class="code-keyword">this</span>.hql = hql;
}
<span class="code-keyword">public</span> <span class="code-object">String</span> getOptionIdentifier() { <span class="code-keyword">return</span> name; }
<span class="code-keyword">public</span> <span class="code-object">String</span> getName() { <span class="code-keyword">return</span> name; }
<span class="code-keyword">private</span> <span class="code-object">String</span> name;
<span class="code-keyword">public</span> <span class="code-object">String</span> getHql() { <span class="code-keyword">return</span> hql; }
<span class="code-keyword">private</span> <span class="code-object">String</span> hql;
}
<span class="code-comment">//Usage in GridDialect
</span> <span class="code-comment">// getOption is only <span class="code-keyword">for</span> unique options
</span> Quorum quorum = context.inGlobalContext().getOption( Quorum );
<span class="code-comment">// <span class="code-keyword">for</span> multiple options, use getOptions
</span> Map<<span class="code-object">String</span>, NamedQuery> queries =
context.inEntityContext().getOptions(NamedQuery.class);
<span class="code-comment">//The next line does not compile as NamedQuery is not a UniqueOption
</span> <span class="code-comment">//NamedQuery query = context.inEntityContext().getOption(NamedQuery.class);
</span>
<span class="code-comment">//API of getOption(s)
</span> <span class="code-keyword">public</span> <O <span class="code-keyword">extends</span> UniqueOption<O>> O getOption(<span class="code-object">Class</span><O> optionType);
<span class="code-keyword">public</span> <I,O <span class="code-keyword">extends</span> Option<O,I>> Map<I,O> getOptions(<span class="code-object">Class</span><O> optionType);
<span class="code-comment">//TODO should it be a map, or is a `Set` sufficient?</span></pre>
</div></div>
<p>Please let me know if I'm mad <img class="emoticon" src="https://hibernate.onjira.com/images/icons/emoticons/smile.gif" height="20" width="20" align="absmiddle" alt="" border="0"/></p></div>
<div style="color:#505050;padding:4px 0 0 0;"> </div>
</td>
</tr>
</table>
</td>
</tr>
</table>
</td>
</tr>
</table>
</td><!-- End #email-page -->
</tr>
<tr valign="top">
<td style="color:#505050;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:10px;line-height:14px;padding: 0 16px 16px 16px;text-align:center;">
This message is automatically generated by JIRA.<br />
If you think it was sent incorrectly, please contact your <a style='color:#6c797f;' href='https://hibernate.onjira.com/secure/ContactAdministrators!default.jspa'>JIRA administrators</a>.<br />
For more information on JIRA, see: <a style='color:#6c797f;' href='http://www.atlassian.com/software/jira'>http://www.atlassian.com/software/jira</a>
</td>
</tr>
</table><!-- End #email-wrap -->
</div><!-- End #email-body -->