<style>
/* Changing the layout to use less space for mobiles */
@media screen and (max-device-width: 480px), screen and (-webkit-min-device-pixel-ratio: 2) {
#email-body { min-width: 30em !important; }
#email-page { padding: 8px !important; }
#email-banner { padding: 8px 8px 0 8px !important; }
#email-avatar { margin: 1px 8px 8px 0 !important; padding: 0 !important; }
#email-fields { padding: 0 8px 8px 8px !important; }
#email-gutter { width: 0 !important; }
}
</style>
<div id="email-body">
<table id="email-wrap" align="center" border="0" cellpadding="0" cellspacing="0" style="background-color:#f0f0f0;color:#000000;width:100%;">
<tr valign="top">
<td id="email-page" style="padding:16px !important;">
<table align="center" border="0" cellpadding="0" cellspacing="0" style="background-color:#ffffff;border:1px solid #bbbbbb;color:#000000;width:100%;">
<tr valign="top">
<td bgcolor="#3e4c4e" style="background-color:#3e4c4e;color:#ffffff;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;line-height:1;"><img src="https://www.jboss.org/dms/hibernate/images/jira/jiraheader_hibernate.png" alt="" style="vertical-align:top;" /></td>
</tr><tr valign="top">
<td id="email-banner" style="padding:32px 32px 0 32px;">
<table align="left" border="0" cellpadding="0" cellspacing="0" width="100%" style="width:100%;">
<tr valign="top">
<td style="color:#505050;font-family:Arial,FreeSans,Helvetica,sans-serif;padding:0;">
<img id="email-avatar" src="https://hibernate.onjira.com/secure/useravatar?ownerId=steve&avatarId=10346" alt="" height="48" width="48" border="0" align="left" style="padding:0;margin: 0 16px 16px 0;" />
<div id="email-action" style="padding: 0 0 8px 0;font-size:12px;line-height:18px;">
<a class="user-hover" rel="steve" id="email_steve" href="https://hibernate.onjira.com/secure/ViewProfile.jspa?name=steve" style="color:#6c797f;">Steve Ebersole</a>
commented on <img src="https://hibernate.onjira.com/images/icons/newfeature.gif" height="16" width="16" border="0" align="absmiddle" alt="New Feature"> <a style='color:#6c797f;text-decoration:none;' href='https://hibernate.onjira.com/browse/HHH-7527'>HHH-7527</a>
</div>
<div id="email-summary" style="font-size:16px;line-height:20px;padding:2px 0 16px 0;">
<a style='color:#6c797f;text-decoration:none;' href='https://hibernate.onjira.com/browse/HHH-7527'><strong>OSGI manifests for hibernate-orm</strong></a>
</div>
</td>
</tr>
</table>
</td>
</tr>
<tr valign="top">
<td id="email-fields" style="padding:0 32px 32px 32px;">
<table border="0" cellpadding="0" cellspacing="0" style="padding:0;text-align:left;width:100%;" width="100%">
<tr valign="top">
<td id="email-gutter" style="width:64px;white-space:nowrap;"></td>
<td>
<table border="0" cellpadding="0" cellspacing="0" width="100%">
<tr valign="top">
<td colspan="2" style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 0 16px 0;width:100%;">
<div class="comment-block" style="background-color:#edf5ff;border:1px solid #dddddd;color:#000000;padding:12px;"><p><a href="https://hibernate.onjira.com/secure/ViewProfile.jspa?name=neimeier" class="user-hover" rel="neimeier">Martin Neimeier</a> Thanks for that break down. Couple of thoughts...</p>
<p>1) As far as the concept of "OSGi services" and "OSGi service registry", I would like to investigate how that can be hooked into the Hibernate <tt>org.hibernate.service.Service</tt>/<tt>org.hibernate.service.ServiceRegistry</tt> infrastructure. <tt>org.hibernate.service.ServiceRegistry</tt> was designed to be extensible for cases just like this. However, what I clearly do not want is force feeding OSGi dependencies on applications not using OSGi.</p>
<p>2) As far as "extend<span class="error">[ing]</span> his classloading with a way to incorporate osgi service lookup", we have, I believe, all the necessary hooks already. We have a <tt>ClassLoaderService</tt> as I already mentioned. It may seem like a chicken-egg problem to have a service help in the loading of services, unitl you consider that Hibernate service registries are hierarchical. <tt>ClassLoaderService</tt> is part of what is called the "bootstrap service registry". Additionally <tt>ClassLoaderService</tt> has a hook already to account for discovery via <tt>java.util.ServiceLoader</tt>, though not in the standard way <tt>java.util.ServiceLoader</tt> normally works. It does significant management of the <tt>ClassLoader</tt> that <tt>java.util.ServiceLoader</tt> is allowed to use. For the details, have a look at <tt>org.hibernate.service.classloading.internal.ClassLoaderServiceImpl#loadJavaServices</tt> which specifically leverages the <tt>ClassLoader</tt> built in <tt>org.hibernate.service.classloading.internal.ClassLoaderServiceImpl#buildServiceLoaderClassLoader</tt>. Yet another option would be a "service registry service", aka, a service that acts as a registry for service instances. Using <tt>ConnectionProvider</tt> as a reference, we would have a <tt>ConnectionProviderRegistryService</tt> which would hold named references to available <tt>ConnectionProvider</tt> implementations.</p>
<p>3) As far as some of these "internal uses" by other jars, this is something we need to figure out in my humble opinion. The other purpose served by putting things into the internal package is to designate that it is not intended for consumption by code outside the set of Hibernate jars. Util stuff being the most common case here. We need these classes usable across all the jars. And no, hibernate-utils is <b>not</b> the answer <img class="emoticon" src="https://hibernate.onjira.com/images/icons/emoticons/wink.gif" height="20" width="20" align="absmiddle" alt="" border="0"/></p>
<p>4) Yes, we have not visited the package split on hibernate-envers yet, nor have we done it on certain hibernate-core packages yet (you and I discussed <tt>org.hibernate.loader</tt> specifically for example already). That should get done as part of this effort.</p></div>
<div style="color:#505050;padding:4px 0 0 0;"> </div>
</td>
</tr>
</table>
</td>
</tr>
</table>
</td>
</tr>
</table>
</td><!-- End #email-page -->
</tr>
<tr valign="top">
<td style="color:#505050;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:10px;line-height:14px;padding: 0 16px 16px 16px;text-align:center;">
This message is automatically generated by JIRA.<br />
If you think it was sent incorrectly, please contact your <a style='color:#6c797f;' href='https://hibernate.onjira.com/secure/ContactAdministrators!default.jspa'>JIRA administrators</a>.<br />
For more information on JIRA, see: <a style='color:#6c797f;' href='http://www.atlassian.com/software/jira'>http://www.atlassian.com/software/jira</a>
</td>
</tr>
</table><!-- End #email-wrap -->
</div><!-- End #email-body -->