<style>
/* Changing the layout to use less space for mobiles */
@media screen and (max-device-width: 480px), screen and (-webkit-min-device-pixel-ratio: 2) {
#email-body { min-width: 30em !important; }
#email-page { padding: 8px !important; }
#email-banner { padding: 8px 8px 0 8px !important; }
#email-avatar { margin: 1px 8px 8px 0 !important; padding: 0 !important; }
#email-fields { padding: 0 8px 8px 8px !important; }
#email-gutter { width: 0 !important; }
}
</style>
<div id="email-body">
<table id="email-wrap" align="center" border="0" cellpadding="0" cellspacing="0" style="background-color:#f0f0f0;color:#000000;width:100%;">
<tr valign="top">
<td id="email-page" style="padding:16px !important;">
<table align="center" border="0" cellpadding="0" cellspacing="0" style="background-color:#ffffff;border:1px solid #bbbbbb;color:#000000;width:100%;">
<tr valign="top">
<td bgcolor="#3e4c4e" style="background-color:#3e4c4e;color:#ffffff;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;line-height:1;"><img src="https://www.jboss.org/dms/hibernate/images/jira/jiraheader_hibernate.png" alt="" style="vertical-align:top;" /></td>
</tr><tr valign="top">
<td id="email-banner" style="padding:32px 32px 0 32px;">
<table align="left" border="0" cellpadding="0" cellspacing="0" width="100%" style="width:100%;">
<tr valign="top">
<td style="color:#505050;font-family:Arial,FreeSans,Helvetica,sans-serif;padding:0;">
<img id="email-avatar" src="https://hibernate.onjira.com/secure/useravatar?ownerId=emmanuel&avatarId=10641" alt="" height="48" width="48" border="0" align="left" style="padding:0;margin: 0 16px 16px 0;" />
<div id="email-action" style="padding: 0 0 8px 0;font-size:12px;line-height:18px;">
<a class="user-hover" rel="emmanuel" id="email_emmanuel" href="https://hibernate.onjira.com/secure/ViewProfile.jspa?name=emmanuel" style="color:#6c797f;">Emmanuel Bernard</a>
commented on <img src="https://hibernate.onjira.com/images/icons/bug.gif" height="16" width="16" border="0" align="absmiddle" alt="Bug"> <a style='color:#6c797f;text-decoration:none;' href='https://hibernate.onjira.com/browse/OGM-230'>OGM-230</a>
</div>
<div id="email-summary" style="font-size:16px;line-height:20px;padding:2px 0 16px 0;">
<a style='color:#6c797f;text-decoration:none;' href='https://hibernate.onjira.com/browse/OGM-230'><strong>OGM em.find() is not polymorphic</strong></a>
</div>
</td>
</tr>
</table>
</td>
</tr>
<tr valign="top">
<td id="email-fields" style="padding:0 32px 32px 32px;">
<table border="0" cellpadding="0" cellspacing="0" style="padding:0;text-align:left;width:100%;" width="100%">
<tr valign="top">
<td id="email-gutter" style="width:64px;white-space:nowrap;"></td>
<td>
<table border="0" cellpadding="0" cellspacing="0" width="100%">
<tr valign="top">
<td colspan="2" style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 0 16px 0;width:100%;">
<div class="comment-block" style="background-color:#edf5ff;border:1px solid #dddddd;color:#000000;padding:12px;"><p>I've investigated what you saw in InheritanceTest. It's due to the fact that you were not testing the right thing.<br/>
Your test basically calls result.toString() which triggers the object loading. After that, javassist's proxy simply delegates toString() to an actual strawberry object.</p>
<p>Here is a proper test</p>
<div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent">
<pre class="code-java">diff --git a/hibernate-entitymanager/src/test/java/org/hibernate/jpa/test/inheritance/InheritanceTest.java b/hibernate-entitymanager/src/test
index 5e8c8a9..e746da1 100644
--- a/hibernate-entitymanager/src/test/java/org/hibernate/jpa/test/inheritance/InheritanceTest.java
+++ b/hibernate-entitymanager/src/test/java/org/hibernate/jpa/test/inheritance/InheritanceTest.java
@@ -30,6 +30,8 @@ <span class="code-keyword">import</span> org.junit.Test;
<span class="code-keyword">import</span> org.hibernate.jpa.test.BaseEntityManagerFunctionalTestCase;
<span class="code-keyword">import</span> <span class="code-keyword">static</span> org.junit.Assert.assertNotNull;
+<span class="code-keyword">import</span> <span class="code-keyword">static</span> org.junit.Assert.assertThat;
+<span class="code-keyword">import</span> <span class="code-keyword">static</span> org.junit.Assert.assertTrue;
/**
* @author Emmanuel Bernard
@@ -51,9 +53,12 @@ <span class="code-keyword">public</span> class InheritanceTest <span class="code-keyword">extends</span> BaseEntityManagerFunctionalTestCase {
Strawberry result1 = firstSession.find(Strawberry.class, newId);
assertNotNull( result1 );
+ firstSession.clear();
<span class="code-comment">// 2.
</span>- Strawberry result2 = (Strawberry) firstSession.find(Fruit.class, newId);
+ Fruit result2 = firstSession.getReference(Fruit.class, newId);
<span class="code-object">System</span>.out.println(<span class="code-quote">"2. result is:"</span> + result2);
+ <span class="code-object">System</span>.out.println(<span class="code-quote">"2. result is:"</span> + result2.getClass().getName());
+ assertTrue( result2 <span class="code-keyword">instanceof</span> Strawberry );
firstSession.getTransaction().commit();
firstSession.close();</pre>
</div></div>
<p>The test fails right after printing</p>
<div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent">
<pre class="code-java">2. result is:org.hibernate.jpa.test.inheritance.Strawberry@73947cfc
2. result is:org.hibernate.jpa.test.inheritance.Fruit_$$_javassist_50</pre>
</div></div>
<p>I should have spotted that quicker but I'm a bit rusty on those subjects.</p>
<p>So yes only keep the find test and remove the getReference test from the pull request.</p></div>
<div style="color:#505050;padding:4px 0 0 0;"> </div>
</td>
</tr>
</table>
</td>
</tr>
</table>
</td>
</tr>
</table>
</td><!-- End #email-page -->
</tr>
<tr valign="top">
<td style="color:#505050;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:10px;line-height:14px;padding: 0 16px 16px 16px;text-align:center;">
This message is automatically generated by JIRA.<br />
If you think it was sent incorrectly, please contact your JIRA administrators<br />
For more information on JIRA, see: <a style='color:#6c797f;' href='http://www.atlassian.com/software/jira'>http://www.atlassian.com/software/jira</a>
</td>
</tr>
</table><!-- End #email-wrap -->
</div><!-- End #email-body -->