<style>
/* Changing the layout to use less space for mobiles */
@media screen and (max-device-width: 480px), screen and (-webkit-min-device-pixel-ratio: 2) {
#email-body { min-width: 30em !important; }
#email-page { padding: 8px !important; }
#email-banner { padding: 8px 8px 0 8px !important; }
#email-avatar { margin: 1px 8px 8px 0 !important; padding: 0 !important; }
#email-fields { padding: 0 8px 8px 8px !important; }
#email-gutter { width: 0 !important; }
}
</style>
<div id="email-body">
<table id="email-wrap" align="center" border="0" cellpadding="0" cellspacing="0" style="background-color:#f0f0f0;color:#000000;width:100%;">
<tr valign="top">
<td id="email-page" style="padding:16px !important;">
<table align="center" border="0" cellpadding="0" cellspacing="0" style="background-color:#ffffff;border:1px solid #bbbbbb;color:#000000;width:100%;">
<tr valign="top">
<td bgcolor="#3e4c4e" style="background-color:#3e4c4e;color:#ffffff;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;line-height:1;"><img src="https://www.jboss.org/dms/hibernate/images/jira/jiraheader_hibernate.png" alt="" style="vertical-align:top;" /></td>
</tr><tr valign="top">
<td id="email-banner" style="padding:32px 32px 0 32px;">
<table align="left" border="0" cellpadding="0" cellspacing="0" width="100%" style="width:100%;">
<tr valign="top">
<td style="color:#505050;font-family:Arial,FreeSans,Helvetica,sans-serif;padding:0;">
<img id="email-avatar" src="https://hibernate.onjira.com/secure/useravatar?ownerId=brmeyer&avatarId=11140" alt="" height="48" width="48" border="0" align="left" style="padding:0;margin: 0 16px 16px 0;" />
<div id="email-action" style="padding: 0 0 8px 0;font-size:12px;line-height:18px;">
<a class="user-hover" rel="brmeyer" id="email_brmeyer" href="https://hibernate.onjira.com/secure/ViewProfile.jspa?name=brmeyer" style="color:#6c797f;">Brett Meyer</a>
updated <img src="https://hibernate.onjira.com/images/icons/bug.gif" height="16" width="16" border="0" align="absmiddle" alt="Bug"> <a style='color:#6c797f;text-decoration:none;' href='https://hibernate.onjira.com/browse/HHH-6655'>HHH-6655</a>
</div>
<div id="email-summary" style="font-size:16px;line-height:20px;padding:2px 0 16px 0;">
<a style='color:#6c797f;text-decoration:none;' href='https://hibernate.onjira.com/browse/HHH-6655'><strong>trim function on DB2 is broken</strong></a>
</div>
</td>
</tr>
</table>
</td>
</tr>
<tr valign="top">
<td id="email-fields" style="padding:0 32px 32px 32px;">
<table border="0" cellpadding="0" cellspacing="0" style="padding:0;text-align:left;width:100%;" width="100%">
<tr valign="top">
<td id="email-gutter" style="width:64px;white-space:nowrap;"></td>
<td>
<table border="0" cellpadding="0" cellspacing="0" width="100%">
<tr valign="top">
<td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 10px 10px 0;white-space:nowrap;">
<strong style="font-weight:normal;color:#505050;">Change By:</strong>
</td>
<td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 0 10px 0;width:100%;">
<a class="user-hover" rel="brmeyer" id="email_brmeyer" href="https://hibernate.onjira.com/secure/ViewProfile.jspa?name=brmeyer" style="color:#6c797f;">Brett Meyer</a>
(25/Sep/12 9:13 AM)
</td>
</tr>
<tr valign="top">
<td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 10px 10px 0;white-space:nowrap;">
<strong style="font-weight:normal;color:#505050;">Description:</strong>
</td>
<td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 0 10px 0;width:100%;">
<span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;">For DB2 a warning message is generated by TempateRenderer which is not seen</span>
<span class="diffaddedchars" style="background-color:#ddfade;">DB2Dialect uses AnsiTrimEmulationFunction</span>
<span class="diffcontext"> for</span>
<span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;"> other databases:<br>WARN: HHH00174:Function template anticipated 3 arguments, but 2 arguments encountered<br><br>see test _org</span>
<span class="diffaddedchars" style="background-color:#ddfade;"> the "trim" function</span>
<span class="diffcontext">.</span>
<span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;">hibernate.ejb.criteria.CriteriaCompilingTest#testTrim_ for more details<br>Also</span>
<span class="diffaddedchars" style="background-color:#ddfade;"> This attempts to use</span>
<span class="diffcontext"> the</span>
<span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;"> query created is different in case of DB2</span>
<span class="diffaddedchars" style="background-color:#ddfade;"> following SQL</span>
<span class="diffcontext">:<br></span>
<span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;">Hibernate:</span>
<span class="diffaddedchars" style="background-color:#ddfade;"><br></span>
<span class="diffcontext"> select replace(replace(ltrim(rtrim(replace(replace(customer0_.NAME,' ','${space}$'),?,' '))),' ',?),'${space}$',' ')</span>
<span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;"> as col_0_0_ from CUSTOMER_TABLE customer0_ where customer0_.NAME=? fetch first 2 rows only</span>
<span class="diffcontext"><br><br></span>
<span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;">and finally it</span>
<span class="diffaddedchars" style="background-color:#ddfade;">This</span>
<span class="diffcontext"> fails</span>
<span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;"> because of above warning</span>
<span class="diffaddedchars" style="background-color:#ddfade;"> w/ the following error</span>
<span class="diffcontext">:<br><br></span>
<span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;">javax</span>
<span class="diffaddedchars" style="background-color:#ddfade;">com</span>
<span class="diffcontext">.</span>
<span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;">persistence</span>
<span class="diffaddedchars" style="background-color:#ddfade;">ibm</span>
<span class="diffcontext">.</span>
<span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;">PersistenceException: org</span>
<span class="diffaddedchars" style="background-color:#ddfade;">db2</span>
<span class="diffcontext">.</span>
<span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;">hibernate</span>
<span class="diffaddedchars" style="background-color:#ddfade;">jcc</span>
<span class="diffcontext">.</span>
<span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;">exception</span>
<span class="diffaddedchars" style="background-color:#ddfade;">am</span>
<span class="diffcontext">.</span>
<span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;">SQLGrammarException</span>
<span class="diffaddedchars" style="background-color:#ddfade;">SqlSyntaxErrorException</span>
<span class="diffcontext">: DB2 SQL Error: SQLCODE=-</span>
<span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;">313</span>
<span class="diffaddedchars" style="background-color:#ddfade;">418</span>
<span class="diffcontext">, SQLSTATE=</span>
<span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;">07001</span>
<span class="diffaddedchars" style="background-color:#ddfade;">42610, SQLERRMC=null, DRIVER=4.13.80</span>
<span class="diffcontext"><br><br></span>
<span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;">For other DBs same code generates following query and test passes</span>
<span class="diffaddedchars" style="background-color:#ddfade;">Allowing the dialect to use the "trim(?1 ?2 ?3 ?4)" instead results in</span>
<span class="diffcontext">:<br><br></span>
<span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;">Hibernate:</span>
<span class="diffcontext"> select trim(BOTH ? from customer0_.NAME) as col_0_0_ from CUSTOMER_TABLE customer0_ where customer0_.NAME=?</span>
<span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;"> limit ?</span>
<span class="diffaddedchars" style="background-color:#ddfade;"><br><br>com.ibm.db2.jcc.am.SqlSyntaxErrorException: DB2 SQL Error: SQLCODE=-123, SQLSTATE=42601, SQLERRMC=strip-or-trim-char;SYSIBM.TRIM, DRIVER=4.13.80<br><br>Neither method is attempting to use a literal.<br><br>The 418 error code page states that:<br><br>{quote}<br>The statement cannot be executed because a parameter marker has been used in an invalid way.<br><br>Parameter markers cannot be used:<br><br> In the SELECT list as the sole argument of a scalar function.<br> In a concatenation operation.<br> In the string expression of an EXECUTE IMMEDIATE SQL statement.<br> In a result-expression in any CASE expression when all the other result-expressions are either NULL or untyped parameter markers.<br> In a key-expression of an index definition.<br><br>Untyped parameter markers cannot be used:<br><br> As an argument to an XMLQUERY function.<br> As an argument to an XMLEXISTS predicate.<br>{quote}<br><br>Unless I'm missing something, the queries appear to be meeting the rules.</span>
</td>
</tr>
<tr valign="top">
<td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 10px 10px 0;white-space:nowrap;">
<strong style="font-weight:normal;color:#505050;">Affects Version/s:</strong>
</td>
<td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 0 10px 0;width:100%;">
<span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;">4.0.0.CR2</span>
</td>
</tr>
<tr valign="top">
<td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 10px 10px 0;white-space:nowrap;">
<strong style="font-weight:normal;color:#505050;">Affects Version/s:</strong>
</td>
<td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 0 10px 0;width:100%;">
<span class="diffaddedchars" style="background-color:#ddfade;">4.1.7</span>
</td>
</tr>
</table>
</td>
</tr>
</table>
</td>
</tr>
</table>
</td><!-- End #email-page -->
</tr>
<tr valign="top">
<td style="color:#505050;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:10px;line-height:14px;padding: 0 16px 16px 16px;text-align:center;">
This message is automatically generated by JIRA.<br />
If you think it was sent incorrectly, please contact your JIRA administrators<br />
For more information on JIRA, see: <a style='color:#6c797f;' href='http://www.atlassian.com/software/jira'>http://www.atlassian.com/software/jira</a>
</td>
</tr>
</table><!-- End #email-wrap -->
</div><!-- End #email-body -->