<style>
/* Changing the layout to use less space for mobiles */
@media screen and (max-device-width: 480px), screen and (-webkit-min-device-pixel-ratio: 2) {
#email-body { min-width: 30em !important; }
#email-page { padding: 8px !important; }
#email-banner { padding: 8px 8px 0 8px !important; }
#email-avatar { margin: 1px 8px 8px 0 !important; padding: 0 !important; }
#email-fields { padding: 0 8px 8px 8px !important; }
#email-gutter { width: 0 !important; }
}
</style>
<div id="email-body">
<table id="email-wrap" align="center" border="0" cellpadding="0" cellspacing="0" style="background-color:#f0f0f0;color:#000000;width:100%;">
<tr valign="top">
<td id="email-page" style="padding:16px !important;">
<table align="center" border="0" cellpadding="0" cellspacing="0" style="background-color:#ffffff;border:1px solid #bbbbbb;color:#000000;width:100%;">
<tr valign="top">
<td bgcolor="#3e4c4e" style="background-color:#3e4c4e;color:#ffffff;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;line-height:1;"><img src="https://www.jboss.org/dms/hibernate/images/jira/jiraheader_hibernate.png" alt="" style="vertical-align:top;" /></td>
</tr><tr valign="top">
<td id="email-banner" style="padding:32px 32px 0 32px;">
<table align="left" border="0" cellpadding="0" cellspacing="0" width="100%" style="width:100%;">
<tr valign="top">
<td style="color:#505050;font-family:Arial,FreeSans,Helvetica,sans-serif;padding:0;">
<img id="email-avatar" src="https://hibernate.onjira.com/secure/useravatar?ownerId=hardy.ferentschik&avatarId=10342" alt="" height="48" width="48" border="0" align="left" style="padding:0;margin: 0 16px 16px 0;" />
<div id="email-action" style="padding: 0 0 8px 0;font-size:12px;line-height:18px;">
<a class="user-hover" rel="hardy.ferentschik" id="email_hardy.ferentschik" href="https://hibernate.onjira.com/secure/ViewProfile.jspa?name=hardy.ferentschik" style="color:#6c797f;">Hardy Ferentschik</a>
commented on <img src="https://hibernate.onjira.com/images/icons/task.gif" height="16" width="16" border="0" align="absmiddle" alt="Task"> <a style='color:#6c797f;text-decoration:none;' href='https://hibernate.onjira.com/browse/BVAL-307'>BVAL-307</a>
</div>
<div id="email-summary" style="font-size:16px;line-height:20px;padding:2px 0 16px 0;">
<a style='color:#6c797f;text-decoration:none;' href='https://hibernate.onjira.com/browse/BVAL-307'><strong>Decide how CDI and Bean Validation is integrated</strong></a>
</div>
</td>
</tr>
</table>
</td>
</tr>
<tr valign="top">
<td id="email-fields" style="padding:0 32px 32px 32px;">
<table border="0" cellpadding="0" cellspacing="0" style="padding:0;text-align:left;width:100%;" width="100%">
<tr valign="top">
<td id="email-gutter" style="width:64px;white-space:nowrap;"></td>
<td>
<table border="0" cellpadding="0" cellspacing="0" width="100%">
<tr valign="top">
<td colspan="2" style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 0 16px 0;width:100%;">
<div class="comment-block" style="background-color:#edf5ff;border:1px solid #dddddd;color:#000000;padding:12px;"><blockquote>
<p>Let's take a small step back.<br/>
Today a user can enforce a specific BV provider by setting it in the XML file. If not is selected, then Validation.buildDefaultValidatorFactory() pick one "randomly".<br/>
When booting BV programmatically, you can also specify which provider you want via Validation.byProvider(HibernateValidatorConfiguration.class).<br/>
...</p></blockquote>
<p>This is actually a good point. On the other hand, is adding the extension jar of a certain provider to your container/app not equivalent to <em>Validation.byProvider(ProviderClassOfProviderWhoseExtensionIAdded.class)</em>. So in the case of HV. If you are adding hibernate-validator-cdi you are adding the <em>ValidatorFactory</em> and <em>Validator</em> of Hibernate Validator. IMO it does not make sense to add <em>hibernate-validator-cdi</em> and then bootstrap a different provider. If you want another provider you should add its cdi extension. </p>
<p>I can see where you are coming from with your Valiation API point of view, but I think from a CDI point of view my argument holds as well.</p>
<blockquote>
<p> if we want a qualifier, why not have a BV generic one @FromProvider(HibernateValidatorConfiguration.class). The only drawback I see is that this qualifier belongs in Bean Validation and that require us to depend on CDI which might be a no go after the discussions with the JavaFX team.</p></blockquote>
<p>-1 for adding a dependency to CDI </p>
<blockquote>
<p> I find it a bit annoying as a user when I define a provider in the XML descriptor but I also have to use a qualifier in my injection points.</p></blockquote>
<p>Why? It is a different programming model. XML is great for standalone apps, but once I work with a CDI container other abstractions and APIs come into play. In fact as a pure CDI user I would even expect that I have to use a qualifier and would be confused by the need of fiddling w/ <em>valiation.xml</em>. </p>
<blockquote>
<p> What happens for an existing BV 1.0 application today? AFAIK, injection of the "default" BV provider is done. I don't think we can break that behavior.</p></blockquote>
<p>I don't think we do (unless of course they always added a second BV provider to their app which was different to the one provided by the container and happens to implement <em>Extension</em>. Very unlikely.</p></div>
<div style="color:#505050;padding:4px 0 0 0;"> </div>
</td>
</tr>
</table>
</td>
</tr>
</table>
</td>
</tr>
</table>
</td><!-- End #email-page -->
</tr>
<tr valign="top">
<td style="color:#505050;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:10px;line-height:14px;padding: 0 16px 16px 16px;text-align:center;">
This message is automatically generated by JIRA.<br />
If you think it was sent incorrectly, please contact your JIRA administrators<br />
For more information on JIRA, see: <a style='color:#6c797f;' href='http://www.atlassian.com/software/jira'>http://www.atlassian.com/software/jira</a>
</td>
</tr>
</table><!-- End #email-wrap -->
</div><!-- End #email-body -->