<style>
/* Changing the layout to use less space for mobiles */
@media screen and (max-device-width: 480px), screen and (-webkit-min-device-pixel-ratio: 2) {
    #email-body { min-width: 30em !important; }
    #email-page { padding: 8px !important; }
    #email-banner { padding: 8px 8px 0 8px !important; }
    #email-avatar { margin: 1px 8px 8px 0 !important; padding: 0 !important; }
    #email-fields { padding: 0 8px 8px 8px !important; }
    #email-gutter { width: 0 !important; }
}
</style>
<div id="email-body">
<table id="email-wrap" align="center" border="0" cellpadding="0" cellspacing="0" style="background-color:#f0f0f0;color:#000000;width:100%;">
    <tr valign="top">
        <td id="email-page" style="padding:16px !important;">
            <table align="center" border="0" cellpadding="0" cellspacing="0" style="background-color:#ffffff;border:1px solid #bbbbbb;color:#000000;width:100%;">
                <tr valign="top">
                    <td bgcolor="#3e4c4e" style="background-color:#3e4c4e;color:#ffffff;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;line-height:1;"><img src="https://www.jboss.org/dms/hibernate/images/jira/jiraheader_hibernate.png" alt="" style="vertical-align:top;" /></td>
                </tr><tr valign="top">
    <td id="email-banner" style="padding:32px 32px 0 32px;">
        
                
        
        
            <table align="left" border="0" cellpadding="0" cellspacing="0" width="100%" style="width:100%;">
    <tr valign="top">
        <td style="color:#505050;font-family:Arial,FreeSans,Helvetica,sans-serif;padding:0;">
                                        <img id="email-avatar" src="https://hibernate.onjira.com/secure/useravatar?avatarId=10162" alt="" height="48" width="48" border="0" align="left" style="padding:0;margin: 0 16px 16px 0;" />
                        <div id="email-action" style="padding: 0 0 8px 0;font-size:12px;line-height:18px;">
                                    <a class="user-hover" rel="netangel" id="email_netangel" href="https://hibernate.onjira.com/secure/ViewProfile.jspa?name=netangel" style="color:#6c797f;">Anthony Ogier</a>
     created <img src="https://hibernate.onjira.com/images/icons/bug.gif" height="16" width="16" border="0" align="absmiddle" alt="Bug"> <a style='color:#6c797f;text-decoration:none;' href='https://hibernate.onjira.com/browse/HHH-7752'>HHH-7752</a>
            </div>
                        <div id="email-summary" style="font-size:16px;line-height:20px;padding:2px 0 16px 0;">
                <a style='color:#6c797f;text-decoration:none;' href='https://hibernate.onjira.com/browse/HHH-7752'><strong>SQLServer2008Dialect doesn&#39;t support @Formula field containing subselects</strong></a>
            </div>
                    </td>
    </tr>
</table>
    </td>
</tr>
<tr valign="top">
    <td id="email-fields" style="padding:0 32px 32px 32px;">
        <table border="0" cellpadding="0" cellspacing="0" style="padding:0;text-align:left;width:100%;" width="100%">
            <tr valign="top">
                <td id="email-gutter" style="width:64px;white-space:nowrap;"></td>
                <td>
                    <table border="0" cellpadding="0" cellspacing="0" width="100%">
                        <tr valign="top">
    <td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 10px 10px 0;white-space:nowrap;">
        <strong style="font-weight:normal;color:#505050;">Issue Type:</strong>
    </td>
    <td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 0 10px 0;width:100%;">
                <img src="https://hibernate.onjira.com/images/icons/bug.gif" height="16" width="16" border="0" align="absmiddle" alt="Bug">        Bug
    </td>
</tr>                        <tr valign="top">
    <td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 10px 10px 0;white-space:nowrap;">
        <strong style="font-weight:normal;color:#505050;">Affects Versions:</strong>
    </td>
    <td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 0 10px 0;width:100%;">
                    4.0.1            </td>
</tr>
                        <tr valign="top">
    <td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 10px 10px 0;white-space:nowrap;">
        <strong style="font-weight:normal;color:#505050;">Assignee:</strong>
    </td>
    <td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 0 10px 0;width:100%;">
                    Unassigned            </td>
</tr>                                                <tr valign="top">
    <td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 10px 10px 0;white-space:nowrap;">
        <strong style="font-weight:normal;color:#505050;">Components:</strong>
    </td>
    <td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 0 10px 0;width:100%;">
                    core            </td>
</tr>
                        <tr valign="top">
    <td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 10px 10px 0;white-space:nowrap;">
        <strong style="font-weight:normal;color:#505050;">Created:</strong>
    </td>
    <td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 0 10px 0;width:100%;">
        04/Nov/12 4:49 PM
    </td>
</tr>                        <tr valign="top">
    <td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 10px 10px 0;white-space:nowrap;">
        <strong style="font-weight:normal;color:#505050;">Description:</strong>
    </td>
    <td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 0 10px 0;width:100%;">
        <p style='margin-top:0;margin-bottom:10px;'>Here is my entity :</p>

<div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent">
<pre class="code-java">@Entity
@Table(name = <span class="code-quote">"FOLDER"</span>)
<span class="code-keyword">public</span> class Folder {
  @Id
  @Column(name = <span class="code-quote">"ID"</span>)
  @GeneratedValue(strategy=GenerationType.IDENTITY)
  <span class="code-keyword">private</span> <span class="code-object">Integer</span> id;

  @Formula(<span class="code-quote">"(select <span class="code-keyword">case</span> when c.TYPE = 'M' then isnull(c.FIRSTNAME + ' ', '') + c.LASTNAME end"</span> +
    <span class="code-quote">" from CONTACT c where c.ID_FOLDER = ID"</span>)
  <span class="code-keyword">private</span> <span class="code-object">String</span> masterContact

  <span class="code-comment">// getters / setters
</span>}</pre>
</div></div>

<p style='margin-top:0;margin-bottom:10px;'>Using SQLServer2008Dialect, if I want that EJBQL query executed : "select count(distinct folder) from Folder folder", the generated query is :</p>
<div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent">
<pre class="code-java">WITH query AS (select
         count(folder0_.id) as col_0_0_,
     ROW_NUMBER() OVER (
 ORDER BY
     CURRENT_TIMESTAMP) as __hibernate_row_nr__ 
 from
     folder folder0_ 
 group by
     count(folder0_.id)) SELECT
     * 
 FROM
     query 
 WHERE
     __hibernate_row_nr__ &gt;= ? 
         AND __hibernate_row_nr__ &lt; ?</pre>
</div></div>
<p style='margin-top:0;margin-bottom:10px;'>which will throw the SQLServerException #144 "Cannot use an aggregate or a subquery in an expression used for the group by list of a GROUP BY clause".</p>

<p style='margin-top:0;margin-bottom:10px;'>So I applied the patched proposed by <a href="https://hibernate.onjira.com/browse/HHH-6627" title="SQLServer2008Dialect Bad Query">HHH-6627</a>.</p>

<p style='margin-top:0;margin-bottom:10px;'>It then generates the good count method.</p>

<p style='margin-top:0;margin-bottom:10px;'>I now wanted to execute the following EJBQL query : "select folder from Folder folder order by folder.id" and here is the SQL query generated :</p>
<div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent">
<pre class="code-java">WITH query AS (select
         folder0_.id as id1_62_,
             (select
                 <span class="code-keyword">case</span> 
                    when c.TYPE = 'M' then isnull(c.FIRSTNAME + ' ', '') + c.LASTNAME
                 end,
                 ROW_NUMBER() OVER (
             order by
                 folder0_.id asc) as __hibernate_row_nr__ 
             from
                 contact c
             where
                 c.id_folder = folder0_.id) as formula0_ 
         from
             folder folder0_ ) SELECT
     * 
 FROM
     query 
 WHERE
     __hibernate_row_nr__ &gt;= ? 
         AND __hibernate_row_nr__ &lt; ?</pre>
</div></div>

<p style='margin-top:0;margin-bottom:10px;'>Which will throw the SQLServerException #116 "Only one expression can be specified in the select list when the subquery is not introduced with EXISTS."</p>

<p style='margin-top:0;margin-bottom:10px;'>So I implemented myself the "insertRowNumberFunction" by replacing the <tt>sql.indexOf( FROM );</tt> with <tt>sql.lastIndexOf( FROM );</tt>.</p>

<p style='margin-top:0;margin-bottom:10px;'>Now the SQL generated query was :</p>
<div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent">
<pre class="code-java">WITH query AS (select
         folder0_.id as id1_62_,
             (select
                 <span class="code-keyword">case</span> 
                    when c.TYPE = 'M' then isnull(c.FIRSTNAME + ' ', '') + c.LASTNAME
                 end
             from
                 contact c
             where
                 c.id_folder = folder0_.id) as formula0_,
             ROW_NUMBER() OVER (
         order by
             folder0_.id asc) as __hibernate_row_nr__ 
         from
             folder folder0_ ) SELECT
     * 
 FROM
     query 
 WHERE
     __hibernate_row_nr__ &gt;= ? 
         AND __hibernate_row_nr__ &lt; ?</pre>
</div></div>

<p style='margin-top:0;margin-bottom:10px;'>But the results are not necessarily ordered by folder.id ...</p>

<p style='margin-top:0;margin-bottom:10px;'>I'm on SQLServer 2008 R2.</p>
    </td>
</tr>
                                                                                                <tr valign="top">
    <td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 10px 10px 0;white-space:nowrap;">
        <strong style="font-weight:normal;color:#505050;">Project:</strong>
    </td>
    <td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 0 10px 0;width:100%;">
        <a style="color:#6c797f;" href="https://hibernate.onjira.com/browse/HHH">Hibernate ORM</a>
    </td>
</tr>                                                <tr valign="top">
    <td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 10px 10px 0;white-space:nowrap;">
        <strong style="font-weight:normal;color:#505050;">Priority:</strong>
    </td>
    <td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 0 10px 0;width:100%;">
                <img src="https://hibernate.onjira.com/images/icons/priority_blocker.gif" height="16" width="16" border="0" align="absmiddle" alt="Blocker">        Blocker
    </td>
</tr>                        <tr valign="top">
    <td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 10px 10px 0;white-space:nowrap;">
        <strong style="font-weight:normal;color:#505050;">Reporter:</strong>
    </td>
    <td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 0 10px 0;width:100%;">
                                        <a class="user-hover" rel="netangel" id="email_netangel" href="https://hibernate.onjira.com/secure/ViewProfile.jspa?name=netangel" style="color:#6c797f;">Anthony Ogier</a>
                </td>
</tr>                                                    
    
    
                        </table>
                </td>
            </tr>
        </table>
    </td>
</tr>













            </table>
        </td><!-- End #email-page -->
    </tr>
    <tr valign="top">
        <td style="color:#505050;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:10px;line-height:14px;padding: 0 16px 16px 16px;text-align:center;">
            This message is automatically generated by JIRA.<br />
            If you think it was sent incorrectly, please contact your JIRA administrators<br />
            For more information on JIRA, see: <a style='color:#6c797f;' href='http://www.atlassian.com/software/jira'>http://www.atlassian.com/software/jira</a>
        </td>
    </tr>
</table><!-- End #email-wrap -->
</div><!-- End #email-body -->