<style>
/* Changing the layout to use less space for mobiles */
@media screen and (max-device-width: 480px), screen and (-webkit-min-device-pixel-ratio: 2) {
#email-body { min-width: 30em !important; }
#email-page { padding: 8px !important; }
#email-banner { padding: 8px 8px 0 8px !important; }
#email-avatar { margin: 1px 8px 8px 0 !important; padding: 0 !important; }
#email-fields { padding: 0 8px 8px 8px !important; }
#email-gutter { width: 0 !important; }
}
</style>
<div id="email-body">
<table id="email-wrap" align="center" border="0" cellpadding="0" cellspacing="0" style="background-color:#f0f0f0;color:#000000;width:100%;">
<tr valign="top">
<td id="email-page" style="padding:16px !important;">
<table align="center" border="0" cellpadding="0" cellspacing="0" style="background-color:#ffffff;border:1px solid #bbbbbb;color:#000000;width:100%;">
<tr valign="top">
<td bgcolor="#3e4c4e" style="background-color:#3e4c4e;color:#ffffff;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;line-height:1;"><img src="https://www.jboss.org/dms/hibernate/images/jira/jiraheader_hibernate.png" alt="" style="vertical-align:top;" /></td>
</tr><tr valign="top">
<td id="email-banner" style="padding:32px 32px 0 32px;">
<table align="left" border="0" cellpadding="0" cellspacing="0" width="100%" style="width:100%;">
<tr valign="top">
<td style="color:#505050;font-family:Arial,FreeSans,Helvetica,sans-serif;padding:0;">
<img id="email-avatar" src="https://hibernate.onjira.com/secure/useravatar?ownerId=steve&avatarId=10346" alt="" height="48" width="48" border="0" align="left" style="padding:0;margin: 0 16px 16px 0;" />
<div id="email-action" style="padding: 0 0 8px 0;font-size:12px;line-height:18px;">
<a class="user-hover" rel="steve" id="email_steve" href="https://hibernate.onjira.com/secure/ViewProfile.jspa?name=steve" style="color:#6c797f;">Steve Ebersole</a>
commented on <img src="https://hibernate.onjira.com/images/icons/bug.gif" height="16" width="16" border="0" align="absmiddle" alt="Bug"> <a style='color:#6c797f;text-decoration:none;' href='https://hibernate.onjira.com/browse/HHH-7816'>HHH-7816</a>
</div>
<div id="email-summary" style="font-size:16px;line-height:20px;padding:2px 0 16px 0;">
<a style='color:#6c797f;text-decoration:none;' href='https://hibernate.onjira.com/browse/HHH-7816'><strong>DDL opertations will incorrectly commit current transaction on Oracle XA</strong></a>
</div>
</td>
</tr>
</table>
</td>
</tr>
<tr valign="top">
<td id="email-fields" style="padding:0 32px 32px 32px;">
<table border="0" cellpadding="0" cellspacing="0" style="padding:0;text-align:left;width:100%;" width="100%">
<tr valign="top">
<td id="email-gutter" style="width:64px;white-space:nowrap;"></td>
<td>
<table border="0" cellpadding="0" cellspacing="0" width="100%">
<tr valign="top">
<td colspan="2" style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 0 16px 0;width:100%;">
<div class="comment-block" style="background-color:#edf5ff;border:1px solid #dddddd;color:#000000;padding:12px;"><p>Ok, it is as I suspected. The Oracle XA driver just returns bad information here. For <tt>DatabaseMetaData#supportsDataDefinitionInTransaction()</tt> it returns <tt>true</tt>. Yet clearly it does not.</p>
<p>I have developed a work around and am working on a fix to allow dialects to override know bad <tt>DatabaseMetaData#supportsDataDefinitionInTransaction()</tt> implementations much like we have with <tt>org.hibernate.dialect.Dialect#performTemporaryTableDDLInIsolation</tt> for handling bad <tt>DatabaseMetaData#dataDefinitionCausesTransactionCommit()</tt> implementations.</p>
<p>The work-around is to specify a custom <tt>org.hibernate.hql.spi.MultiTableBulkIdStrategy</tt> implementation using the <tt>hibernate.hql.bulk_id_strategy</tt> setting:</p>
<div class="code panel" style="border-style: solid;border-width: 1px;"><div class="codeHeader panelHeader" style="border-bottom-width: 1px;border-bottom-style: solid;"><b>CustomBulkIdDelegate.java</b></div><div class="codeContent panelContent">
<pre class="code-java"><span class="code-keyword">import</span> java.sql.Connection;
<span class="code-keyword">import</span> java.sql.SQLWarning;
<span class="code-keyword">import</span> java.sql.Statement;
<span class="code-keyword">import</span> org.jboss.logging.Logger;
<span class="code-keyword">import</span> org.hibernate.engine.jdbc.spi.JdbcServices;
<span class="code-keyword">import</span> org.hibernate.engine.jdbc.spi.SqlExceptionHelper;
<span class="code-keyword">import</span> org.hibernate.engine.spi.SessionImplementor;
<span class="code-keyword">import</span> org.hibernate.hql.spi.TemporaryTableBulkIdStrategy;
<span class="code-keyword">import</span> org.hibernate.internal.CoreMessageLogger;
<span class="code-keyword">import</span> org.hibernate.jdbc.AbstractWork;
<span class="code-keyword">import</span> org.hibernate.persister.entity.Queryable;
/**
* @author Steve Ebersole
*/
<span class="code-keyword">public</span> class CustomBulkIdDelegate <span class="code-keyword">extends</span> TemporaryTableBulkIdStrategy {
<span class="code-keyword">private</span> <span class="code-keyword">static</span> <span class="code-keyword">final</span> CoreMessageLogger log = Logger.getMessageLogger( CoreMessageLogger.class, CustomBulkIdDelegate.class.getName() );
@Override
<span class="code-keyword">protected</span> void createTempTable(Queryable persister, SessionImplementor session) {
TemporaryTableCreationWork work = <span class="code-keyword">new</span> TemporaryTableCreationWork( persister );
<span class="code-comment">// here we always want to (a) create the tables in isolation and (b) <span class="code-keyword">do</span> not start a <span class="code-keyword">new</span> transaction <span class="code-keyword">for</span> the creation
</span> session.getTransactionCoordinator()
.getTransaction()
.createIsolationDelegate()
.delegateWork( work, <span class="code-keyword">false</span> );
}
<span class="code-comment">// todo make these <span class="code-keyword">protected</span> on TemporaryTableBulkIdStrategy ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
</span>
<span class="code-keyword">private</span> <span class="code-keyword">static</span> SqlExceptionHelper.WarningHandler CREATION_WARNING_HANDLER = <span class="code-keyword">new</span> SqlExceptionHelper.WarningHandlerLoggingSupport() {
<span class="code-keyword">public</span> <span class="code-object">boolean</span> doProcess() {
<span class="code-keyword">return</span> log.isDebugEnabled();
}
<span class="code-keyword">public</span> void prepare(SQLWarning warning) {
log.warningsCreatingTempTable( warning );
}
@Override
<span class="code-keyword">protected</span> void logWarning(<span class="code-object">String</span> description, <span class="code-object">String</span> message) {
log.debug( description );
log.debug( message );
}
};
<span class="code-keyword">private</span> <span class="code-keyword">static</span> class TemporaryTableCreationWork <span class="code-keyword">extends</span> AbstractWork {
<span class="code-keyword">private</span> <span class="code-keyword">final</span> Queryable persister;
<span class="code-keyword">private</span> TemporaryTableCreationWork(Queryable persister) {
<span class="code-keyword">this</span>.persister = persister;
}
@Override
<span class="code-keyword">public</span> void execute(Connection connection) {
<span class="code-keyword">try</span> {
Statement statement = connection.createStatement();
<span class="code-keyword">try</span> {
statement.executeUpdate( persister.getTemporaryIdTableDDL() );
persister.getFactory()
.getServiceRegistry()
.getService( JdbcServices.class )
.getSqlExceptionHelper()
.handleAndClearWarnings( statement, CREATION_WARNING_HANDLER );
}
<span class="code-keyword">finally</span> {
<span class="code-keyword">try</span> {
statement.close();
}
<span class="code-keyword">catch</span>( Throwable ignore ) {
<span class="code-comment">// ignore
</span> }
}
}
<span class="code-keyword">catch</span>( Exception e ) {
log.debug( <span class="code-quote">"unable to create temporary id table ["</span> + e.getMessage() + <span class="code-quote">"]"</span> );
}
}
}
}</pre>
</div></div></div>
<div style="color:#505050;padding:4px 0 0 0;"> </div>
</td>
</tr>
</table>
</td>
</tr>
</table>
</td>
</tr>
</table>
</td><!-- End #email-page -->
</tr>
<tr valign="top">
<td style="color:#505050;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:10px;line-height:14px;padding: 0 16px 16px 16px;text-align:center;">
This message is automatically generated by JIRA.<br />
If you think it was sent incorrectly, please contact your JIRA administrators<br />
For more information on JIRA, see: <a style='color:#6c797f;' href='http://www.atlassian.com/software/jira'>http://www.atlassian.com/software/jira</a>
</td>
</tr>
</table><!-- End #email-wrap -->
</div><!-- End #email-body -->