<style>
/* Changing the layout to use less space for mobiles */
@media screen and (max-device-width: 480px), screen and (-webkit-min-device-pixel-ratio: 2) {
    #email-body { min-width: 30em !important; }
    #email-page { padding: 8px !important; }
    #email-banner { padding: 8px 8px 0 8px !important; }
    #email-avatar { margin: 1px 8px 8px 0 !important; padding: 0 !important; }
    #email-fields { padding: 0 8px 8px 8px !important; }
    #email-gutter { width: 0 !important; }
}
</style>
<div id="email-body">
<table id="email-wrap" align="center" border="0" cellpadding="0" cellspacing="0" style="background-color:#f0f0f0;color:#000000;width:100%;">
    <tr valign="top">
        <td id="email-page" style="padding:16px !important;">
            <table align="center" border="0" cellpadding="0" cellspacing="0" style="background-color:#ffffff;border:1px solid #bbbbbb;color:#000000;width:100%;">
                <tr valign="top">
                    <td bgcolor="#3e4c4e" style="background-color:#3e4c4e;color:#ffffff;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;line-height:1;"><img src="https://www.jboss.org/dms/hibernate/images/jira/jiraheader_hibernate.png" alt="" style="vertical-align:top;" /></td>
                </tr><tr valign="top">
    <td id="email-banner" style="padding:32px 32px 0 32px;">

                
        
        
            <table align="left" border="0" cellpadding="0" cellspacing="0" width="100%" style="width:100%;">
    <tr valign="top">
        <td style="color:#505050;font-family:Arial,FreeSans,Helvetica,sans-serif;padding:0;">
                                        <img id="email-avatar" src="https://hibernate.onjira.com/secure/useravatar?ownerId=steve&avatarId=10346" alt="" height="48" width="48" border="0" align="left" style="padding:0;margin: 0 16px 16px 0;" />
                        <div id="email-action" style="padding: 0 0 8px 0;font-size:12px;line-height:18px;">
                                    <a class="user-hover" rel="steve" id="email_steve" href="https://hibernate.onjira.com/secure/ViewProfile.jspa?name=steve" style="color:#6c797f;">Steve Ebersole</a>
     updated <img src="https://hibernate.onjira.com/images/icons/bug.gif" height="16" width="16" border="0" align="absmiddle" alt="Bug"> <a style='color:#6c797f;text-decoration:none;' href='https://hibernate.onjira.com/browse/HHH-7233'>HHH-7233</a>
            </div>
                        <div id="email-summary" style="font-size:16px;line-height:20px;padding:2px 0 16px 0;">
                <a style='color:#6c797f;text-decoration:none;' href='https://hibernate.onjira.com/browse/HHH-7233'><strong>unmuck EntityManager#getSingleResult wrt auto-setting of max results</strong></a>
            </div>
                    </td>
    </tr>
</table>
        
    </td>
</tr>
<tr valign="top">
    <td id="email-fields" style="padding:0 32px 32px 32px;">
        <table border="0" cellpadding="0" cellspacing="0" style="padding:0;text-align:left;width:100%;" width="100%">
            <tr valign="top">
                <td id="email-gutter" style="width:64px;white-space:nowrap;"></td>
                <td>
                    <table border="0" cellpadding="0" cellspacing="0" width="100%">
                                                    <tr valign="top">
        <td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 10px 10px 0;white-space:nowrap;">
            <strong style="font-weight:normal;color:#505050;">Change By:</strong>
        </td>
        <td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 0 10px 0;width:100%;">
                                                <a class="user-hover" rel="steve" id="email_steve" href="https://hibernate.onjira.com/secure/ViewProfile.jspa?name=steve" style="color:#6c797f;">Steve Ebersole</a>
                            (26/Nov/12 10:08 AM)
        </td>
    </tr>
            <tr valign="top">
        <td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 10px 10px 0;white-space:nowrap;">
            <strong style="font-weight:normal;color:#505050;">Description:</strong>
        </td>
        <td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 0 10px 0;width:100%;">
                                    <span class="diffcontext">I&nbsp;have&nbsp;a&nbsp;DAO&nbsp;method&nbsp;that&nbsp;does&nbsp;the&nbsp;following:<br><br></span>
<span class="diffaddedchars" style="background-color:#ddfade;">{code:borderStyle=solid}<br></span>
<span class="diffcontext">return&nbsp;this.createNamedQuery(&nbsp;&quot;systemTasks(machineId,status,maxExecuteTimestamp)&quot;&nbsp;)<br>&nbsp;&nbsp;.setParameter(&nbsp;&quot;machineId&quot;,&nbsp;machineId&nbsp;)<br>&nbsp;&nbsp;.setParameter(&nbsp;&quot;status&quot;,&nbsp;status&nbsp;)<br>&nbsp;&nbsp;.setParameter(&nbsp;&quot;maxExecuteTimestamp&quot;,&nbsp;maxExecuteTimestamp&nbsp;)<br>&nbsp;&nbsp;.setLockMode(&nbsp;LockModeType.PESSIMISTIC_WRITE&nbsp;)<br>&nbsp;&nbsp;.setMaxResults(&nbsp;1&nbsp;)<br>&nbsp;&nbsp;.getSingleResult();<br></span>
<span class="diffaddedchars" style="background-color:#ddfade;">{code}</span>
<span class="diffcontext"><br></span>
<span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;">HQL</span>
<span class="diffaddedchars" style="background-color:#ddfade;"><br>The&nbsp;JPQL</span>
<span class="diffcontext">&nbsp;is:<br><br></span>
<span class="diffaddedchars" style="background-color:#ddfade;">{code:borderStyle=solid}<br></span>
<span class="diffcontext">&nbsp;&nbsp;select&nbsp;st&nbsp;from&nbsp;SystemTask&nbsp;st<br>&nbsp;&nbsp;where&nbsp;st.machineId&nbsp;=&nbsp;:machineId&nbsp;and&nbsp;st.status&nbsp;=&nbsp;:status<br>&nbsp;&nbsp;&nbsp;&nbsp;and&nbsp;st.executeTimestamp&nbsp;&lt;=&nbsp;:maxExecuteTimestamp<br>&nbsp;&nbsp;order&nbsp;by&nbsp;st.executeTimestamp<br></span>
<span class="diffaddedchars" style="background-color:#ddfade;">{code}</span>
<span class="diffcontext"><br></span>
<span class="diffaddedchars" style="background-color:#ddfade;"><br></span>
<span class="diffcontext">Hibernate&nbsp;generates&nbsp;the&nbsp;following&nbsp;SQL:<br><br></span>
<span class="diffaddedchars" style="background-color:#ddfade;">{code:borderStyle=solid}<br></span>
<span class="diffcontext">&nbsp;&nbsp;select&nbsp;*&nbsp;from&nbsp;(<br>&nbsp;&nbsp;&nbsp;&nbsp;select&nbsp;[column&nbsp;list]<br>&nbsp;&nbsp;&nbsp;&nbsp;from&nbsp;jaseadm.system_task&nbsp;systemtask0_<br>&nbsp;&nbsp;&nbsp;&nbsp;where&nbsp;systemtask0_.machine_id=?<br>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;and&nbsp;systemtask0_.task_status_id=?<br>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;and&nbsp;systemtask0_.execute_timestamp&lt;=?<br>&nbsp;&nbsp;&nbsp;&nbsp;order&nbsp;by&nbsp;systemtask0_.execute_timestamp&nbsp;)<br>&nbsp;&nbsp;where&nbsp;rownum&nbsp;&lt;=&nbsp;?&nbsp;for&nbsp;update<br></span>
<span class="diffaddedchars" style="background-color:#ddfade;">{code}</span>
<span class="diffcontext"><br></span>
<span class="diffaddedchars" style="background-color:#ddfade;"><br></span>
<span class="diffcontext">Which&nbsp;fails&nbsp;with:<br><br></span>
<span class="diffaddedchars" style="background-color:#ddfade;">{noformat}<br></span>
<span class="diffcontext">&nbsp;&nbsp;ORA-02014:&nbsp;cannot&nbsp;select&nbsp;FOR&nbsp;UPDATE&nbsp;from&nbsp;view&nbsp;with&nbsp;DISTINCT,&nbsp;GROUP&nbsp;BY,&nbsp;etc.<br></span>
<span class="diffaddedchars" style="background-color:#ddfade;">{noformat}</span>
<span class="diffcontext"><br></span>
<span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;">This&nbsp;means&nbsp;that:</span>
<span class="diffcontext"><br></span>
<span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;">&nbsp;&nbsp;-&nbsp;setLockMode&nbsp;(pessimistic)&nbsp;can&#39;t&nbsp;be&nbsp;used&nbsp;with&nbsp;setMaxResults</span>
<span class="diffaddedchars" style="background-color:#ddfade;">The&nbsp;problem&nbsp;is&nbsp;automatic&nbsp;setting&nbsp;of&nbsp;max&nbsp;results</span>
<span class="diffcontext">&nbsp;when</span>
<span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;">&nbsp;there&#39;s&nbsp;an&nbsp;order&nbsp;specified,&nbsp;because&nbsp;the&nbsp;oracle&nbsp;dialect&nbsp;only&nbsp;accommodates&nbsp;the&nbsp;&quot;for&nbsp;update&quot;&nbsp;clause&nbsp;and&nbsp;doesn&#39;t&nbsp;do&nbsp;anything&nbsp;with&nbsp;an&nbsp;&quot;order&nbsp;by&quot;&nbsp;clause.<br>&nbsp;&nbsp;-&nbsp;setLockMode&nbsp;(pessimistic)&nbsp;can&#39;t&nbsp;be&nbsp;used&nbsp;with</span>
<span class="diffaddedchars" style="background-color:#ddfade;">&nbsp;{{</span>
<span class="diffcontext">&nbsp;getSingleResult</span>
<span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;">&nbsp;when&nbsp;there&#39;s&nbsp;an&nbsp;order&nbsp;by&nbsp;specified,&nbsp;because&nbsp;Hibernate&nbsp;indiscriminately&nbsp;calls&nbsp;setMaxResults&nbsp;in&nbsp;org.hibernate.ejb.getSingleResult()</span>
<span class="diffaddedchars" style="background-color:#ddfade;">}}&nbsp;is&nbsp;called</span>
<span class="diffcontext">:<br><br></span>
<span class="diffaddedchars" style="background-color:#ddfade;">{code:borderStyle=solid}<br></span>
<span class="diffcontext">&nbsp;&nbsp;boolean&nbsp;mucked&nbsp;=&nbsp;false;<br>&nbsp;&nbsp;//&nbsp;IMPL&nbsp;NOTE&nbsp;:&nbsp;the&nbsp;mucking&nbsp;with&nbsp;max&nbsp;results&nbsp;here&nbsp;is&nbsp;attempting&nbsp;to&nbsp;help&nbsp;the&nbsp;user&nbsp;from&nbsp;shooting&nbsp;themselves<br>&nbsp;&nbsp;//                in&nbsp;the&nbsp;foot&nbsp;in&nbsp;the&nbsp;case&nbsp;where&nbsp;they&nbsp;have&nbsp;a&nbsp;large&nbsp;query&nbsp;by&nbsp;limiting&nbsp;the&nbsp;query&nbsp;results&nbsp;to&nbsp;2&nbsp;max<br>&nbsp;&nbsp;//&nbsp;&nbsp;&nbsp;&nbsp;SQLQuery&nbsp;cannot&nbsp;be&nbsp;safely&nbsp;paginated,&nbsp;leaving&nbsp;the&nbsp;user&#39;s&nbsp;choice&nbsp;here.<br>&nbsp;&nbsp;if&nbsp;(&nbsp;getSpecifiedMaxResults()&nbsp;!=&nbsp;1&nbsp;&amp;&amp;<br>&nbsp;&nbsp;&nbsp;&nbsp;!&nbsp;(&nbsp;SQLQuery.class.isAssignableFrom(&nbsp;query.getClass()&nbsp;)&nbsp;)&nbsp;)&nbsp;{<br>&nbsp;&nbsp;&nbsp;&nbsp;mucked&nbsp;=&nbsp;true;<br>&nbsp;&nbsp;&nbsp;&nbsp;query.setMaxResults(&nbsp;2&nbsp;);&nbsp;//avoid&nbsp;OOME&nbsp;if&nbsp;the&nbsp;list&nbsp;is&nbsp;huge<br>&nbsp;&nbsp;}<br>&nbsp;&nbsp;List&lt;X&gt;&nbsp;result&nbsp;=&nbsp;query.list();<br>&nbsp;&nbsp;if&nbsp;(&nbsp;mucked&nbsp;)&nbsp;{<br>&nbsp;&nbsp;&nbsp;&nbsp;query.setMaxResults(&nbsp;getSpecifiedMaxResults()&nbsp;);<br>&nbsp;&nbsp;}<br></span>
<span class="diffaddedchars" style="background-color:#ddfade;">{code}</span>
<span class="diffcontext"><br></span>
<span class="diffaddedchars" style="background-color:#ddfade;"><br></span>
<span class="diffcontext">Honestly&nbsp;I&nbsp;would&nbsp;prefer&nbsp;the&nbsp;OOM&nbsp;prevention&nbsp;stuff&nbsp;be&nbsp;removed,&nbsp;or&nbsp;configurable&nbsp;through&nbsp;the&nbsp;session&nbsp;factory,&nbsp;as&nbsp;I&nbsp;end&nbsp;up&nbsp;with&nbsp;a&nbsp;lot&nbsp;of&nbsp;natural&nbsp;key&nbsp;queries&nbsp;that&nbsp;look&nbsp;like:<br><br>&nbsp;&nbsp;select&nbsp;*&nbsp;from&nbsp;(&nbsp;...&nbsp;)&nbsp;where&nbsp;rownum&nbsp;&lt;=&nbsp;1<br><br>When&nbsp;I&nbsp;haven&#39;t&nbsp;called&nbsp;setMaxResults&nbsp;myself.<br><br></span>
<span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;">Related&nbsp;to&nbsp;HHH-3298&nbsp;and&nbsp;HHH-1168&nbsp;(7&nbsp;years&nbsp;unresolved).&nbsp;&nbsp;Note&nbsp;that&nbsp;unlike&nbsp;HH-1168,&nbsp;this&nbsp;breaks&nbsp;getSingleResult&nbsp;as&nbsp;well&nbsp;due&nbsp;to&nbsp;the&nbsp;whole&nbsp;&quot;mucked&quot;&nbsp;code.<br></span>

        </td>
    </tr>
                            </table>
                </td>
            </tr>
        </table>
    </td>
</tr>













            </table>
        </td><!-- End #email-page -->
    </tr>
    <tr valign="top">
        <td style="color:#505050;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:10px;line-height:14px;padding: 0 16px 16px 16px;text-align:center;">
            This message is automatically generated by JIRA.<br />
            If you think it was sent incorrectly, please contact your JIRA administrators<br />
            For more information on JIRA, see: <a style='color:#6c797f;' href='http://www.atlassian.com/software/jira'>http://www.atlassian.com/software/jira</a>
        </td>
    </tr>
</table><!-- End #email-wrap -->
</div><!-- End #email-body -->