<style>
/* Changing the layout to use less space for mobiles */
@media screen and (max-device-width: 480px), screen and (-webkit-min-device-pixel-ratio: 2) {
#email-body { min-width: 30em !important; }
#email-page { padding: 8px !important; }
#email-banner { padding: 8px 8px 0 8px !important; }
#email-avatar { margin: 1px 8px 8px 0 !important; padding: 0 !important; }
#email-fields { padding: 0 8px 8px 8px !important; }
#email-gutter { width: 0 !important; }
}
</style>
<div id="email-body">
<table id="email-wrap" align="center" border="0" cellpadding="0" cellspacing="0" style="background-color:#f0f0f0;color:#000000;width:100%;">
<tr valign="top">
<td id="email-page" style="padding:16px !important;">
<table align="center" border="0" cellpadding="0" cellspacing="0" style="background-color:#ffffff;border:1px solid #bbbbbb;color:#000000;width:100%;">
<tr valign="top">
<td bgcolor="#3e4c4e" style="background-color:#3e4c4e;color:#ffffff;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;line-height:1;"><img src="https://www.jboss.org/dms/hibernate/images/jira/jiraheader_hibernate.png" alt="" style="vertical-align:top;" /></td>
</tr><tr valign="top">
<td id="email-banner" style="padding:32px 32px 0 32px;">
<table align="left" border="0" cellpadding="0" cellspacing="0" width="100%" style="width:100%;">
<tr valign="top">
<td style="color:#505050;font-family:Arial,FreeSans,Helvetica,sans-serif;padding:0;">
<img id="email-avatar" src="https://hibernate.onjira.com/secure/useravatar?ownerId=gunnar.morling&avatarId=10345" alt="" height="48" width="48" border="0" align="left" style="padding:0;margin: 0 16px 16px 0;" />
<div id="email-action" style="padding: 0 0 8px 0;font-size:12px;line-height:18px;">
<a class="user-hover" rel="gunnar.morling" id="email_gunnar.morling" href="https://hibernate.onjira.com/secure/ViewProfile.jspa?name=gunnar.morling" style="color:#6c797f;">Gunnar Morling</a>
updated <img src="https://hibernate.onjira.com/images/icons/bug.gif" height="16" width="16" border="0" align="absmiddle" alt="Bug"> <a style='color:#6c797f;text-decoration:none;' href='https://hibernate.onjira.com/browse/HV-681'>HV-681</a>
</div>
<div id="email-summary" style="font-size:16px;line-height:20px;padding:2px 0 16px 0;">
<a style='color:#6c797f;text-decoration:none;' href='https://hibernate.onjira.com/browse/HV-681'><strong>Throw IllegalArgumentExceptions in ExecutableValidator methods as described in API</strong></a>
</div>
</td>
</tr>
</table>
</td>
</tr>
<tr valign="top">
<td id="email-fields" style="padding:0 32px 32px 32px;">
<table border="0" cellpadding="0" cellspacing="0" style="padding:0;text-align:left;width:100%;" width="100%">
<tr valign="top">
<td id="email-gutter" style="width:64px;white-space:nowrap;"></td>
<td>
<table border="0" cellpadding="0" cellspacing="0" width="100%">
<tr valign="top">
<td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 10px 10px 0;white-space:nowrap;">
<strong style="font-weight:normal;color:#505050;">Change By:</strong>
</td>
<td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 0 10px 0;width:100%;">
<a class="user-hover" rel="gunnar.morling" id="email_gunnar.morling" href="https://hibernate.onjira.com/secure/ViewProfile.jspa?name=gunnar.morling" style="color:#6c797f;">Gunnar Morling</a>
(23/Jan/13 5:16 AM)
</td>
</tr>
<tr valign="top">
<td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 10px 10px 0;white-space:nowrap;">
<strong style="font-weight:normal;color:#505050;">Description:</strong>
</td>
<td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 0 10px 0;width:100%;">
<span class="diffcontext">As per the API documentation an {{IllegalArgumentException}} is to be thrown in case {{null}} is passed to</span>
<span class="diffaddedchars" style="background-color:#ddfade;"> the methods of</span>
<span class="diffcontext"> {{ExecutableValidator</span>
<span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;">#</span>
<span class="diffaddedchars" style="background-color:#ddfade;">}}. That's not consistently implemented in the RI currently:<br><br>* {{</span>
<span class="diffcontext">validateParameters()}}</span>
<span class="diffaddedchars" style="background-color:#ddfade;"> and {{validateConstructorParameters()}} accept {{null }}</span>
<span class="diffcontext"> for the _parameterValues_ parameter</span>
<span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;">, but the RI accepts that</span>
<span class="diffcontext"> and</span>
<span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;"> returns</span>
<span class="diffaddedchars" style="background-color:#ddfade;"> return</span>
<span class="diffcontext"> an empty set of violations</span>
<span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;">.</span>
<span class="diffcontext"><br></span>
<span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;"><br>Also an</span>
<span class="diffaddedchars" style="background-color:#ddfade;">* All methods throw a</span>
<span class="diffcontext"> {{</span>
<span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;">IllegalArgumentException</span>
<span class="diffaddedchars" style="background-color:#ddfade;">NullPointerException</span>
<span class="diffcontext">}}</span>
<span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;"> (</span>
<span class="diffcontext">instead of</span>
<span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;"> a</span>
<span class="diffaddedchars" style="background-color:#ddfade;"> an</span>
<span class="diffcontext"> {{</span>
<span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;">NullPointerException</span>
<span class="diffaddedchars" style="background-color:#ddfade;">IllegalArgumentException</span>
<span class="diffcontext">}}</span>
<span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;"> as of today) needs to be thrown</span>
<span class="diffcontext"> when passing {{null}} as single validation group ({{(Class<?>)null}}).<br></span>
<span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;"><br>Also an</span>
<span class="diffaddedchars" style="background-color:#ddfade;">*</span>
<span class="diffcontext"> {{</span>
<span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;">IllegalArgumentException</span>
<span class="diffaddedchars" style="background-color:#ddfade;">validateConstructorReturnValue()</span>
<span class="diffcontext">}}</span>
<span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;"> needs to be thrown when passing</span>
<span class="diffaddedchars" style="background-color:#ddfade;"> accepts</span>
<span class="diffcontext"> {{null}}</span>
<span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;"> to</span>
<span class="diffaddedchars" style="background-color:#ddfade;"> for the _createdObject_ parameter.<br>*</span>
<span class="diffcontext"> {{</span>
<span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;">ExecutableValidator#validateConstructorReturnValue</span>
<span class="diffaddedchars" style="background-color:#ddfade;">validateReturnValue</span>
<span class="diffcontext">()}}</span>
<span class="diffaddedchars" style="background-color:#ddfade;"> accepts {{null}}</span>
<span class="diffcontext"> for the</span>
<span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;"> _createdObject_</span>
<span class="diffaddedchars" style="background-color:#ddfade;"> _object_</span>
<span class="diffcontext"> parameter.<br><br>See {{ValidateParametersTest}} etc.</span>
</td>
</tr>
</table>
</td>
</tr>
</table>
</td>
</tr>
</table>
</td><!-- End #email-page -->
</tr>
<tr valign="top">
<td style="color:#505050;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:10px;line-height:14px;padding: 0 16px 16px 16px;text-align:center;">
This message is automatically generated by JIRA.<br />
If you think it was sent incorrectly, please contact your JIRA administrators<br />
For more information on JIRA, see: <a style='color:#6c797f;' href='http://www.atlassian.com/software/jira'>http://www.atlassian.com/software/jira</a>
</td>
</tr>
</table><!-- End #email-wrap -->
</div><!-- End #email-body -->