<style>
/* Changing the layout to use less space for mobiles */
@media screen and (max-device-width: 480px), screen and (-webkit-min-device-pixel-ratio: 2) {
#email-body { min-width: 30em !important; }
#email-page { padding: 8px !important; }
#email-banner { padding: 8px 8px 0 8px !important; }
#email-avatar { margin: 1px 8px 8px 0 !important; padding: 0 !important; }
#email-fields { padding: 0 8px 8px 8px !important; }
#email-gutter { width: 0 !important; }
}
</style>
<div id="email-body">
<table id="email-wrap" align="center" border="0" cellpadding="0" cellspacing="0" style="background-color:#f0f0f0;color:#000000;width:100%;">
<tr valign="top">
<td id="email-page" style="padding:16px !important;">
<table align="center" border="0" cellpadding="0" cellspacing="0" style="background-color:#ffffff;border:1px solid #bbbbbb;color:#000000;width:100%;">
<tr valign="top">
<td bgcolor="#3e4c4e" style="background-color:#3e4c4e;color:#ffffff;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;line-height:1;"><img src="https://www.jboss.org/dms/hibernate/images/jira/jiraheader_hibernate.png" alt="" style="vertical-align:top;" /></td>
</tr><tr valign="top">
<td id="email-banner" style="padding:32px 32px 0 32px;">
<table align="left" border="0" cellpadding="0" cellspacing="0" width="100%" style="width:100%;">
<tr valign="top">
<td style="color:#505050;font-family:Arial,FreeSans,Helvetica,sans-serif;padding:0;">
<img id="email-avatar" src="https://hibernate.onjira.com/secure/useravatar?ownerId=sanne&avatarId=11144" alt="" height="48" width="48" border="0" align="left" style="padding:0;margin: 0 16px 16px 0;" />
<div id="email-action" style="padding: 0 0 8px 0;font-size:12px;line-height:18px;">
<a class="user-hover" rel="sanne" id="email_sanne" href="https://hibernate.onjira.com/secure/ViewProfile.jspa?name=sanne" style="color:#6c797f;">Sanne Grinovero</a>
commented on <img src="https://hibernate.onjira.com/images/icons/newfeature.gif" height="16" width="16" border="0" align="absmiddle" alt="New Feature"> <a style='color:#6c797f;text-decoration:none;' href='https://hibernate.onjira.com/browse/HSEARCH-1268'>HSEARCH-1268</a>
</div>
<div id="email-summary" style="font-size:16px;line-height:20px;padding:2px 0 16px 0;">
<a style='color:#6c797f;text-decoration:none;' href='https://hibernate.onjira.com/browse/HSEARCH-1268'><strong>Make it possible to plug in a custom MassIndexer implementation</strong></a>
</div>
</td>
</tr>
</table>
</td>
</tr>
<tr valign="top">
<td id="email-fields" style="padding:0 32px 32px 32px;">
<table border="0" cellpadding="0" cellspacing="0" style="padding:0;text-align:left;width:100%;" width="100%">
<tr valign="top">
<td id="email-gutter" style="width:64px;white-space:nowrap;"></td>
<td>
<table border="0" cellpadding="0" cellspacing="0" width="100%">
<tr valign="top">
<td colspan="2" style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 0 16px 0;width:100%;">
<div class="comment-block" style="background-color:#edf5ff;border:1px solid #dddddd;color:#000000;padding:12px;"><p><sannegrinovero> emmanuel, with DavideD we where looking at how to let OGM plug in a different indexing strategy.<br/>
<sannegrinovero> the initial thought was to use the ServiceRegistry in Search to load a custom one, and have this configured by a configuration property.<br/>
<sannegrinovero> So OGM could set the property and provide the alternative implementation based on the GridDialect capabilities<br/>
<sannegrinovero> but ..<br/>
<sannegrinovero> the ServiceRegistry in Search is bound to the lifecycle (can be used only during the initialization context), and this is specific to the code of hibernate-search-engine<br/>
<sannegrinovero> which doesn't know about the MassIndexer as that's ORM specific.<br/>
<sannegrinovero> So we're going to use the Hibernate ORM ServiceRegistry, looks good to you?<br/>
<emmanuel> sannegrinovero: yes I think the ORM SR is the way to go for OGM<br/>
<emmanuel> We are deep into ORM territory anyways<br/>
<emmanuel> but I'm not sure what you mean by different indexing strategy<br/>
<emmanuel> is that to customize Hibernate Search?<br/>
<sannegrinovero> yes to override the implementation it's going to create when creating a MassIndexer<br/>
<sannegrinovero> fullTextSession#createIndexer<br/>
<emmanuel> isn't SearchConfiguration the proper integraiton point?<br/>
<sannegrinovero> mm OGM doesn't override that one<br/>
<sannegrinovero> that used to be the integration point for Infinispan Query<br/>
<sannegrinovero> I'd expect OGM to set a simple property defining the FQCN of an alternative MassIndexerFactory<br/>
<sannegrinovero> so to keep it transparent to the user<br/>
<emmanuel> let me look<br/>
<emmanuel> sannegrinovero: I might be wrong but I think Searchconfiguration should expose this factory contract<br/>
<sannegrinovero> emmanuel, so OGM is going to implement a custom SearchConfiguration ?<br/>
<emmanuel> SearchConfigurationFromHibernateCore can then use a hibernate.search. config proeprty to resolve that<br/>
<emmanuel> no<br/>
<emmanuel> I imagine the MAssIndexer for ISPN is different than for regular ORM than for OGM<br/>
<emmanuel> but for a regular ORM usage or a regular Infinispan usage do you want to have diff implementations?<br/>
<sannegrinovero> they have already<br/>
<sannegrinovero> but for Infinispan it's different as it has its own API and so its own factory for batch-reindeing.<br/>
<sannegrinovero> there is no FullTextSession there <img class="emoticon" src="https://hibernate.onjira.com/images/icons/emoticons/smile.gif" height="20" width="20" align="absmiddle" alt="" border="0"/><br/>
<emmanuel> I see<br/>
<emmanuel> you could have reuse MAssIndexer's API but it might be riddled with SQL specific stuff<br/>
<emmanuel> ok, then a regular factory is fine I suppose<br/>
<sannegrinovero> emmanuel, you can't use SearchConfiguration interface either as it's in the hibernate-search-engine module .. no dependencies to MassIndexer in the ORM module allowed.<br/>
<emmanuel> ok<br/>
<sannegrinovero> So our candidate is HibernateSearchIntegrator, to read the property naming a FQCN, instantiate it, and register it in the ORM registry.<br/>
<emmanuel> Hum<br/>
<sannegrinovero> the FTSession will just have to take it from the registry and invoke the factory method.<br/>
<emmanuel> but that's a Search object<br/>
<emmanuel> Why don't you keep at the SearchFactory level<br/>
<sannegrinovero> because it can't depend on ORM either <img class="emoticon" src="https://hibernate.onjira.com/images/icons/emoticons/smile.gif" height="20" width="20" align="absmiddle" alt="" border="0"/><br/>
<sannegrinovero> this was my same train of thoughts<br/>
<sannegrinovero> ended up thinking we need a common repository for all those services needed by hibernate-search-ORM which can't have appropriate fields in SearchFactory<br/>
<sannegrinovero> and thought - since we're clearly in ORM world - to use the existing registry.<br/>
<sannegrinovero> (the ORM existing registry)<br/>
<emmanuel> ah I sort of get it<br/>
<emmanuel> no I don't<br/>
<emmanuel> "<br/>
<emmanuel> because it can't depend on ORM either<br/>
<emmanuel> "<br/>
<emmanuel> WDYM?<br/>
<sannegrinovero> SearchFactory can't depend on types in the package hibernate-search-orm<br/>
<sannegrinovero> If you really want we could move the MassIndexer interface into the hibernate-search-engine module but that looks fishy imho<br/>
<emmanuel> sannegrinovero: ok so your reasoning is that a service specific to search-orm can happily live in the ORM registry<br/>
<emmanuel> I guess that makes sense<br/>
<sannegrinovero> yes I hope so <img class="emoticon" src="https://hibernate.onjira.com/images/icons/emoticons/smile.gif" height="20" width="20" align="absmiddle" alt="" border="0"/><br/>
<emmanuel> it goes a step away from a Hibernate independent orm module but that's nto a strong goal<br/>
<sannegrinovero> looks like a good home, even for more services to come, if any.</p></div>
<div style="color:#505050;padding:4px 0 0 0;"> </div>
</td>
</tr>
</table>
</td>
</tr>
</table>
</td>
</tr>
</table>
</td><!-- End #email-page -->
</tr>
<tr valign="top">
<td style="color:#505050;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:10px;line-height:14px;padding: 0 16px 16px 16px;text-align:center;">
This message is automatically generated by JIRA.<br />
If you think it was sent incorrectly, please contact your JIRA administrators<br />
For more information on JIRA, see: <a style='color:#6c797f;' href='http://www.atlassian.com/software/jira'>http://www.atlassian.com/software/jira</a>
</td>
</tr>
</table><!-- End #email-wrap -->
</div><!-- End #email-body -->