<style>
/* Changing the layout to use less space for mobiles */
@media screen and (max-device-width: 480px), screen and (-webkit-min-device-pixel-ratio: 2) {
#email-body { min-width: 30em !important; }
#email-page { padding: 8px !important; }
#email-banner { padding: 8px 8px 0 8px !important; }
#email-avatar { margin: 1px 8px 8px 0 !important; padding: 0 !important; }
#email-fields { padding: 0 8px 8px 8px !important; }
#email-gutter { width: 0 !important; }
}
</style>
<div id="email-body">
<table id="email-wrap" align="center" border="0" cellpadding="0" cellspacing="0" style="background-color:#f0f0f0;color:#000000;width:100%;">
<tr valign="top">
<td id="email-page" style="padding:16px !important;">
<table align="center" border="0" cellpadding="0" cellspacing="0" style="background-color:#ffffff;border:1px solid #bbbbbb;color:#000000;width:100%;">
<tr valign="top">
<td bgcolor="#3e4c4e" style="background-color:#3e4c4e;color:#ffffff;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;line-height:1;"><img src="https://www.jboss.org/dms/hibernate/images/jira/jiraheader_hibernate.png" alt="" style="vertical-align:top;" /></td>
</tr><tr valign="top">
<td id="email-banner" style="padding:32px 32px 0 32px;">
<table align="left" border="0" cellpadding="0" cellspacing="0" width="100%" style="width:100%;">
<tr valign="top">
<td style="color:#505050;font-family:Arial,FreeSans,Helvetica,sans-serif;padding:0;">
<img id="email-avatar" src="https://hibernate.onjira.com/secure/useravatar?ownerId=emmanuel&avatarId=10641" alt="" height="48" width="48" border="0" align="left" style="padding:0;margin: 0 16px 16px 0;" />
<div id="email-action" style="padding: 0 0 8px 0;font-size:12px;line-height:18px;">
<a class="user-hover" rel="emmanuel" id="email_emmanuel" href="https://hibernate.onjira.com/secure/ViewProfile.jspa?name=emmanuel" style="color:#6c797f;">Emmanuel Bernard</a>
commented on <img src="https://hibernate.onjira.com/images/icons/improvement.gif" height="16" width="16" border="0" align="absmiddle" alt="Improvement"> <a style='color:#6c797f;text-decoration:none;' href='https://hibernate.onjira.com/browse/BVAL-344'>BVAL-344</a>
</div>
<div id="email-summary" style="font-size:16px;line-height:20px;padding:2px 0 16px 0;">
<a style='color:#6c797f;text-decoration:none;' href='https://hibernate.onjira.com/browse/BVAL-344'><strong>Improve wording around CDI integration</strong></a>
</div>
</td>
</tr>
</table>
</td>
</tr>
<tr valign="top">
<td id="email-fields" style="padding:0 32px 32px 32px;">
<table border="0" cellpadding="0" cellspacing="0" style="padding:0;text-align:left;width:100%;" width="100%">
<tr valign="top">
<td id="email-gutter" style="width:64px;white-space:nowrap;"></td>
<td>
<table border="0" cellpadding="0" cellspacing="0" width="100%">
<tr valign="top">
<td colspan="2" style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 0 16px 0;width:100%;">
<div class="comment-block" style="background-color:#edf5ff;border:1px solid #dddddd;color:#000000;padding:12px;"><p>Discussion between Pete and me:</p>
<div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent">
<pre class="code-java">Pete Muir
22:32
what does <span class="code-quote">"By <span class="code-keyword">default</span>, getters (as defined in http:<span class="code-comment">//beanvalidation.org/latest-draft/spec/#constraintdeclarationvalidationprocess-requirements) are not considered constrained methods."</span> mean?
</span>Emmanuel
22:33
@NotNull <span class="code-object">String</span> getName() { … } is not validated
Pete Muir
22:33
ok, and you guys handle that in BV code?
22:33
BV impl code?
Emmanuel
22:33
@NotNull <span class="code-object">String</span> getBestTeam(SportType type); is validated
22:33
No <span class="code-keyword">this</span> filtering is part of the code that will bind interceptors
22:34
it won't intercept getters (unless @validateExecutable overrides it somehow)
Pete Muir
22:34
got it
22:34
btw
22:34
@ValidateExecutable(type=GETTER_METHODS)
@Min(0)
<span class="code-object">Integer</span> getBacklog() { ... }
Emmanuel
22:34
I was <span class="code-keyword">for</span> having BV doing a noop ie handling @ValidateExecutable etc but Hardy and Gunnar were against
Pete Muir
22:34
<span class="code-keyword">this</span> is very odd to look at
Emmanuel
22:35
So I al considering making ALL the <span class="code-keyword">default</span> value <span class="code-keyword">for</span> @ValidateExecutable.type
22:35
so your example would become
@ValidateExecutable
@Min(0)
<span class="code-object">Integer</span> getBacklog() { ... }
22:36
Still to disable it, you need to use it
@ValidateExecutable(type=NONE)
@Min(0)
<span class="code-object">Integer</span> getBacklog(<span class="code-object">int</span> level) { ... }
Pete Muir
22:36
yeah
Emmanuel
22:36
But then I am thinking of renaming NONE to OFF to make that <span class="code-keyword">case</span> easier
22:36
Thoughts?
Pete Muir
22:37
makes more sense to me
22:37
what about renaming type -> value
22:37
as well
Emmanuel
22:37
evolution mostly
Pete Muir
22:37
@ValidateExecutable(OFF) and @ValidateExecutable({CONSTRUCTOR, GETTER_METHODS})
Emmanuel
22:38
yes I get that it reads better
22:38
but <span class="code-keyword">if</span> we add <span class="code-keyword">new</span> stuffs, type will make more sense
22:38
but I'll ponder it
Pete Muir
22:38
<span class="code-keyword">true</span>
22:39
I would rewrite Every Bean Validation provider should provide a CDI Extension (or alternative solution provided it fulfills the requirements) -> Every Bean Validation provider should must fulfill the requirements <span class="code-keyword">if</span> CDI is present. For example, <span class="code-keyword">this</span> could be done using a CDI portable extension.
22:39
And, I would change it so that you have:
22:40
(pseudo text) A CDI container integrates with Bean Validation like <span class="code-keyword">this</span>. In a Java EE container, <span class="code-keyword">this</span> integration must be present.
22:40
so you specify how it integrates
22:40
and when it must integrate
22:41
in other situations, whether it must integrate is optional, but <span class="code-keyword">if</span> it does integrate, it must meet your requirements
22:41
does that make sense?
Emmanuel
22:41
yes I get that <span class="code-keyword">if</span> it intergrates -> these are the rules and in EE you must
Pete Muir
22:41
well today you have something different IMO
Emmanuel
22:42
possibly
22:42
Still it's the responsibility of the BV impl to provide <span class="code-keyword">this</span> integration in your rewording
22:42
instead of being the CDI's
Pete Muir
22:42
hmm, no
22:42
it's not defined who must provide
22:42
only that it must be provided
22:42
(and in Java EE that it must be provided)
22:43
So yeah. I would rephrase 10.3 as
Emmanuel
22:43
I see, I read <span class="code-quote">"must fulfill"</span> as <span class="code-quote">"must provide"</span>
Pete Muir
22:43
oh, well you wrote fulfill
22:43
i wouldn't use that word
22:44
10.3 There are several integrations points between Bean Validation and CDI. If a Bean Validation provider wishes to integrate with CDI, it must follow the rules laid out in <span class="code-keyword">this</span> section. In a Java EE container, a Bean Validation provider must integrate with CDI.
22:44
Then in 10.3.1
22:45
start with
22:45
The container must support injection of built-in <span class="code-keyword">default</span> ValidatorFactory and Validator beans via @Inject:
22:45
I would remove the stuff about <span class="code-quote">"has to be via a CDI extension"</span>
22:45
and focus on the actual rules
22:46
I would maybe add a note (non-normative) that you can <span class="code-keyword">do</span> it via an extension
22:46
the actual rules look fine to me
Emmanuel
22:46
good
Pete Muir
22:46
10.3.2 looks good
22:46
10.3.3 <span class="code-quote">"Ordinarily CDI requires that intercepted methods are annotated with a so called interceptor binding annotation. To make method validation implicit by just adding the Bean Validation constraints to a constructor or method, the interceptor biding annotation needs to be added programmatically to any method requiring validation."</span> <span class="code-keyword">this</span> is a mess
22:47
it's specifying implementation
22:49
Bean Validation requires that adding only a constraint to a constructor or method will cause validation to occur. The CDI interceptor binding facility does not directly support <span class="code-keyword">this</span>, but the effect may be achieved using the CDI portable extension SPI, or vendor specific SPIs.
Emmanuel
22:50
Thanks. Indeed the implementation details were the reason <span class="code-keyword">for</span> the overall rewriting
22:51
You mentioned <span class="code-quote">"and when it must integrate"</span>. It's at application startup? Is it when the CDI container starts?
Pete Muir
22:53
i can't find that
22:53
what is the full sentence
Emmanuel
22:54
And, I would change it so that you have:
22:40
(pseudo text) A CDI container integrates with Bean Validation like <span class="code-keyword">this</span>. In a Java EE container, <span class="code-keyword">this</span> integration must be present.
22:40
so you specify how it integrates
22:40
and when it must integrate
22:41
in other situations, whether it must integrate is optional, but <span class="code-keyword">if</span> it does integrate, it must meet your requirements
22:41
does that make sense?
22:54
(quoting you)
22:54
ah that's when as in EE vs SE
22:54
I was thinking when in th lifecycle
22:54
Sorry
Pete Muir
22:55
oh i see
22:55
yes right
22:55
when == what environment
Emmanuel
22:56
I have what I need, thanks man
Pete Muir
22:58
np</pre>
</div></div></div>
<div style="color:#505050;padding:4px 0 0 0;"> </div>
</td>
</tr>
</table>
</td>
</tr>
</table>
</td>
</tr>
</table>
</td><!-- End #email-page -->
</tr>
<tr valign="top">
<td style="color:#505050;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:10px;line-height:14px;padding: 0 16px 16px 16px;text-align:center;">
This message is automatically generated by JIRA.<br />
If you think it was sent incorrectly, please contact your JIRA administrators<br />
For more information on JIRA, see: <a style='color:#6c797f;' href='http://www.atlassian.com/software/jira'>http://www.atlassian.com/software/jira</a>
</td>
</tr>
</table><!-- End #email-wrap -->
</div><!-- End #email-body -->