<style>
/* Changing the layout to use less space for mobiles */
@media screen and (max-device-width: 480px), screen and (-webkit-min-device-pixel-ratio: 2) {
#email-body { min-width: 30em !important; }
#email-page { padding: 8px !important; }
#email-banner { padding: 8px 8px 0 8px !important; }
#email-avatar { margin: 1px 8px 8px 0 !important; padding: 0 !important; }
#email-fields { padding: 0 8px 8px 8px !important; }
#email-gutter { width: 0 !important; }
}
</style>
<div id="email-body">
<table id="email-wrap" align="center" border="0" cellpadding="0" cellspacing="0" style="background-color:#f0f0f0;color:#000000;width:100%;">
<tr valign="top">
<td id="email-page" style="padding:16px !important;">
<table align="center" border="0" cellpadding="0" cellspacing="0" style="background-color:#ffffff;border:1px solid #bbbbbb;color:#000000;width:100%;">
<tr valign="top">
<td bgcolor="#3e4c4e" style="background-color:#3e4c4e;color:#ffffff;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;line-height:1;"><img src="https://www.jboss.org/dms/hibernate/images/jira/jiraheader_hibernate.png" alt="" style="vertical-align:top;" /></td>
</tr><tr valign="top">
<td id="email-banner" style="padding:32px 32px 0 32px;">
<table align="left" border="0" cellpadding="0" cellspacing="0" width="100%" style="width:100%;">
<tr valign="top">
<td style="color:#505050;font-family:Arial,FreeSans,Helvetica,sans-serif;padding:0;">
<img id="email-avatar" src="https://hibernate.onjira.com/secure/useravatar?ownerId=steve&avatarId=10346" alt="" height="48" width="48" border="0" align="left" style="padding:0;margin: 0 16px 16px 0;" />
<div id="email-action" style="padding: 0 0 8px 0;font-size:12px;line-height:18px;">
<a class="user-hover" rel="steve" id="email_steve" href="https://hibernate.onjira.com/secure/ViewProfile.jspa?name=steve" style="color:#6c797f;">Steve Ebersole</a>
commented on <img src="https://hibernate.onjira.com/images/icons/bug.gif" height="16" width="16" border="0" align="absmiddle" alt="Bug"> <a style='color:#6c797f;text-decoration:none;' href='https://hibernate.onjira.com/browse/HHH-7910'>HHH-7910</a>
</div>
<div id="email-summary" style="font-size:16px;line-height:20px;padding:2px 0 16px 0;">
<a style='color:#6c797f;text-decoration:none;' href='https://hibernate.onjira.com/browse/HHH-7910'><strong>Transaction timeout can cause non-threadsafe session access by reaper thread</strong></a>
</div>
</td>
</tr>
</table>
</td>
</tr>
<tr valign="top">
<td id="email-fields" style="padding:0 32px 32px 32px;">
<table border="0" cellpadding="0" cellspacing="0" style="padding:0;text-align:left;width:100%;" width="100%">
<tr valign="top">
<td id="email-gutter" style="width:64px;white-space:nowrap;"></td>
<td>
<table border="0" cellpadding="0" cellspacing="0" width="100%">
<tr valign="top">
<td colspan="2" style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 0 16px 0;width:100%;">
<div class="comment-block" style="background-color:#edf5ff;border:1px solid #dddddd;color:#000000;padding:12px;"><p>To centralize discussions for clarity...</p>
<p>There are 2 code pieces to this. First is in <tt>org.hibernate.engine.transaction.synchronization.internal.SynchronizationCallbackCoordinatorImpl#afterCompletion</tt> which is the target of the JTA registered sync callbacks via simple delegation. I propose that method look like:</p>
<div class="code panel" style="border-style: solid;border-width: 1px;"><div class="codeHeader panelHeader" style="border-bottom-width: 1px;border-bottom-style: solid;"><b>SynchronizationCallbackCoordinatorImpl.java</b></div><div class="codeContent panelContent">
<pre class="code-java">class SynchronizationCallbackCoordinatorImpl <span class="code-keyword">implements</span> SynchronizationCallbackCoordinator {
<span class="code-keyword">private</span> <span class="code-object">int</span> registrationThreadId;
<span class="code-keyword">private</span> <span class="code-object">int</span> delayedCompletionHandlingStatus;
...
<span class="code-keyword">public</span> SynchronizationCallbackCoordinatorImpl(TransactionCoordinator transactionCoordinator) {
...
registrationThreadId = <span class="code-object">Thread</span>.currentThread().getId();
}
<span class="code-keyword">public</span> void reset() {
...
delayedCompletionHandlingStatus = Status.NO_STATUS
}
<span class="code-keyword">public</span> void afterCompletion(<span class="code-object">int</span> status) {
<span class="code-keyword">if</span> ( isNonRegistrationThread() ) {
<span class="code-comment">// <span class="code-keyword">for</span> callbacks coming from a thread different than the one used <span class="code-keyword">for</span> registration,
</span> <span class="code-comment">// we need to delay the completion handling
</span> delayedCompletionHandlingStatus = status;
}
<span class="code-keyword">else</span> {
<span class="code-comment">// otherwise, we <span class="code-keyword">do</span> the completion handling immediately
</span> doAfterCompletion( status );
}
}
<span class="code-keyword">private</span> <span class="code-object">boolean</span> isNonRegistrationThread() {
<span class="code-keyword">return</span> registrationThreadId == <span class="code-object">Thread</span>.currentThread().getId();
}
<span class="code-keyword">private</span> void doAfterCompletion(<span class="code-object">int</span> status) {
...
<span class="code-keyword">try</span> {
afterCompletionAction.doAction( transactionCoordinator, status );
transactionCoordinator.afterTransaction( <span class="code-keyword">null</span>, status );
}
<span class="code-keyword">finally</span> {
reset();
<span class="code-keyword">if</span> ( transactionContext().shouldAutoClose() && !transactionContext().isClosed() ) {
LOG.trace( <span class="code-quote">"Automatically closing session"</span> );
transactionContext().managedClose();
}
}
}</pre>
</div></div>
<p>Then, as stated above. the second piece is to tie into the <tt>Session</tt> method calls. Again, 2 options here. First is to hook in to the entry into the <tt>Session</tt> calls. This option performs the delayed handling until the next time the user calls into the <tt>Session</tt>; and the hooks for this option are already in place - see <tt>org.hibernate.engine.transaction.internal.TransactionCoordinatorImpl#pulse</tt>. The other option is to hook in to the exit from the <tt>Session</tt> calls, which performs the delayed handling as we return from the methods that were processing when a timeout occurred. And we might very well need both.</p></div>
<div style="color:#505050;padding:4px 0 0 0;"> </div>
</td>
</tr>
</table>
</td>
</tr>
</table>
</td>
</tr>
</table>
</td><!-- End #email-page -->
</tr>
<tr valign="top">
<td style="color:#505050;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:10px;line-height:14px;padding: 0 16px 16px 16px;text-align:center;">
This message is automatically generated by JIRA.<br />
If you think it was sent incorrectly, please contact your JIRA administrators<br />
For more information on JIRA, see: <a style='color:#6c797f;' href='http://www.atlassian.com/software/jira'>http://www.atlassian.com/software/jira</a>
</td>
</tr>
</table><!-- End #email-wrap -->
</div><!-- End #email-body -->