<style>
/* Changing the layout to use less space for mobiles */
@media screen and (max-device-width: 480px), screen and (-webkit-min-device-pixel-ratio: 2) {
#email-body { min-width: 30em !important; }
#email-page { padding: 8px !important; }
#email-banner { padding: 8px 8px 0 8px !important; }
#email-avatar { margin: 1px 8px 8px 0 !important; padding: 0 !important; }
#email-fields { padding: 0 8px 8px 8px !important; }
#email-gutter { width: 0 !important; }
}
</style>
<div id="email-body">
<table id="email-wrap" align="center" border="0" cellpadding="0" cellspacing="0" style="background-color:#f0f0f0;color:#000000;width:100%;">
<tr valign="top">
<td id="email-page" style="padding:16px !important;">
<table align="center" border="0" cellpadding="0" cellspacing="0" style="background-color:#ffffff;border:1px solid #bbbbbb;color:#000000;width:100%;">
<tr valign="top">
<td bgcolor="#3e4c4e" style="background-color:#3e4c4e;color:#ffffff;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;line-height:1;"><img src="https://www.jboss.org/dms/hibernate/images/jira/jiraheader_hibernate.png" alt="" style="vertical-align:top;" /></td>
</tr><tr valign="top">
<td id="email-banner" style="padding:32px 32px 0 32px;">
<table align="left" border="0" cellpadding="0" cellspacing="0" width="100%" style="width:100%;">
<tr valign="top">
<td style="color:#505050;font-family:Arial,FreeSans,Helvetica,sans-serif;padding:0;">
<div id="email-action" style="padding: 0 0 8px 0;font-size:12px;line-height:18px;">
<a class="user-hover" rel="steve" id="email_steve" href="https://hibernate.onjira.com/secure/ViewProfile.jspa?name=steve" style="color:#6c797f;">Steve Ebersole</a>
edited a comment on <img src="https://hibernate.onjira.com/images/icons/issue_subtask.gif" height="16" width="16" border="0" align="absmiddle" alt="Sub-task"> <a style='color:#6c797f;text-decoration:none;' href='https://hibernate.onjira.com/browse/HHH-8010'>HHH-8010</a>
</div>
<div id="email-summary" style="font-size:16px;line-height:20px;padding:2px 0 16px 0;">
<a style='color:#6c797f;text-decoration:none;' href='https://hibernate.onjira.com/browse/HHH-8010'><strong>Ensure Hibernate manifests allow user bundle managed SF/EMF</strong></a>
</div>
</td>
</tr>
</table>
</td>
</tr>
<tr valign="top">
<td id="email-fields" style="padding:0 32px 32px 32px;">
<table border="0" cellpadding="0" cellspacing="0" style="padding:0;text-align:left;width:100%;" width="100%">
<tr valign="top">
<td id="email-gutter" style="width:64px;white-space:nowrap;"></td>
<td>
<table border="0" cellpadding="0" cellspacing="0" width="100%">
<tr valign="top">
<td colspan="2" style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 0 16px 0;width:100%;">
<div class="comment-block" style="background-color:#edf5ff;border:1px solid #dddddd;color:#000000;padding:12px;"><p>I assume you mean that the app tries to use the <tt>org.hibernate.boot.registry.BootstrapServiceRegistryBuilder</tt>. Given that assumption...</p>
<p>I think that <tt>org.hibernate.boot.registry.BootstrapServiceRegistryBuilder</tt> is the correct place to integrate this via a static field. I can see 2 different ways this could work, depending on which is more "natural" in a OSGi environment:</p>
<p>1) <tt>org.hibernate.boot.registry.BootstrapServiceRegistryBuilder</tt> contain a static field to hold the "base" set of <tt>ClassLoader</tt> instances to use for <tt>org.hibernate.boot.registry.BootstrapServiceRegistryBuilder#providedClassLoaders</tt>. So when a user in OSGi tries to build a <tt>BootstrapServiceRegistry</tt> via <tt>BootstrapServiceRegistryBuilder</tt>, <tt>BootstrapServiceRegistryBuilder</tt> picks up the static ones (put there by the OSGi integration):</p>
<div class="code panel" style="border-style: solid;border-width: 1px;"><div class="codeHeader panelHeader" style="border-bottom-width: 1px;border-bottom-style: solid;"><b>BootstrapServiceRegistry.java</b></div><div class="codeContent panelContent">
<pre class="code-java"><span class="code-keyword">public</span> class BootstrapServiceRegistryBuilder {
<span class="code-keyword">public</span> <span class="code-keyword">static</span> <span class="code-object">ClassLoader</span>[] environmentSuppliedClassLoaders;
...
<span class="code-keyword">public</span> BootstrapServiceRegistry build() {
<span class="code-keyword">final</span> ClassLoaderService classLoaderService;
<span class="code-keyword">if</span> ( providedClassLoaderService == <span class="code-keyword">null</span> ) {
<span class="code-keyword">final</span> List<<span class="code-object">ClassLoader</span>> classLoaders = <span class="code-keyword">new</span> ArrayList<<span class="code-object">ClassLoader</span>>();
<span class="code-keyword">if</span> ( environmentSuppliedClassLoaders != <span class="code-keyword">null</span> ) {
classLoaders.addAll( Arrays.asList( environmentSuppliedClassLoaders ) );
}
<span class="code-keyword">if</span> ( providedClassLoaders != <span class="code-keyword">null</span> ) {
classLoaders.addAll( providedClassLoaders );
}
classLoaderService = <span class="code-keyword">new</span> ClassLoaderServiceImpl( classLoaders );
}
<span class="code-keyword">else</span> {
classLoaderService = providedClassLoaderService;
}
...
}
}</pre>
</div></div>
<p>This may or may not lead to ClassLoader leak problems, have not thought through it deeply yet (brain-storming, you know). Another slight variation of this would be to have the BootstrapServiceRegistryBuilder check with the "OSGi integration" (where ever appropriate) for this static list of ClassLoaders:</p>
<div class="code panel" style="border-style: solid;border-width: 1px;"><div class="codeHeader panelHeader" style="border-bottom-width: 1px;border-bottom-style: solid;"><b>BootstrapServiceRegistry.java</b></div><div class="codeContent panelContent">
<pre class="code-java"><span class="code-keyword">public</span> class BootstrapServiceRegistryBuilder {
...
<span class="code-keyword">public</span> BootstrapServiceRegistry build() {
<span class="code-keyword">final</span> ClassLoaderService classLoaderService;
<span class="code-keyword">if</span> ( providedClassLoaderService == <span class="code-keyword">null</span> ) {
<span class="code-keyword">final</span> List<<span class="code-object">ClassLoader</span>> classLoaders = <span class="code-keyword">new</span> ArrayList<<span class="code-object">ClassLoader</span>>();
<span class="code-comment">// check with the OSGi integration (names made up to protect the innocent)...
</span> <span class="code-keyword">final</span> List<<span class="code-object">ClassLoader</span>> osgiDefinedClassLoaders = OsgiIntegration.getOsgiDefinedClassLoaders();
<span class="code-keyword">if</span> ( environmentSuppliedClassLoaders != <span class="code-keyword">null</span> ) {
classLoaders.addAll( environmentSuppliedClassLoaders );
}
<span class="code-keyword">if</span> ( providedClassLoaders != <span class="code-keyword">null</span> ) {
classLoaders.addAll( providedClassLoaders );
}
classLoaderService = <span class="code-keyword">new</span> ClassLoaderServiceImpl( classLoaders );
}
<span class="code-keyword">else</span> {
classLoaderService = providedClassLoaderService;
}
...
}
}</pre>
</div></div>
<p>2) The second option is much the same as the above, but using the notion of the OSGi integration supplying a "provided ClassLoaderService" rather than ClassLoaders, much like <tt>org.hibernate.boot.registry.BootstrapServiceRegistryBuilder#providedClassLoaderService</tt> but again statically like above.</p></div>
<div style="color:#505050;padding:4px 0 0 0;"> </div>
</td>
</tr>
</table>
</td>
</tr>
</table>
</td>
</tr>
</table>
</td><!-- End #email-page -->
</tr>
<tr valign="top">
<td style="color:#505050;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:10px;line-height:14px;padding: 0 16px 16px 16px;text-align:center;">
This message is automatically generated by JIRA.<br />
If you think it was sent incorrectly, please contact your JIRA administrators<br />
For more information on JIRA, see: <a style='color:#6c797f;' href='http://www.atlassian.com/software/jira'>http://www.atlassian.com/software/jira</a>
</td>
</tr>
</table><!-- End #email-wrap -->
</div><!-- End #email-body -->