<style>
/* Changing the layout to use less space for mobiles */
@media screen and (max-device-width: 480px), screen and (-webkit-min-device-pixel-ratio: 2) {
#email-body { min-width: 30em !important; }
#email-page { padding: 8px !important; }
#email-banner { padding: 8px 8px 0 8px !important; }
#email-avatar { margin: 1px 8px 8px 0 !important; padding: 0 !important; }
#email-fields { padding: 0 8px 8px 8px !important; }
#email-gutter { width: 0 !important; }
}
</style>
<div id="email-body">
<table id="email-wrap" align="center" border="0" cellpadding="0" cellspacing="0" style="background-color:#f0f0f0;color:#000000;width:100%;">
<tr valign="top">
<td id="email-page" style="padding:16px !important;">
<table align="center" border="0" cellpadding="0" cellspacing="0" style="background-color:#ffffff;border:1px solid #bbbbbb;color:#000000;width:100%;">
<tr valign="top">
<td bgcolor="#3e4c4e" style="background-color:#3e4c4e;color:#ffffff;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;line-height:1;"><img src="https://www.jboss.org/dms/hibernate/images/jira/jiraheader_hibernate.png" alt="" style="vertical-align:top;" /></td>
</tr><tr valign="top">
<td id="email-banner" style="padding:32px 32px 0 32px;">
<table align="left" border="0" cellpadding="0" cellspacing="0" width="100%" style="width:100%;">
<tr valign="top">
<td style="color:#505050;font-family:Arial,FreeSans,Helvetica,sans-serif;padding:0;">
<img id="email-avatar" src="https://hibernate.onjira.com/secure/useravatar?ownerId=sanne&avatarId=11144" alt="" height="48" width="48" border="0" align="left" style="padding:0;margin: 0 16px 16px 0;" />
<div id="email-action" style="padding: 0 0 8px 0;font-size:12px;line-height:18px;">
<a class="user-hover" rel="sanne" id="email_sanne" href="https://hibernate.onjira.com/secure/ViewProfile.jspa?name=sanne" style="color:#6c797f;">Sanne Grinovero</a>
updated <img src="https://hibernate.onjira.com/images/icons/task.gif" height="16" width="16" border="0" align="absmiddle" alt="Task"> <a style='color:#6c797f;text-decoration:none;' href='https://hibernate.onjira.com/browse/OGM-274'>OGM-274</a>
</div>
<div id="email-summary" style="font-size:16px;line-height:20px;padding:2px 0 16px 0;">
<a style='color:#6c797f;text-decoration:none;' href='https://hibernate.onjira.com/browse/OGM-274'><strong>Fix BuiltinTypeTest#testStringMappedTypeSerialisation()</strong></a>
</div>
</td>
</tr>
</table>
</td>
</tr>
<tr valign="top">
<td id="email-fields" style="padding:0 32px 32px 32px;">
<table border="0" cellpadding="0" cellspacing="0" style="padding:0;text-align:left;width:100%;" width="100%">
<tr valign="top">
<td id="email-gutter" style="width:64px;white-space:nowrap;"></td>
<td>
<table border="0" cellpadding="0" cellspacing="0" width="100%">
<tr valign="top">
<td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 10px 10px 0;white-space:nowrap;">
<strong style="font-weight:normal;color:#505050;">Change By:</strong>
</td>
<td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 0 10px 0;width:100%;">
<a class="user-hover" rel="sanne" id="email_sanne" href="https://hibernate.onjira.com/secure/ViewProfile.jspa?name=sanne" style="color:#6c797f;">Sanne Grinovero</a>
(06/Mar/13 6:34 AM)
</td>
</tr>
<tr valign="top">
<td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 10px 10px 0;white-space:nowrap;">
<strong style="font-weight:normal;color:#505050;">Description:</strong>
</td>
<td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 0 10px 0;width:100%;">
<span class="diffcontext"><DavideD> emmanuel, one quick question about the TestHelper#extractEntityTuple<br><DavideD> Andrea is working on the couchDb implementation and he has a problem with the BuiltInTypeTest<br><DavideD> in the test BuiltinTypeTest#testStringMappedTypeSerialisation we check some values after the expected values has been converted to a Stirng and other values without converting them to string<br><DavideD> for example the userId<br><DavideD> If I'm correct the extractTuple should return values as String but the test fails because compares a String (actual value) with a Long (expected value) even if the String value of both is the same<br><DavideD> It seem an error in the test<br></span>
<span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;">* whitingjr (~whitingjr@redhat/jboss/whitingjr) has joined #hibernate-dev<br>* whitingjr has quit (Quit: Leaving.)<br>* stliu has quit (Remote host closed the connection)<br>* whitingjr (~whitingjr@redhat/jboss/whitingjr) has joined #hibernate-dev<br>* whitingjr has quit (Client Quit)<br>* whitingjr (~whitingjr@redhat/jboss/whitingjr) has joined #hibernate-dev<br></span>
<span class="diffcontext"><emmanuel> DavideD: sorry got sidetracked by the internet<br><emmanuel> looking<br><emmanuel> DavideD: yes the test looks wrong<br><emmanuel> It was meant to only test built-in types that convert stuff into string<br><DavideD> is it ok if Andrea fix it by converting to String the expected and actual values?<br><emmanuel> Plus the extractTuple method should return Map<String,Object><br><emmanuel> and not <String,String><br><emmanuel> DavideD: no that does not look like a fix<br><DavideD> So the db should always remember the type of the object saved<br><emmanuel> DavideD: I would remove the test for userId and stockCount<br><emmanuel> these types are not meant to be strings<br><DavideD> Is The purpose of the test to assert values that should be saved as String in the db?<br><emmanuel> DavideD: I think so<br><emmanuel> but then dialects can override types so that's a bit of a mess<br><emmanuel> technicall we would only test the types and not necessarily how the NoSQL stores them<br><emmanuel> DavideD: the purpose is to test the string representation to be specific<br><emmanuel> but if a DB can store big decials in a native format<br><emmanuel> why not<br><emmanuel> can you open an issue to revisit this part of the tests?<br><emmanuel> In he mean time the lines 176 and 177 can go away<br><emmanuel> that's the ones posing problem I imagine</span>
</td>
</tr>
</table>
</td>
</tr>
</table>
</td>
</tr>
</table>
</td><!-- End #email-page -->
</tr>
<tr valign="top">
<td style="color:#505050;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:10px;line-height:14px;padding: 0 16px 16px 16px;text-align:center;">
This message is automatically generated by JIRA.<br />
If you think it was sent incorrectly, please contact your JIRA administrators<br />
For more information on JIRA, see: <a style='color:#6c797f;' href='http://www.atlassian.com/software/jira'>http://www.atlassian.com/software/jira</a>
</td>
</tr>
</table><!-- End #email-wrap -->
</div><!-- End #email-body -->