<style>
/* Changing the layout to use less space for mobiles */
@media screen and (max-device-width: 480px), screen and (-webkit-min-device-pixel-ratio: 2) {
#email-body { min-width: 30em !important; }
#email-page { padding: 8px !important; }
#email-banner { padding: 8px 8px 0 8px !important; }
#email-avatar { margin: 1px 8px 8px 0 !important; padding: 0 !important; }
#email-fields { padding: 0 8px 8px 8px !important; }
#email-gutter { width: 0 !important; }
}
</style>
<div id="email-body">
<table id="email-wrap" align="center" border="0" cellpadding="0" cellspacing="0" style="background-color:#f0f0f0;color:#000000;width:100%;">
<tr valign="top">
<td id="email-page" style="padding:16px !important;">
<table align="center" border="0" cellpadding="0" cellspacing="0" style="background-color:#ffffff;border:1px solid #bbbbbb;color:#000000;width:100%;">
<tr valign="top">
<td bgcolor="#3e4c4e" style="background-color:#3e4c4e;color:#ffffff;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;line-height:1;"><img src="https://www.jboss.org/dms/hibernate/images/jira/jiraheader_hibernate.png" alt="" style="vertical-align:top;" /></td>
</tr><tr valign="top">
<td id="email-banner" style="padding:32px 32px 0 32px;">
<table align="left" border="0" cellpadding="0" cellspacing="0" width="100%" style="width:100%;">
<tr valign="top">
<td style="color:#505050;font-family:Arial,FreeSans,Helvetica,sans-serif;padding:0;">
<img id="email-avatar" src="https://hibernate.onjira.com/secure/useravatar?ownerId=gunnar.morling&avatarId=10345" alt="" height="48" width="48" border="0" align="left" style="padding:0;margin: 0 16px 16px 0;" />
<div id="email-action" style="padding: 0 0 8px 0;font-size:12px;line-height:18px;">
<a class="user-hover" rel="gunnar.morling" id="email_gunnar.morling" href="https://hibernate.onjira.com/secure/ViewProfile.jspa?name=gunnar.morling" style="color:#6c797f;">Gunnar Morling</a>
commented on <img src="https://hibernate.onjira.com/images/icons/improvement.gif" height="16" width="16" border="0" align="absmiddle" alt="Improvement"> <a style='color:#6c797f;text-decoration:none;' href='https://hibernate.onjira.com/browse/HV-763'>HV-763</a>
</div>
<div id="email-summary" style="font-size:16px;line-height:20px;padding:2px 0 16px 0;">
<a style='color:#6c797f;text-decoration:none;' href='https://hibernate.onjira.com/browse/HV-763'><strong>Streamline usage of logging API</strong></a>
</div>
</td>
</tr>
</table>
</td>
</tr>
<tr valign="top">
<td id="email-fields" style="padding:0 32px 32px 32px;">
<table border="0" cellpadding="0" cellspacing="0" style="padding:0;text-align:left;width:100%;" width="100%">
<tr valign="top">
<td id="email-gutter" style="width:64px;white-space:nowrap;"></td>
<td>
<table border="0" cellpadding="0" cellspacing="0" width="100%">
<tr valign="top">
<td colspan="2" style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 0 16px 0;width:100%;">
<div class="comment-block" style="background-color:#edf5ff;border:1px solid #dddddd;color:#000000;padding:12px;"><p>This is based on the discussion at the <a href="https://github.com/hibernate/hibernate-validator/pull/214">pull request</a> for <a href="https://hibernate.onjira.com/browse/HV-754" title="Ignore parameter constraints on generated sub-classes"><del>HV-754</del></a>.</p>
<p>Hardy:</p>
<blockquote>
<p>I think it is more a general thing I am wondering about. I noticed that we pass non strings at other places as well. This behavior is not really as deterministic than building a dedicated string upfront. I guess Member is not a big problem, but we pass for example as well ExecutableElement, which toString can change and is maybe to descriptive for a simple error message. Also we are passing Class objects which leads to a toString of "class com.acme.Foo" instead of the simple class name.<br/>
For this reason I was wondering whether we should not be more careful and only pass strings into the Log class (under the assumption that these strings are properly created).<br/>
Maybe we should investigate this later. I am fine with how it is now. Just wanted to explain my reasoning.</p></blockquote>
<p>Gunnar:</p>
<blockquote>
<p>I totally see where you're coming from and I also stumbled upon the class name issue you describe.</p>
<p>The type-safety fan I am, I still like the typed logging methods, since they avoid calling them with wrong parameters and also spare the caller from creating string representations. It also makes sure that objects of one type are always printed out in the same form (e.g. either the qualified or simple name for classes).</p>
<p>Maybe one could have an approach where one registers some sort of converter with the Log class, which then are used to create string representations of passed objects. I guess it shouldn't be too hard to add something like this to the logging tools.</p></blockquote></div>
<div style="color:#505050;padding:4px 0 0 0;"> </div>
</td>
</tr>
</table>
</td>
</tr>
</table>
</td>
</tr>
</table>
</td><!-- End #email-page -->
</tr>
<tr valign="top">
<td style="color:#505050;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:10px;line-height:14px;padding: 0 16px 16px 16px;text-align:center;">
This message is automatically generated by JIRA.<br />
If you think it was sent incorrectly, please contact your JIRA administrators<br />
For more information on JIRA, see: <a style='color:#6c797f;' href='http://www.atlassian.com/software/jira'>http://www.atlassian.com/software/jira</a>
</td>
</tr>
</table><!-- End #email-wrap -->
</div><!-- End #email-body -->